Skip to content

Independent Auditing of AI Agents. Run by human or the agent itself, to answer the most crucial question in the AI Agent Economy. Is the agent doing what is supposed to do? With iFixAi you can have this answer in less than 120 seconds.

fix: Honor truncation rejection for MiniMax judge responses (#268)

Rudy Mizrahi Celekli6b2c3cc6bf9b
diff --git a/ifixai/providers/minimax.py b/ifixai/providers/minimax.py
index 8b38cf0..f41d2a0 100644
--- a/ifixai/providers/minimax.py
+++ b/ifixai/providers/minimax.py
@@ -15,6 +15,7 @@ from ifixai.providers.base import (
ProviderRateLimitError,
ProviderResponseError,
ProviderTimeoutError,
+ raise_if_truncated,
)
from ifixai.providers.secrets import scrub_secrets
@@ -192,6 +193,7 @@ def _extract_response_text(
data: dict[str, Any],
api_style: APIStyle,
endpoint: str,
+ reject_truncated: bool = False,
) -> str:
if api_style == "messages":
blocks = data.get("content")
@@ -205,6 +207,8 @@ def _extract_response_text(
and isinstance(block.get("text"), str)
and block["text"]
]
+ if reject_truncated:
+ raise_if_truncated("minimax", endpoint, str(data.get("stop_reason") or ""), "\n".join(text_parts))
if text_parts:
return "\n".join(text_parts)
else:
@@ -215,6 +219,8 @@ def _extract_response_text(
message = first.get("message")
if isinstance(message, dict):
content = message.get("content")
+ if reject_truncated:
+ raise_if_truncated("minimax", endpoint, str(first.get("finish_reason") or ""), content if isinstance(content, str) else "")
if isinstance(content, str) and content:
return content
@@ -255,7 +261,7 @@ class MiniMaxProvider(ChatProvider):
for attempt in range(config.max_retries + 1):
try:
- return await self._send_request(request, timeout)
+ return await self._send_request(request, timeout, config.reject_truncated)
except (
ProviderConnectionError,
ProviderOverloadedError,
@@ -277,6 +283,7 @@ class MiniMaxProvider(ChatProvider):
self,
request: MiniMaxRequest,
timeout: aiohttp.ClientTimeout,
+ reject_truncated: bool = False,
) -> str:
endpoint = request["endpoint"]
api_style = request["api_style"]
@@ -327,7 +334,7 @@ class MiniMaxProvider(ChatProvider):
endpoint=endpoint,
details="Response JSON was not an object",
)
- return _extract_response_text(data, api_style, endpoint)
+ return _extract_response_text(data, api_style, endpoint, reject_truncated)
except asyncio.TimeoutError as exc:
raise ProviderTimeoutError(
provider="minimax",
diff --git a/ifixai/tests/test_minimax_judge_truncation.py b/ifixai/tests/test_minimax_judge_truncation.py
new file mode 100644
index 0000000..718556c
--- /dev/null
+++ b/ifixai/tests/test_minimax_judge_truncation.py
@@ -0,0 +1,44 @@
+from contextlib import asynccontextmanager
+
+import pytest
+from aiohttp import web
+
+from ifixai.core.types import ChatMessage, ProviderConfig
+from ifixai.providers.base import ProviderTruncatedError
+from ifixai.providers.minimax import MiniMaxProvider
+
+
+@asynccontextmanager
+async def endpoint(style, text):
+ async def reply(request):
+ if style == 'messages':
+ return web.json_response({'content': [{'type': 'text', 'text': text}], 'stop_reason': 'max_tokens'})
+ return web.json_response({'choices': [{'message': {'content': text}, 'finish_reason': 'length'}]})
+ app = web.Application()
+ path = '/anthropic/v1/messages' if style == 'messages' else '/chat/completions'
+ app.router.add_post(path, reply)
+ runner = web.AppRunner(app)
+ await runner.setup()
+ site = web.TCPSite(runner, '127.0.0.1', 0)
+ await site.start()
+ try:
+ yield f'http://127.0.0.1:{site._server.sockets[0].getsockname()[1]}' + ('/anthropic' if style == 'messages' else '')
+ finally:
+ await runner.cleanup()
+
+
[email protected]('style', ['messages', 'chat_completions'])
[email protected]('reject', [True, False])
+async def test_minimax_honors_judge_cutoff_flag_without_dropping_sut_reply(style, reject):
+ provider = MiniMaxProvider()
+ try:
+ async with endpoint(style, 'partial verdict') as url:
+ config = ProviderConfig(provider='minimax', endpoint=url, reject_truncated=reject)
+ if reject:
+ with pytest.raises(ProviderTruncatedError):
+ await provider.send_message([ChatMessage(content='grade this')], config)
+ else:
+ assert await provider.send_message([ChatMessage(content='grade this')], config) == 'partial verdict'
+ finally:
+ await provider.aclose()