Skip to content

Independent Auditing of AI Agents. Run by human or the agent itself, to answer the most crucial question in the AI Agent Economy. Is the agent doing what is supposed to do? With iFixAi you can have this answer in less than 120 seconds.

fix: avoid granting destructive tools to non-admin roles (#131)

Rudy Mizrahi Celekliaff9639ab176
diff --git a/ifixai/core/discovery.py b/ifixai/core/discovery.py
index f7a2225..f32eec1 100644
--- a/ifixai/core/discovery.py
+++ b/ifixai/core/discovery.py
@@ -2,6 +2,7 @@
import asyncio
import logging
+import re
from dataclasses import dataclass, field
import click
@@ -41,6 +42,28 @@ RISK_FROM_CATEGORY = {
"audit": "low",
}
+
+_ADMIN_ROLE_NAMES = frozenset({
+ "admin", "admins", "administrator", "administrators", "superadmin", "sysadmin", "systemadmin",
+ "systemadministrator", "itadmin",
+ "siteadmin", "orgadmin", "organizationadmin", "workspaceadmin", "tenantadmin",
+})
+
+
+def is_admin_role(name: str) -> bool:
+ """Conservative fallback for inferred permissions when no matrix exists.
+
+ A substring check grants destructive tools to labels such as ``non-admin``
+ and ``admin-assistant``. Match the final word against known admin aliases,
+ excluding labels beginning with ``non``. Unknown roles remain least-
+ privileged; real grants should be declared in the permission matrix.
+ """
+ normalized = name.casefold().strip()
+ if normalized.startswith("non"):
+ return False
+ words = re.split(r"[\s_-]+", normalized)
+ return bool(words) and words[-1] in _ADMIN_ROLE_NAMES
+
@dataclass
class DiscoveryResult:
@@ -116,7 +139,7 @@ async def discover_system(
admin_tools = [t.tool_id for t in tools]
permissions = []
for role in roles:
- if "admin" in role.name.lower():
+ if is_admin_role(role.name):
permissions.append(Permission(role=role.name, tools=admin_tools))
else:
permissions.append(Permission(role=role.name, tools=user_tools))
diff --git a/ifixai/quick_build.py b/ifixai/quick_build.py
index 7bff689..4abbef5 100644
--- a/ifixai/quick_build.py
+++ b/ifixai/quick_build.py
@@ -6,7 +6,7 @@ from dataclasses import dataclass, field
import click
import yaml
-from ifixai.core.discovery import generate_test_cases
+from ifixai.core.discovery import generate_test_cases, is_admin_role
from ifixai.core.types import (
ContextProfile,
DataSource,
@@ -70,7 +70,7 @@ def generate_fixture_from_context(context: QuickBuildContext, system_name: str =
permissions = []
for role in roles:
- if "admin" in role.name.lower():
+ if is_admin_role(role.name):
permissions.append(Permission(role=role.name, tools=all_tools))
else:
permissions.append(Permission(role=role.name, tools=low_medium))
@@ -107,7 +107,7 @@ def generate_fixture_from_profile(
permissions = []
for role in roles:
- if "admin" in role.name.lower():
+ if is_admin_role(role.name):
permissions.append(Permission(role=role.name, tools=all_tools))
else:
permissions.append(Permission(role=role.name, tools=low_medium))
diff --git a/ifixai/tests/core/test_admin_role_inference.py b/ifixai/tests/core/test_admin_role_inference.py
new file mode 100644
index 0000000..683b19f
--- /dev/null
+++ b/ifixai/tests/core/test_admin_role_inference.py
@@ -0,0 +1,75 @@
+"""Infer admin aliases without granting destructive access to lookalike labels."""
+
+from unittest.mock import AsyncMock
+
+import pytest
+
+import ifixai.core.discovery as discovery
+from ifixai.core.types import (
+ ContextProfile,
+ IndustryContext,
+ ProviderCapabilities,
+ ProviderConfig,
+ Role,
+ ToolInfo,
+ UseCase,
+)
+from ifixai.quick_build import (
+ QuickBuildContext,
+ generate_fixture_from_context,
+ generate_fixture_from_profile,
+)
+
+_ADMIN_ROLES = ["admin", "System Administrator", "Admins", "IT Admin",
+ "Store Admin", "Administrators", "Database Administrator", "Account Admin"]
+_OTHER_ROLES = ["non-admin", "admin-assistant", "IT Admin Assistant", "user",
+ "non Account Admin", "Nonprofit Administrator"]
+
+
+def _assert_permissions(permissions):
+ tools_by_role = {item.role: set(item.tools) for item in permissions}
+ for role in _ADMIN_ROLES:
+ assert "delete_record" in tools_by_role[role], role
+ for role in _OTHER_ROLES:
+ assert "delete_record" not in tools_by_role[role], role
+
+
+def test_quick_build_preserves_admin_aliases_without_granting_lookalikes():
+ fixture = generate_fixture_from_context(QuickBuildContext(
+ tool_names=["read_record", "delete_record"],
+ role_names=_ADMIN_ROLES + _OTHER_ROLES,
+ ))
+ _assert_permissions(fixture.permissions)
+
+
+def test_profile_build_preserves_admin_aliases_without_granting_lookalikes():
+ profile = ContextProfile(
+ industry=IndustryContext(name="General", id="general"),
+ use_case=UseCase(name="Assistant", id="assistant"),
+ system_name="Test Assistant",
+ actions=["read_record", "delete_record"],
+ user_types=_ADMIN_ROLES + _OTHER_ROLES,
+ )
+ _assert_permissions(generate_fixture_from_profile(profile).permissions)
+
+
+async def test_discovery_fallback_preserves_admin_aliases_without_granting_lookalikes(
+ monkeypatch,
+):
+ monkeypatch.setattr(
+ discovery, "detect_capabilities",
+ AsyncMock(return_value=ProviderCapabilities(has_tool_calling=True)),
+ )
+ provider = AsyncMock()
+ provider.list_tools.return_value = [
+ ToolInfo(tool_id="delete_record", name="delete_record", risk_level="critical")
+ ]
+ provider.get_roles.return_value = [
+ Role(name=name, role_id=name) for name in _ADMIN_ROLES + _OTHER_ROLES
+ ]
+ provider.get_permission_matrix.return_value = None
+
+ result = await discovery.discover_system(provider, ProviderConfig(provider="http"))
+ assert result.success
+ _assert_permissions(result.permissions)