Independent Auditing of AI Agents. Run by human or the agent itself, to answer the most crucial question in the AI Agent Economy. Is the agent doing what is supposed to do? With iFixAi you can have this answer in less than 120 seconds.
Python agent-evaluationaiai-alignmentai-evaluationai-governanceai-safetyclidiagnostic-tooleu-ai-acthallucination-detectioniso-42001llm-evaluationllm-securitynist-ai-rmfowasp-llmprompt-injectionpythonresponsible-airisk-assessmentrisk-management
fix: preserve all Gemini system message frames (#285)
Rudy Mizrahi Celeklid86ba616fa47
diff --git a/ifixai/providers/gemini.py b/ifixai/providers/gemini.pyindex b3c6eaf..45a6342 100644--- a/ifixai/providers/gemini.py+++ b/ifixai/providers/gemini.py@@ -209,12 +209,12 @@ class GeminiProvider(ChatProvider):def _format_messages(messages: list[ChatMessage],) -> GeminiMessages:- system_instruction = ""+ system_instructions: list[str] = []contents: list[dict] = []for msg in messages:if msg.role == "system":- system_instruction = msg.content+ system_instructions.append(msg.content)else:gemini_role = "model" if msg.role == "assistant" else "user"contents.append(@@ -224,7 +224,7 @@ def _format_messages(})- return GeminiMessages(system_instruction=system_instruction, contents=contents)+ return GeminiMessages(system_instruction="\n".join(system_instructions), contents=contents)def _json_mode_unsupported(exc: google_exceptions.InvalidArgument) -> bool:diff --git a/ifixai/tests/test_gemini_system_messages.py b/ifixai/tests/test_gemini_system_messages.pynew file mode 100644index 0000000..15d13b8--- /dev/null+++ b/ifixai/tests/test_gemini_system_messages.py@@ -0,0 +1,39 @@+"""All system frames survive Gemini's single-instruction request format."""++import pytest++from ifixai.core.types import ChatMessage, ProviderConfig++[email protected]("instructions", [["First frame", "Second frame"], ["Only frame"], []])+async def test_sdk_request_preserves_system_frames_in_order(monkeypatch, instructions):+ pytest.importorskip("google.generativeai")+ glm = pytest.importorskip("google.ai.generativelanguage")+ from ifixai.providers import gemini++ seen = []++ class OwnedTransport:+ async def __aenter__(self):+ return self++ async def __aexit__(self, *args):+ pass++ async def generate_content(self, request, **kwargs):+ seen.append("\n".join(part.text for part in request.system_instruction.parts))+ assert request.contents[0].role == "user"+ assert request.contents[0].parts[0].text == "Question"+ return glm.GenerateContentResponse(candidates=[glm.Candidate(+ content=glm.Content(parts=[glm.Part(text="Owned reply")]),+ finish_reason=glm.Candidate.FinishReason.STOP,+ )])++ monkeypatch.setattr(gemini, "GenerativeServiceAsyncClient", lambda **kwargs: OwnedTransport())+ messages = [ChatMessage(role="system", content=text) for text in instructions]+ messages.append(ChatMessage(role="user", content="Question"))+ result = await gemini.GeminiProvider().send_message(messages,+ ProviderConfig(provider="gemini", api_key="synthetic-owned-key", max_retries=0))+ assert result == "Owned reply"+ assert seen == ["\n".join(instructions)]