Skip to content

Rebuild the object in a reference image as a code-only, procedural, quality-gated, animation-ready Three.js model. Token-efficient image-to-3D.

fix: drop the base's fifth copy of the knife-only family gate

kokorolxfa0575ae7d9c
diff --git a/forge/stage2_spec/validate_sculpt_spec.py b/forge/stage2_spec/validate_sculpt_spec.py
index 36f81ed..a228435 100644
--- a/forge/stage2_spec/validate_sculpt_spec.py
+++ b/forge/stage2_spec/validate_sculpt_spec.py
@@ -861,8 +861,12 @@ def validate_cs2_contract(spec: dict[str, Any], errors: list[str], warnings: lis
errors.append("cs2Intake.route must be a supported CS2 route")
if tier not in CS2_EXACTNESS_TIERS:
errors.append("cs2Intake.exactnessTier must be a supported exactness tier")
- if intake.get("itemFamily") != "knife":
- errors.append("cs2Intake requires the registered knife adapter")
+ # No family gate here. The base names no domain (SKILL.md, "Domain plugins"), and the CS2
+ # plugin serves any CS2 item: only the component *tree* is family-specific, and its absence is
+ # recorded as geometrySource=agent-inferred rather than making the spec invalid. This was the
+ # fifth place the knife-only restriction was enforced -- cs2_manifest.py removed the other four
+ # and says so in a comment -- but this copy lived in the base, so every non-knife CS2 item was
+ # still blocked at strict validation.
if route == "reference-projection":
camera = spec.get("referenceCamera")
source = intake.get("deLitAlbedo") or intake.get("sourceImage")
diff --git a/forge/tests/test_pipeline_routing.py b/forge/tests/test_pipeline_routing.py
index b3bf5dc..28ae05b 100644
--- a/forge/tests/test_pipeline_routing.py
+++ b/forge/tests/test_pipeline_routing.py
@@ -146,6 +146,25 @@ class PipelineRoutingTests(unittest.TestCase):
self.assertEqual(errors, [])
self.assertNotIn("pipelineRouting", spec)
+ def test_cs2_contract_accepts_any_item_family(self) -> None:
+ # The knife-only family gate lived on in the base validator after cs2_manifest.py removed
+ # its four plugin-side copies -- every non-knife CS2 item failed strict validation with
+ # "requires the registered knife adapter". Found by a live MP9 run (test-e2e-02).
+ from forge.stage2_spec.validate_sculpt_spec import validate_cs2_contract
+
+ errors: list[str] = []
+ warnings: list[str] = []
+ spec = {
+ "cs2Intake": {
+ "itemFamily": "smg",
+ "route": "procedural-finish",
+ "exactnessTier": "metadata-assisted",
+ }
+ }
+ validate_cs2_contract(spec, errors, warnings)
+ self.assertNotIn("cs2Intake requires the registered knife adapter", errors)
+ self.assertEqual([e for e in errors if "knife" in e], [])
+
if __name__ == "__main__":
unittest.main()