Skip to content

High performance self-hosted photo and video management solution.

chore: speed up lint ~4x by enabling svelte-eslint-parser's ts.sys hook (#30782)

Yuichiro Yamashita01e40c07486e
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 1e147c2502..a24e61a884 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -1033,8 +1033,8 @@ importers:
specifier: ^4.4.6
version: 4.7.4(@typescript/[email protected])([email protected])([email protected](@typescript-eslint/[email protected]))
svelte-eslint-parser:
- specifier: ^1.3.3
- version: 1.8.0([email protected](@typescript-eslint/[email protected]))
+ specifier: ^1.8.1
+ version: 1.8.1([email protected](@typescript-eslint/[email protected]))
tailwindcss:
specifier: ^4.2.4
version: 4.3.3
@@ -10738,8 +10738,8 @@ packages:
resolution: {integrity: sha512-bIoJLOmjCO1S9XdY/DcnR5hJxvrDir1PbGChrzXG3vw0/FOliy/fA3dmdhQ441kah4gKv+TwckGzex6wNS5cnQ==}
engines: {node: '>=4'}
- resolution: {integrity: sha512-HeP7D2wyhkR+XaK6v4W8oRF62Dsz4flyuczALJp61GckGm42u1saSSJ/0auvcBqxs3jMRFEcPK34At/0JBKdOg==}
+ resolution: {integrity: sha512-KvvtD7SrlBP7dlgkBghEE3r84CABm5SmV2aNcG4oCA+qDnJ/tvKonFVvwWAyyWUEwxuNawdfEAZKP9zM3oZ2Uw==}
engines: {node: '>=4'}
@@ -11786,9 +11786,9 @@ packages:
svelte: ^4.0.0 || ^5.0.0-next.0
typescript: ^5.0.0 || ^6.0.0
- resolution: {integrity: sha512-mikR1qwIVy3t5WthUoAXkMwxkXvabZP9FJgdx35Ei7EbGWmctva1Pih16Koeor/bdNNq8NXHlwKGS6NkYTawLg==}
- engines: {node: ^18.18.0 || ^20.9.0 || >=21.1.0, pnpm: 10.34.1}
+ resolution: {integrity: sha512-5zgKBqAf6V8Jyrmr1jViksyG4NKT8NheYwkdxRaMRDAqpGWi9wR8ktcGrAZbfMn/PHUp1BWzAp0cYQECkWuAMA==}
+ engines: {node: ^18.18.0 || ^20.9.0 || >=21.1.0, pnpm: 10.34.5}
peerDependencies:
svelte: ^3.37.0 || ^4.0.0 || ^5.0.0
peerDependenciesMeta:
@@ -14135,9 +14135,9 @@ snapshots:
dependencies:
- '@csstools/selector-specificity': 5.0.0([email protected])
+ '@csstools/selector-specificity': 5.0.0([email protected])
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -14243,9 +14243,9 @@ snapshots:
dependencies:
- '@csstools/selector-specificity': 5.0.0([email protected])
+ '@csstools/selector-specificity': 5.0.0([email protected])
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -14347,7 +14347,7 @@ snapshots:
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -14391,13 +14391,13 @@ snapshots:
dependencies:
postcss: 8.5.26
dependencies:
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -19701,7 +19701,7 @@ snapshots:
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -19709,9 +19709,9 @@ snapshots:
dependencies:
- '@csstools/selector-specificity': 5.0.0([email protected])
+ '@csstools/selector-specificity': 5.0.0([email protected])
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
postcss-value-parser: 4.2.0
@@ -20600,7 +20600,7 @@ snapshots:
postcss-load-config: 3.1.4([email protected])
postcss-safe-parser: 7.0.1([email protected])
semver: 7.8.5
- svelte-eslint-parser: 1.8.0([email protected](@typescript-eslint/[email protected]))
+ svelte-eslint-parser: 1.8.1([email protected](@typescript-eslint/[email protected]))
optionalDependencies:
svelte: 5.56.8(@typescript-eslint/[email protected])
transitivePeerDependencies:
@@ -23857,7 +23857,7 @@ snapshots:
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -23928,12 +23928,12 @@ snapshots:
'@csstools/css-parser-algorithms': 3.0.5(@csstools/[email protected])
'@csstools/css-tokenizer': 3.0.4
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -23966,12 +23966,12 @@ snapshots:
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -24091,13 +24091,13 @@ snapshots:
dependencies:
icss-utils: 5.1.0([email protected])
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
postcss-value-parser: 4.2.0
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -24111,10 +24111,10 @@ snapshots:
dependencies:
- '@csstools/selector-resolve-nested': 3.1.0([email protected])
- '@csstools/selector-specificity': 5.0.0([email protected])
+ '@csstools/selector-resolve-nested': 3.1.0([email protected])
+ '@csstools/selector-specificity': 5.0.0([email protected])
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -24263,7 +24263,7 @@ snapshots:
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
@@ -24296,14 +24296,14 @@ snapshots:
dependencies:
postcss: 8.5.26
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
dependencies:
cssesc: 3.0.0
util-deprecate: 1.0.2
dependencies:
cssesc: 3.0.0
util-deprecate: 1.0.2
@@ -25627,14 +25627,14 @@ snapshots:
transitivePeerDependencies:
- picomatch
dependencies:
eslint-scope: 8.4.0
eslint-visitor-keys: 4.2.1
espree: 10.4.0
postcss: 8.5.26
postcss-scss: 4.0.9([email protected])
- postcss-selector-parser: 7.1.4
+ postcss-selector-parser: 7.1.5
semver: 7.8.5
optionalDependencies:
svelte: 5.56.8(@typescript-eslint/[email protected])
diff --git a/web/eslint.config.js b/web/eslint.config.js
index fc69385c93..f7fd82d751 100644
--- a/web/eslint.config.js
+++ b/web/eslint.config.js
@@ -10,6 +10,7 @@ import parser from 'svelte-eslint-parser';
import typescriptEslint from 'typescript-eslint';
import fs from 'node:fs';
import path from 'node:path';
+import './lint-env.js';
export default typescriptEslint.config(
...eslintPluginSvelte.configs.recommended,
@@ -68,6 +69,7 @@ export default typescriptEslint.config(
'**/yarn.lock',
'**/svelte.config.js',
'eslint.config.js',
+ 'lint-env.js',
'tailwind.config.js',
'coverage',
'vite.config.ts',
diff --git a/web/lint-env.js b/web/lint-env.js
new file mode 100644
index 0000000000..3394cdb783
--- /dev/null
+++ b/web/lint-env.js
@@ -0,0 +1,5 @@
+// Must be imported before eslint-plugin-svelte / svelte-eslint-parser.
+// Enables svelte-eslint-parser's ts.sys hook so typescript-eslint can reuse
+// its TypeScript program across .svelte files instead of rebuilding it per
+// file (~4x faster lint). See https://github.com/sveltejs/eslint-plugin-svelte/issues/1552
+process.env.SVELTE_ESLINT_PARSER_EXPERIMENTAL_TS_SYS_HOOK ??= '1';
diff --git a/web/package.json b/web/package.json
index d709ca0de6..ca0274df88 100644
--- a/web/package.json
+++ b/web/package.json
@@ -90,6 +90,7 @@
"@types/lodash-es": "^4.17.12",
"@types/luxon": "^3.4.2",
"@types/qrcode": "^1.5.5",
+ "@typescript/native": "npm:typescript@^7.0.2",
"@vitest/coverage-v8": "^4.0.0",
"dotenv": "^17.0.0",
"eslint": "^10.2.1",
@@ -107,9 +108,8 @@
"rollup-plugin-visualizer": "^7.0.0",
"svelte": "5.56.8",
"svelte-check": "^4.4.6",
- "svelte-eslint-parser": "^1.3.3",
+ "svelte-eslint-parser": "^1.8.1",
"tailwindcss": "^4.2.4",
- "@typescript/native": "npm:typescript@^7.0.2",
"typescript": "npm:@typescript/typescript6@^6.0.2",
"typescript-eslint": "^8.45.0",
"vite": "^8.0.0",