High performance self-hosted photo and video management solution.
TypeScript backup-toolfluttergoogle-photosgoogle-photos-alternativejavascriptmobile-appnestjsnodejsphoto-galleryphotosphotos-managementself-hostedsveltesveltekittypescriptvideos
chore(deps): update dependency eslint-plugin-unicorn to v76 (#31885)
renovate[bot]0993482b0b37
diff --git a/e2e/package.json b/e2e/package.jsonindex 2df0f7b737..b462f397cb 100644--- a/e2e/package.json+++ b/e2e/package.json@@ -40,7 +40,7 @@"eslint": "^10.0.0","eslint-config-prettier": "^10.1.8","eslint-plugin-prettier": "^5.1.3",- "eslint-plugin-unicorn": "^75.0.0",+ "eslint-plugin-unicorn": "^76.0.0","exiftool-vendored": "^35.0.0","globals": "^17.0.0","luxon": "^3.4.4",diff --git a/e2e/src/ui/generators/timeline/rest-response.ts b/e2e/src/ui/generators/timeline/rest-response.tsindex aecb00920e..5e6ef9d93e 100644--- a/e2e/src/ui/generators/timeline/rest-response.ts+++ b/e2e/src/ui/generators/timeline/rest-response.ts@@ -118,8 +118,8 @@ export function getTimeBucket(if (deletedAssetIds.has(asset.id) || archivedAssetIds.has(asset.id) || favoritedAssetIds.has(asset.id)) {return {...asset,- isFavorite: favoritedAssetIds.has(asset.id) ? true : asset.isFavorite,- isTrashed: deletedAssetIds.has(asset.id) ? true : asset.isTrashed,+ isFavorite: favoritedAssetIds.has(asset.id) || asset.isFavorite,+ isTrashed: deletedAssetIds.has(asset.id) || asset.isTrashed,visibility: archivedAssetIds.has(asset.id) ? AssetVisibility.Archive : asset.visibility,};}diff --git a/packages/cli/package.json b/packages/cli/package.jsonindex 992743525a..31cee5b3fd 100644--- a/packages/cli/package.json+++ b/packages/cli/package.json@@ -33,7 +33,7 @@"eslint": "^10.0.0","eslint-config-prettier": "^10.1.8","eslint-plugin-prettier": "^5.1.3",- "eslint-plugin-unicorn": "^75.0.0",+ "eslint-plugin-unicorn": "^76.0.0","globals": "^17.0.0","mock-fs": "^5.2.0","prettier": "^3.7.4",diff --git a/pnpm-lock.yaml b/pnpm-lock.yamlindex 2276ee7313..f061a0f57c 100644--- a/pnpm-lock.yaml+++ b/pnpm-lock.yaml@@ -157,8 +157,8 @@ importers:specifier: ^5.1.3version: 5.5.6(@types/[email protected])([email protected]([email protected]([email protected])([email protected])))([email protected]([email protected])([email protected]))([email protected])eslint-plugin-unicorn:- specifier: ^75.0.0+ specifier: ^76.0.0exiftool-vendored:specifier: ^35.0.0version: 35.21.0@@ -272,8 +272,8 @@ importers:specifier: ^5.1.3version: 5.5.6(@types/[email protected])([email protected]([email protected]([email protected])([email protected])))([email protected]([email protected])([email protected]))([email protected])eslint-plugin-unicorn:- specifier: ^75.0.0+ specifier: ^76.0.0globals:specifier: ^17.0.0version: 17.12.0@@ -747,8 +747,8 @@ importers:specifier: ^5.1.3version: 5.5.6(@types/[email protected])([email protected]([email protected]([email protected])([email protected])))([email protected]([email protected])([email protected]))([email protected])eslint-plugin-unicorn:- specifier: ^75.0.0+ specifier: ^76.0.0globals:specifier: ^17.0.0version: 17.12.0@@ -1012,8 +1012,8 @@ importers:specifier: ^3.12.4version: 3.23.0([email protected]([email protected])([email protected]))([email protected](@typescript-eslint/[email protected]))eslint-plugin-unicorn:- specifier: ^75.0.0+ specifier: ^76.0.0factory.ts:specifier: ^1.4.1version: 1.4.2@@ -7814,8 +7814,8 @@ packages:svelte:optional: true- resolution: {integrity: sha512-72I7eSn+/z5CpgValFBl9mp2JE5UPD+nUUyB/VIGUMF1rCP1i37mA05zfIAVIU312A+qCZ38T8tSZr3oaMv4Mw==}+ resolution: {integrity: sha512-3ywJrCMHKYhcBP5yFzGaOOX3dY7+iR3hvpuoS/0EnhRFgVWLejly+t4fOdJvWQxJdHZl1C+QBW7hybXPDld4Pw==}engines: {node: '>=22'}peerDependencies:eslint: '>=10.4'@@ -21171,7 +21171,7 @@ snapshots:transitivePeerDependencies:- ts-nodedependencies:'@eslint/css-tree': 4.0.5diff --git a/server/package.json b/server/package.jsonindex 20b02c106f..9dd9f9b082 100644--- a/server/package.json+++ b/server/package.json@@ -156,7 +156,7 @@"eslint-import-resolver-typescript": "^4.4.5","eslint-plugin-import-x": "^4.17.1","eslint-plugin-prettier": "^5.1.3",- "eslint-plugin-unicorn": "^75.0.0",+ "eslint-plugin-unicorn": "^76.0.0","globals": "^17.0.0","mock-fs": "^5.2.0","pngjs": "^7.0.0",diff --git a/server/src/dtos/person.dto.ts b/server/src/dtos/person.dto.tsindex 5bc4d406f1..f946b0d4b0 100644--- a/server/src/dtos/person.dto.ts+++ b/server/src/dtos/person.dto.ts@@ -22,7 +22,7 @@ const PersonCreateSchema = z.meta({ format: 'date' }).nullable().optional()- .refine((val) => (val ? new Date(val) <= new Date() : true), { error: 'Birth date cannot be in the future' })+ .refine((val) => !val || new Date(val) <= new Date(), { error: 'Birth date cannot be in the future' }).describe('Person date of birth'),isHidden: z.boolean().optional().describe('Person visibility (hidden)'),isFavorite: z.boolean().optional().describe('Mark as favorite'),diff --git a/server/src/dtos/workflow.dto.ts b/server/src/dtos/workflow.dto.tsindex 85431b3cb3..c5c08907b3 100644--- a/server/src/dtos/workflow.dto.ts+++ b/server/src/dtos/workflow.dto.ts@@ -160,7 +160,7 @@ export const mapWorkflowShare = (workflow: Workflow & { steps: WorkflowStep[] })method: `${step.pluginName}#${step.methodName}`,// TODO fix thisconfig: step.config as any,- enabled: step.enabled ? undefined : false,+ enabled: step.enabled && undefined,})),};};diff --git a/server/src/repositories/ocr.repository.ts b/server/src/repositories/ocr.repository.tsindex 44e3d6eb60..6de7859fc0 100644--- a/server/src/repositories/ocr.repository.ts+++ b/server/src/repositories/ocr.repository.ts@@ -17,7 +17,7 @@ export class OcrRepository {@GenerateSql({ params: [DummyValue.UUID] })getByAssetId(id: string, options?: { isVisible?: boolean }) {- const isVisible = options === undefined ? true : options.isVisible;+ const isVisible = options === undefined || options.isVisible;return this.db.selectFrom('asset_ocr')diff --git a/server/src/services/shared-link.service.ts b/server/src/services/shared-link.service.tsindex 8a52060939..312fce3b8d 100644--- a/server/src/services/shared-link.service.ts+++ b/server/src/services/shared-link.service.ts@@ -98,7 +98,7 @@ export class SharedLinkService extends BaseService {password: dto.password,expiresAt: dto.expiresAt || null,allowUpload: dto.allowUpload ?? true,- allowDownload: dto.showMetadata === false ? false : (dto.allowDownload ?? true),+ allowDownload: dto.showMetadata !== false && (dto.allowDownload ?? true),showExif: dto.showMetadata ?? true,slug: dto.slug || null,});diff --git a/server/src/services/system-config.service.ts b/server/src/services/system-config.service.tsindex 08f94086eb..ddee3c6a9f 100644--- a/server/src/services/system-config.service.ts+++ b/server/src/services/system-config.service.ts@@ -59,7 +59,7 @@ export class SystemConfigService extends BaseService {@OnEvent({ name: 'ConfigInit', priority: -100 })onConfigInit({ newConfig: { logging, machineLearning } }: ArgOf<'ConfigInit'>) {const { logLevel: envLevel } = this.configRepository.getEnv();- const configLevel = logging.enabled ? logging.level : false;+ const configLevel = logging.enabled && logging.level;const level = envLevel ?? configLevel;this.logger.setLogLevel(level);this.logger.log(`LogLevel=${level} ${envLevel ? '(set via IMMICH_LOG_LEVEL)' : '(set via system config)'}`);diff --git a/web/package.json b/web/package.jsonindex 7c5467fb91..1dc8eebfc5 100644--- a/web/package.json+++ b/web/package.json@@ -100,7 +100,7 @@"eslint-plugin-compat": "^7.0.0","eslint-plugin-prettier": "^5.5.6","eslint-plugin-svelte": "^3.12.4",- "eslint-plugin-unicorn": "^75.0.0",+ "eslint-plugin-unicorn": "^76.0.0","factory.ts": "^1.4.1","globals": "^17.0.0","happy-dom": "^20.0.0",diff --git a/web/src/lib/components/assets/thumbnail/Thumbnail.svelte b/web/src/lib/components/assets/thumbnail/Thumbnail.svelteindex 5726914b07..3ae28029ab 100644--- a/web/src/lib/components/assets/thumbnail/Thumbnail.svelte+++ b/web/src/lib/components/assets/thumbnail/Thumbnail.svelte@@ -229,9 +229,9 @@bind:this={element}data-asset={asset.id}data-thumbnail-focus-container- data-selected={selected ? true : undefined}- data-readonly={readonly ? true : undefined}- data-disabled={disabled ? true : undefined}+ data-selected={selected || undefined}+ data-readonly={readonly || undefined}+ data-disabled={disabled || undefined}tabindex={0}role="link">diff --git a/web/src/lib/managers/memory-manager.svelte.ts b/web/src/lib/managers/memory-manager.svelte.tsindex a122044040..c697401326 100644--- a/web/src/lib/managers/memory-manager.svelte.ts+++ b/web/src/lib/managers/memory-manager.svelte.ts@@ -90,8 +90,8 @@ class MemoryManager {const { showUpcoming, onlyFavorites } = userPreferencesManager.memories;this.setFilters({order: MemorySearchOrder.Desc,- isSaved: onlyFavorites ? true : undefined,- isUpcoming: showUpcoming ? undefined : false,+ isSaved: onlyFavorites || undefined,+ isUpcoming: showUpcoming && undefined,});return this.refresh();diff --git a/web/src/lib/managers/search-manager.svelte.ts b/web/src/lib/managers/search-manager.svelte.tsindex 32cd379fde..126c95c8e9 100644--- a/web/src/lib/managers/search-manager.svelte.ts+++ b/web/src/lib/managers/search-manager.svelte.ts@@ -86,7 +86,7 @@ class SearchManager {display: {isArchive: searchQuery.visibility === AssetVisibility.Archive,isFavorite: searchQuery.isFavorite ?? false,- isNotInAlbum: 'isNotInAlbum' in searchQuery ? (searchQuery.isNotInAlbum ?? false) : false,+ isNotInAlbum: 'isNotInAlbum' in searchQuery && (searchQuery.isNotInAlbum ?? false),},mediaType:searchQuery.type === AssetTypeEnum.Imagediff --git a/web/src/lib/managers/timeline-manager/internal/utils.svelte.ts b/web/src/lib/managers/timeline-manager/internal/utils.svelte.tsindex 0dcf7346f6..618e85454f 100644--- a/web/src/lib/managers/timeline-manager/internal/utils.svelte.ts+++ b/web/src/lib/managers/timeline-manager/internal/utils.svelte.ts@@ -24,5 +24,5 @@ export function updateObject(target: any, source: any): boolean {return updated;}export function isMismatched<T>(option: T | undefined, value: T): boolean {- return option === undefined ? false : option !== value;+ return option !== undefined && option !== value;}diff --git a/web/src/lib/modals/PeopleFilterModal.svelte b/web/src/lib/modals/PeopleFilterModal.svelteindex cd229bba4a..bb073ec8ef 100644--- a/web/src/lib/modals/PeopleFilterModal.svelte+++ b/web/src/lib/modals/PeopleFilterModal.svelte@@ -22,7 +22,21 @@let isHidden = $state(untrack(() => filter.isHidden));let users = $state<UserResponseDto[]>([]);- const cycle = (value?: boolean) => (value === undefined ? true : value ? false : undefined);+ const cycle = (value?: boolean) => {+ switch (value) {+ case undefined: {+ return true;+ }++ case true: {+ return false;+ }++ case false: {+ return undefined;+ }+ }+ };onMount(async () => {try {diff --git a/web/src/lib/stores/sidebar.svelte.ts b/web/src/lib/stores/sidebar.svelte.tsindex 72bc37120d..5a5b1b260c 100644--- a/web/src/lib/stores/sidebar.svelte.ts+++ b/web/src/lib/stores/sidebar.svelte.ts@@ -14,7 +14,7 @@ class SidebarStore {* Toggles the sidebar visibility, if available at the current screen width.*/toggle() {- this.isOpen = mediaQueryManager.isFullSidebar ? true : !this.isOpen;+ this.isOpen = mediaQueryManager.isFullSidebar || !this.isOpen;}}diff --git a/web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte b/web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelteindex be03c3761f..c2a0336c5a 100644--- a/web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte+++ b/web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte@@ -229,7 +229,7 @@return { albumId, order: album.order };});- const isShared = $derived(viewMode === AlbumPageViewMode.SELECT_ASSETS ? false : album.albumUsers.length > 1);+ const isShared = $derived(viewMode !== AlbumPageViewMode.SELECT_ASSETS && album.albumUsers.length > 1);$effect(() => {if (assetViewerManager.isViewing || !isShared) {@@ -251,10 +251,10 @@const isEditor = $derived(isAlbumEditor(album));const isSelectionMode = $derived(- viewMode === AlbumPageViewMode.SELECT_ASSETS ? true : viewMode === AlbumPageViewMode.SELECT_THUMBNAIL,+ viewMode === AlbumPageViewMode.SELECT_ASSETS || viewMode === AlbumPageViewMode.SELECT_THUMBNAIL,);const singleSelect = $derived(- viewMode === AlbumPageViewMode.SELECT_ASSETS ? false : viewMode === AlbumPageViewMode.SELECT_THUMBNAIL,+ viewMode !== AlbumPageViewMode.SELECT_ASSETS && viewMode === AlbumPageViewMode.SELECT_THUMBNAIL,);const showArchiveIcon = $derived(viewMode !== AlbumPageViewMode.SELECT_ASSETS);const onSelect = ({ id }: { id: string }) => {diff --git a/web/src/routes/auth/onboarding/OnboardingUserPrivacy.svelte b/web/src/routes/auth/onboarding/OnboardingUserPrivacy.svelteindex 600e6abeac..7b9ff95e80 100644--- a/web/src/routes/auth/onboarding/OnboardingUserPrivacy.svelte+++ b/web/src/routes/auth/onboarding/OnboardingUserPrivacy.svelte@@ -6,7 +6,7 @@import { onDestroy } from 'svelte';import { t } from 'svelte-i18n';- let gCastEnabled = $state(authManager.authenticated ? authManager.preferences.cast.gCastEnabled : false);+ let gCastEnabled = $state(authManager.authenticated && authManager.preferences.cast.gCastEnabled);onDestroy(async () => {try {