High performance self-hosted photo and video management solution.
TypeScript backup-toolfluttergoogle-photosgoogle-photos-alternativejavascriptmobile-appnestjsnodejsphoto-galleryphotosphotos-managementself-hostedsveltesveltekittypescriptvideos
fix(web): clear unsaved asset description when changing asset (#26255)
Michel Heusschen0da74569f2d6
diff --git a/web/src/lib/components/asset-viewer/detail-panel-description.spec.ts b/web/src/lib/components/asset-viewer/detail-panel-description.spec.tsnew file mode 100644index 0000000000..3175bd8194--- /dev/null+++ b/web/src/lib/components/asset-viewer/detail-panel-description.spec.ts@@ -0,0 +1,65 @@+import { assetFactory } from '@test-data/factories/asset-factory';+import '@testing-library/jest-dom';+import { render, screen } from '@testing-library/svelte';+import userEvent from '@testing-library/user-event';+import DetailPanelDescription from './detail-panel-description.svelte';++describe('DetailPanelDescription', () => {+ it('clears unsaved draft on asset change', async () => {+ const user = userEvent.setup();++ const assetA = assetFactory.build({+ id: 'asset-a',+ exifInfo: { description: '' },+ });+ const assetB = assetFactory.build({+ id: 'asset-b',+ exifInfo: { description: '' },+ });++ const { rerender } = render(DetailPanelDescription, {+ props: {+ asset: assetA,+ isOwner: true,+ },+ });++ const textarea = screen.getByTestId('autogrow-textarea') as HTMLTextAreaElement;+ await user.type(textarea, 'unsaved draft');+ expect(textarea).toHaveValue('unsaved draft');++ await rerender({+ asset: assetB,+ isOwner: true,+ });++ expect(screen.getByTestId('autogrow-textarea')).toHaveValue('');+ });++ it('updates description on asset switch', async () => {+ const assetA = assetFactory.build({+ id: 'asset-a',+ exifInfo: { description: 'first description' },+ });+ const assetB = assetFactory.build({+ id: 'asset-b',+ exifInfo: { description: 'second description' },+ });++ const { rerender } = render(DetailPanelDescription, {+ props: {+ asset: assetA,+ isOwner: true,+ },+ });++ expect(screen.getByTestId('autogrow-textarea')).toHaveValue('first description');++ await rerender({+ asset: assetB,+ isOwner: true,+ });++ expect(screen.getByTestId('autogrow-textarea')).toHaveValue('second description');+ });+});diff --git a/web/src/lib/components/asset-viewer/detail-panel-description.svelte b/web/src/lib/components/asset-viewer/detail-panel-description.svelteindex bc3929f3dd..9aeb7855b6 100644--- a/web/src/lib/components/asset-viewer/detail-panel-description.svelte+++ b/web/src/lib/components/asset-viewer/detail-panel-description.svelte@@ -13,10 +13,10 @@let { asset, isOwner }: Props = $props();- let currentDescription = $derived(asset.exifInfo?.description ?? '');- let description = $derived(currentDescription);+ let description = $derived(asset.exifInfo?.description ?? '');const handleFocusOut = async () => {+ const currentDescription = asset.exifInfo?.description ?? '';if (description === currentDescription) {return;}