Skip to content

High performance self-hosted photo and video management solution.

fix: do not migrate existing users (#22146)

shenlong0e987352bb1e
diff --git a/mobile/lib/utils/migration.dart b/mobile/lib/utils/migration.dart
index f4f0564425..1be8647e3d 100644
--- a/mobile/lib/utils/migration.dart
+++ b/mobile/lib/utils/migration.dart
@@ -62,40 +62,48 @@ Future<void> migrateDatabaseIfNeeded(Isar db, Drift drift) async {
await Store.populateCache();
}
+ await handleBetaMigration(version, await _isNewInstallation(db, drift), SyncStreamRepository(drift));
+
+ if (targetVersion >= 12) {
+ await Store.put(StoreKey.version, targetVersion);
+ return;
+ }
+
+ final shouldTruncate = version < 8 || version < targetVersion;
+
+ if (shouldTruncate) {
+ await _migrateTo(db, targetVersion);
+ }
+}
+
+Future<void> handleBetaMigration(int version, bool isNewInstallation, SyncStreamRepository syncStreamRepository) async {
// Handle migration only for this version
// TODO: remove when old timeline is removed
+ final isBeta = Store.tryGet(StoreKey.betaTimeline);
final needBetaMigration = Store.tryGet(StoreKey.needBetaMigration);
- if (version >= 15 && needBetaMigration == null) {
- // Check both databases directly instead of relying on cache
-
- final isBeta = Store.tryGet(StoreKey.betaTimeline);
- final isNewInstallation = await _isNewInstallation(db, drift);
-
+ if (version <= 15 && needBetaMigration == null) {
// For new installations, no migration needed
// For existing installations, only migrate if beta timeline is not enabled (null or false)
- if (isNewInstallation || isBeta == true || (version > 15 && isBeta == null)) {
+ if (isNewInstallation || isBeta == true) {
await Store.put(StoreKey.needBetaMigration, false);
await Store.put(StoreKey.betaTimeline, true);
} else {
- await drift.reset();
await Store.put(StoreKey.needBetaMigration, true);
}
}
- if (version < 16) {
- await SyncStreamRepository(drift).reset();
- await Store.put(StoreKey.shouldResetSync, true);
- }
-
- if (targetVersion >= 12) {
- await Store.put(StoreKey.version, targetVersion);
- return;
+ if (version > 15) {
+ if (isBeta == null || isBeta) {
+ await Store.put(StoreKey.needBetaMigration, false);
+ await Store.put(StoreKey.betaTimeline, true);
+ } else {
+ await Store.put(StoreKey.needBetaMigration, false);
+ }
}
- final shouldTruncate = version < 8 || version < targetVersion;
-
- if (shouldTruncate) {
- await _migrateTo(db, targetVersion);
+ if (version < 16) {
+ await syncStreamRepository.reset();
+ await Store.put(StoreKey.shouldResetSync, true);
}
}
diff --git a/mobile/test/modules/utils/migration_test.dart b/mobile/test/modules/utils/migration_test.dart
new file mode 100644
index 0000000000..08ab1204a6
--- /dev/null
+++ b/mobile/test/modules/utils/migration_test.dart
@@ -0,0 +1,131 @@
+import 'package:drift/drift.dart' hide isNull;
+import 'package:drift/native.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:immich_mobile/domain/models/store.model.dart';
+import 'package:immich_mobile/domain/services/store.service.dart';
+import 'package:immich_mobile/entities/store.entity.dart';
+import 'package:immich_mobile/infrastructure/repositories/db.repository.dart';
+import 'package:immich_mobile/infrastructure/repositories/store.repository.dart';
+import 'package:immich_mobile/infrastructure/repositories/sync_stream.repository.dart';
+import 'package:immich_mobile/utils/migration.dart';
+import 'package:mocktail/mocktail.dart';
+
+import '../../infrastructure/repository.mock.dart';
+
+void main() {
+ late Drift db;
+ late SyncStreamRepository mockSyncStreamRepository;
+
+ setUpAll(() async {
+ db = Drift(DatabaseConnection(NativeDatabase.memory(), closeStreamsSynchronously: true));
+ await StoreService.init(storeRepository: DriftStoreRepository(db));
+ mockSyncStreamRepository = MockSyncStreamRepository();
+ when(() => mockSyncStreamRepository.reset()).thenAnswer((_) async => {});
+ });
+
+ tearDown(() async {
+ await Store.clear();
+ });
+
+ group('handleBetaMigration Tests', () {
+ group("version < 15", () {
+ test('already on new timeline', () async {
+ await Store.put(StoreKey.betaTimeline, true);
+
+ await handleBetaMigration(14, false, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.betaTimeline), true);
+ expect(Store.tryGet(StoreKey.needBetaMigration), false);
+ });
+
+ test('already on old timeline', () async {
+ await Store.put(StoreKey.betaTimeline, false);
+
+ await handleBetaMigration(14, false, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.needBetaMigration), true);
+ });
+
+ test('fresh install', () async {
+ await Store.delete(StoreKey.betaTimeline);
+ await handleBetaMigration(14, true, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.betaTimeline), true);
+ expect(Store.tryGet(StoreKey.needBetaMigration), false);
+ });
+ });
+
+ group("version == 15", () {
+ test('already on new timeline', () async {
+ await Store.put(StoreKey.betaTimeline, true);
+
+ await handleBetaMigration(15, false, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.betaTimeline), true);
+ expect(Store.tryGet(StoreKey.needBetaMigration), false);
+ });
+
+ test('already on old timeline', () async {
+ await Store.put(StoreKey.betaTimeline, false);
+
+ await handleBetaMigration(15, false, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.needBetaMigration), true);
+ });
+
+ test('fresh install', () async {
+ await Store.delete(StoreKey.betaTimeline);
+ await handleBetaMigration(15, true, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.betaTimeline), true);
+ expect(Store.tryGet(StoreKey.needBetaMigration), false);
+ });
+ });
+
+ group("version > 15", () {
+ test('already on new timeline', () async {
+ await Store.put(StoreKey.betaTimeline, true);
+
+ await handleBetaMigration(16, false, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.betaTimeline), true);
+ expect(Store.tryGet(StoreKey.needBetaMigration), false);
+ });
+
+ test('already on old timeline', () async {
+ await Store.put(StoreKey.betaTimeline, false);
+
+ await handleBetaMigration(16, false, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.betaTimeline), false);
+ expect(Store.tryGet(StoreKey.needBetaMigration), false);
+ });
+
+ test('fresh install', () async {
+ await Store.delete(StoreKey.betaTimeline);
+ await handleBetaMigration(16, true, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.betaTimeline), true);
+ expect(Store.tryGet(StoreKey.needBetaMigration), false);
+ });
+ });
+ });
+
+ group('sync reset tests', () {
+ test('version < 16', () async {
+ await Store.put(StoreKey.shouldResetSync, false);
+
+ await handleBetaMigration(15, false, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.shouldResetSync), true);
+ });
+
+ test('version >= 16', () async {
+ await Store.put(StoreKey.shouldResetSync, false);
+
+ await handleBetaMigration(16, false, mockSyncStreamRepository);
+
+ expect(Store.tryGet(StoreKey.shouldResetSync), false);
+ });
+ });
+}