Skip to content

High performance self-hosted photo and video management solution.

fix: unarchive action doesn't update archive page (#23987)

Min Idzelis2152f20b6cb9
diff --git a/e2e/src/web/specs/timeline/timeline.parallel-e2e-spec.ts b/e2e/src/web/specs/timeline/timeline.parallel-e2e-spec.ts
index e9f29f3413..49a8f38312 100644
--- a/e2e/src/web/specs/timeline/timeline.parallel-e2e-spec.ts
+++ b/e2e/src/web/specs/timeline/timeline.parallel-e2e-spec.ts
@@ -607,8 +607,7 @@ test.describe('Timeline', () => {
visibility: 'timeline',
ids: [assetToArchive.id],
});
- console.log('Skipping assertion - TODO - fix bug with not removing asset from timeline-manager after unarchive');
- // await expect(thumbnail.withAssetId(page, assetToArchive.id)).toHaveCount(0);
+ await expect(thumbnailUtils.withAssetId(page, assetToArchive.id)).toHaveCount(0);
await page.getByText('Photos', { exact: true }).click();
await thumbnailUtils.expectInViewport(page, assetToArchive.id);
});
diff --git a/web/src/lib/components/timeline/actions/ArchiveAction.svelte b/web/src/lib/components/timeline/actions/ArchiveAction.svelte
index 05ef9c99ff..e11da0b2f0 100644
--- a/web/src/lib/components/timeline/actions/ArchiveAction.svelte
+++ b/web/src/lib/components/timeline/actions/ArchiveAction.svelte
@@ -24,12 +24,12 @@
const { clearSelect, getOwnedAssets } = getAssetControlContext();
const handleArchive = async () => {
- const isArchived = unarchive ? AssetVisibility.Timeline : AssetVisibility.Archive;
- const assets = [...getOwnedAssets()].filter((asset) => asset.visibility !== isArchived);
+ const visibility = unarchive ? AssetVisibility.Timeline : AssetVisibility.Archive;
+ const assets = [...getOwnedAssets()].filter((asset) => asset.visibility !== visibility);
loading = true;
- const ids = await archiveAssets(assets, isArchived as AssetVisibility);
+ const ids = await archiveAssets(assets, visibility as AssetVisibility);
if (ids) {
- onArchive?.(ids, isArchived ? AssetVisibility.Archive : AssetVisibility.Timeline);
+ onArchive?.(ids, visibility);
clearSelect();
}
loading = false;