Skip to content

High performance self-hosted photo and video management solution.

fix: prevent server crash when extraction of metadata fails if the assets are corrupted (#26042)

Devansh H Jani2e59dbdc1205
diff --git a/server/src/services/metadata.service.ts b/server/src/services/metadata.service.ts
index 42a18fa540..dac79343e0 100644
--- a/server/src/services/metadata.service.ts
+++ b/server/src/services/metadata.service.ts
@@ -38,6 +38,9 @@ import { isFaceImportEnabled } from 'src/utils/misc';
import { upsertTags } from 'src/utils/tag';
import { Tasks } from 'src/utils/tasks';
+const POSTGRES_INT_MAX = 2_147_483_647;
+const POSTGRES_INT_MIN = -2_147_483_648;
+
/** look for a date from these tags (in order) */
const EXIF_DATE_TAGS: Array<keyof ImmichTags> = [
'SubSecDateTimeOriginal',
@@ -90,7 +93,10 @@ const validate = <T>(value: T): NonNullable<T> | null => {
return null;
}
- if (typeof value === 'number' && (Number.isNaN(value) || !Number.isFinite(value))) {
+ if (
+ typeof value === 'number' &&
+ (Number.isNaN(value) || !Number.isFinite(value) || value < POSTGRES_INT_MIN || value > POSTGRES_INT_MAX)
+ ) {
return null;
}