Skip to content

High performance self-hosted photo and video management solution.

chore(server): cleanup unused query parameters in time bucket (#18893)

Jin Xuan3d3e5dc547d7
diff --git a/mobile/openapi/lib/api/timeline_api.dart b/mobile/openapi/lib/api/timeline_api.dart
index 399e7bde86..33914d5b47 100644
--- a/mobile/openapi/lib/api/timeline_api.dart
+++ b/mobile/openapi/lib/api/timeline_api.dart
@@ -31,10 +31,6 @@ class TimelineApi {
///
/// * [AssetOrder] order:
///
- /// * [num] page:
- ///
- /// * [num] pageSize:
- ///
/// * [String] personId:
///
/// * [String] tagId:
@@ -46,7 +42,7 @@ class TimelineApi {
/// * [bool] withPartners:
///
/// * [bool] withStacked:
- Future<Response> getTimeBucketWithHttpInfo(String timeBucket, { String? albumId, bool? isFavorite, bool? isTrashed, String? key, AssetOrder? order, num? page, num? pageSize, String? personId, String? tagId, String? userId, AssetVisibility? visibility, bool? withPartners, bool? withStacked, }) async {
+ Future<Response> getTimeBucketWithHttpInfo(String timeBucket, { String? albumId, bool? isFavorite, bool? isTrashed, String? key, AssetOrder? order, String? personId, String? tagId, String? userId, AssetVisibility? visibility, bool? withPartners, bool? withStacked, }) async {
// ignore: prefer_const_declarations
final apiPath = r'/timeline/bucket';
@@ -72,12 +68,6 @@ class TimelineApi {
if (order != null) {
queryParams.addAll(_queryParams('', 'order', order));
}
- if (page != null) {
- queryParams.addAll(_queryParams('', 'page', page));
- }
- if (pageSize != null) {
- queryParams.addAll(_queryParams('', 'pageSize', pageSize));
- }
if (personId != null) {
queryParams.addAll(_queryParams('', 'personId', personId));
}
@@ -126,10 +116,6 @@ class TimelineApi {
///
/// * [AssetOrder] order:
///
- /// * [num] page:
- ///
- /// * [num] pageSize:
- ///
/// * [String] personId:
///
/// * [String] tagId:
@@ -141,8 +127,8 @@ class TimelineApi {
/// * [bool] withPartners:
///
/// * [bool] withStacked:
- Future<TimeBucketAssetResponseDto?> getTimeBucket(String timeBucket, { String? albumId, bool? isFavorite, bool? isTrashed, String? key, AssetOrder? order, num? page, num? pageSize, String? personId, String? tagId, String? userId, AssetVisibility? visibility, bool? withPartners, bool? withStacked, }) async {
- final response = await getTimeBucketWithHttpInfo(timeBucket, albumId: albumId, isFavorite: isFavorite, isTrashed: isTrashed, key: key, order: order, page: page, pageSize: pageSize, personId: personId, tagId: tagId, userId: userId, visibility: visibility, withPartners: withPartners, withStacked: withStacked, );
+ Future<TimeBucketAssetResponseDto?> getTimeBucket(String timeBucket, { String? albumId, bool? isFavorite, bool? isTrashed, String? key, AssetOrder? order, String? personId, String? tagId, String? userId, AssetVisibility? visibility, bool? withPartners, bool? withStacked, }) async {
+ final response = await getTimeBucketWithHttpInfo(timeBucket, albumId: albumId, isFavorite: isFavorite, isTrashed: isTrashed, key: key, order: order, personId: personId, tagId: tagId, userId: userId, visibility: visibility, withPartners: withPartners, withStacked: withStacked, );
if (response.statusCode >= HttpStatus.badRequest) {
throw ApiException(response.statusCode, await _decodeBodyBytes(response));
}
diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.json
index 286fa47c66..de01d7e06a 100644
--- a/open-api/immich-openapi-specs.json
+++ b/open-api/immich-openapi-specs.json
@@ -7380,24 +7380,6 @@
"$ref": "#/components/schemas/AssetOrder"
}
},
- {
- "name": "page",
- "required": false,
- "in": "query",
- "schema": {
- "minimum": 1,
- "type": "number"
- }
- },
- {
- "name": "pageSize",
- "required": false,
- "in": "query",
- "schema": {
- "minimum": 1,
- "type": "number"
- }
- },
{
"name": "personId",
"required": false,
diff --git a/open-api/typescript-sdk/src/fetch-client.ts b/open-api/typescript-sdk/src/fetch-client.ts
index e3e12dc56e..3729ccd69f 100644
--- a/open-api/typescript-sdk/src/fetch-client.ts
+++ b/open-api/typescript-sdk/src/fetch-client.ts
@@ -3435,14 +3435,12 @@ export function tagAssets({ id, bulkIdsDto }: {
body: bulkIdsDto
})));
}
-export function getTimeBucket({ albumId, isFavorite, isTrashed, key, order, page, pageSize, personId, tagId, timeBucket, userId, visibility, withPartners, withStacked }: {
+export function getTimeBucket({ albumId, isFavorite, isTrashed, key, order, personId, tagId, timeBucket, userId, visibility, withPartners, withStacked }: {
albumId?: string;
isFavorite?: boolean;
isTrashed?: boolean;
key?: string;
order?: AssetOrder;
- page?: number;
- pageSize?: number;
personId?: string;
tagId?: string;
timeBucket: string;
@@ -3460,8 +3458,6 @@ export function getTimeBucket({ albumId, isFavorite, isTrashed, key, order, page
isTrashed,
key,
order,
- page,
- pageSize,
personId,
tagId,
timeBucket,
diff --git a/server/src/dtos/time-bucket.dto.ts b/server/src/dtos/time-bucket.dto.ts
index f68ce93075..3f4157babb 100644
--- a/server/src/dtos/time-bucket.dto.ts
+++ b/server/src/dtos/time-bucket.dto.ts
@@ -1,6 +1,6 @@
import { ApiProperty } from '@nestjs/swagger';
-import { IsEnum, IsInt, IsString, Min } from 'class-validator';
+import { IsEnum, IsString } from 'class-validator';
import { AssetOrder, AssetVisibility } from 'src/enum';
import { Optional, ValidateAssetVisibility, ValidateBoolean, ValidateUUID } from 'src/validation';
@@ -41,16 +41,6 @@ export class TimeBucketDto {
export class TimeBucketAssetDto extends TimeBucketDto {
@IsString()
timeBucket!: string;
-
- @IsInt()
- @Min(1)
- @Optional()
- page?: number;
-
- @IsInt()
- @Min(1)
- @Optional()
- pageSize?: number;
}
export class TimelineStackResponseDto {