Skip to content

High performance self-hosted photo and video management solution.

refactor(server): remove unused on method (#13830)

Jason Rasmussen40fbef50cf55
diff --git a/server/src/interfaces/event.interface.ts b/server/src/interfaces/event.interface.ts
index 40efaf150c..8b59457914 100644
--- a/server/src/interfaces/event.interface.ts
+++ b/server/src/interfaces/event.interface.ts
@@ -88,7 +88,6 @@ export type EventItem<T extends EmitEvent> = {
export interface IEventRepository {
setup(options: { services: ClassConstructor<unknown>[] }): void;
- on<T extends keyof EventMap>(item: EventItem<T>): void;
emit<T extends keyof EventMap>(event: T, ...args: ArgsOf<T>): Promise<void>;
/**
diff --git a/server/src/repositories/event.repository.ts b/server/src/repositories/event.repository.ts
index bb265196f9..4451ee09c5 100644
--- a/server/src/repositories/event.repository.ts
+++ b/server/src/repositories/event.repository.ts
@@ -57,7 +57,6 @@ export class EventRepository implements OnGatewayConnection, OnGatewayDisconnect
setup({ services }: { services: ClassConstructor<unknown>[] }) {
const reflector = this.moduleRef.get(Reflector, { strict: false });
- const repository = this.moduleRef.get<IEventRepository>(IEventRepository);
const items: Item<EmitEvent>[] = [];
// discovery
@@ -94,7 +93,7 @@ export class EventRepository implements OnGatewayConnection, OnGatewayDisconnect
// register by priority
for (const handler of handlers) {
- repository.on(handler);
+ this.addHandler(handler);
}
}
@@ -134,7 +133,7 @@ export class EventRepository implements OnGatewayConnection, OnGatewayDisconnect
await client.leave(client.nsp.name);
}
- on<T extends EmitEvent>(item: EventItem<T>): void {
+ private addHandler<T extends EmitEvent>(item: EventItem<T>): void {
const event = item.event;
if (!this.emitHandlers[event]) {
diff --git a/server/test/repositories/event.repository.mock.ts b/server/test/repositories/event.repository.mock.ts
index 23f5408005..a425ddef3a 100644
--- a/server/test/repositories/event.repository.mock.ts
+++ b/server/test/repositories/event.repository.mock.ts
@@ -4,7 +4,6 @@ import { Mocked, vitest } from 'vitest';
export const newEventRepositoryMock = (): Mocked<IEventRepository> => {
return {
setup: vitest.fn(),
- on: vitest.fn() as any,
emit: vitest.fn() as any,
clientSend: vitest.fn() as any,
clientBroadcast: vitest.fn() as any,