Skip to content

High performance self-hosted photo and video management solution.

refactor(mobile): activity_api.interface.dart (#19357)

Alex42c2389eb5c4
diff --git a/mobile/lib/interfaces/activity_api.interface.dart b/mobile/lib/interfaces/activity_api.interface.dart
deleted file mode 100644
index 99aef6f4d4..0000000000
--- a/mobile/lib/interfaces/activity_api.interface.dart
+++ /dev/null
@@ -1,16 +0,0 @@
-import 'package:immich_mobile/models/activities/activity.model.dart';
-
-abstract interface class IActivityApiRepository {
- Future<List<Activity>> getAll(
- String albumId, {
- String? assetId,
- });
- Future<Activity> create(
- String albumId,
- ActivityType type, {
- String? assetId,
- String? comment,
- });
- Future<void> delete(String id);
- Future<ActivityStats> getStats(String albumId, {String? assetId});
-}
diff --git a/mobile/lib/repositories/activity_api.repository.dart b/mobile/lib/repositories/activity_api.repository.dart
index 868415caf9..1ee92b2e2f 100644
--- a/mobile/lib/repositories/activity_api.repository.dart
+++ b/mobile/lib/repositories/activity_api.repository.dart
@@ -1,6 +1,5 @@
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:immich_mobile/infrastructure/utils/user.converter.dart';
-import 'package:immich_mobile/interfaces/activity_api.interface.dart';
import 'package:immich_mobile/models/activities/activity.model.dart';
import 'package:immich_mobile/providers/api.provider.dart';
import 'package:immich_mobile/repositories/api.repository.dart';
@@ -10,20 +9,17 @@ final activityApiRepositoryProvider = Provider(
(ref) => ActivityApiRepository(ref.watch(apiServiceProvider).activitiesApi),
);
-class ActivityApiRepository extends ApiRepository
- implements IActivityApiRepository {
+class ActivityApiRepository extends ApiRepository {
final ActivitiesApi _api;
ActivityApiRepository(this._api);
- @override
Future<List<Activity>> getAll(String albumId, {String? assetId}) async {
final response =
await checkNull(_api.getActivities(albumId, assetId: assetId));
return response.map(_toActivity).toList();
}
- @override
Future<Activity> create(
String albumId,
ActivityType type, {
@@ -42,12 +38,10 @@ class ActivityApiRepository extends ApiRepository
return _toActivity(response);
}
- @override
Future<void> delete(String id) {
return checkNull(_api.deleteActivity(id));
}
- @override
Future<ActivityStats> getStats(String albumId, {String? assetId}) async {
final response =
await checkNull(_api.getActivityStatistics(albumId, assetId: assetId));
diff --git a/mobile/lib/services/activity.service.dart b/mobile/lib/services/activity.service.dart
index 5496041416..611d985afe 100644
--- a/mobile/lib/services/activity.service.dart
+++ b/mobile/lib/services/activity.service.dart
@@ -1,10 +1,10 @@
-import 'package:immich_mobile/interfaces/activity_api.interface.dart';
import 'package:immich_mobile/mixins/error_logger.mixin.dart';
import 'package:immich_mobile/models/activities/activity.model.dart';
+import 'package:immich_mobile/repositories/activity_api.repository.dart';
import 'package:logging/logging.dart';
class ActivityService with ErrorLoggerMixin {
- final IActivityApiRepository _activityApiRepository;
+ final ActivityApiRepository _activityApiRepository;
@override
final Logger logger = Logger("ActivityService");