High performance self-hosted photo and video management solution.
TypeScript backup-toolfluttergoogle-photosgoogle-photos-alternativejavascriptmobile-appnestjsnodejsphoto-galleryphotosphotos-managementself-hostedsveltesveltekittypescriptvideos
fix(mobile): prevent crash on video widget dispose (#30078)
Adam Gastineau45a6ea84af6a
diff --git a/mobile/lib/presentation/widgets/asset_viewer/video_viewer.widget.dart b/mobile/lib/presentation/widgets/asset_viewer/video_viewer.widget.dartindex 87f97d5754..ccbaf7660a 100644--- a/mobile/lib/presentation/widgets/asset_viewer/video_viewer.widget.dart+++ b/mobile/lib/presentation/widgets/asset_viewer/video_viewer.widget.dart@@ -91,7 +91,7 @@ class _NativeVideoViewerState extends ConsumerState<NativeVideoViewer> with Widg}case AppLifecycleState.paused:_shouldPlayOnForeground = await _controller?.isPlaying() ?? true;- if (_shouldPlayOnForeground) {+ if (_shouldPlayOnForeground && mounted) {await _notifier.pause();}default:@@ -268,10 +268,13 @@ class _NativeVideoViewerState extends ConsumerState<NativeVideoViewer> with Widgreturn;}- await _notifier.load(source);+ // Grab refs to prevent reading after disposefinal loopVideo = ref.read(appConfigProvider).viewer.loopVideo;- await _notifier.setLoop(!widget.asset.isMotionPhoto && loopVideo);- await _notifier.setVolume(1);+ final localNotifier = _notifier;++ await localNotifier.load(source);+ await localNotifier.setLoop(!widget.asset.isMotionPhoto && loopVideo);+ await localNotifier.setVolume(1);}void _initController(NativeVideoPlayerController nc) {