Skip to content

High performance self-hosted photo and video management solution.

fix(web): removing a person in an asset, doesn't remove the asset in … (#26068)

dolfje5f18110e97eb
diff --git a/web/src/lib/components/faces-page/person-side-panel.svelte b/web/src/lib/components/faces-page/person-side-panel.svelte
index 09334ff71e..6bcede36c3 100644
--- a/web/src/lib/components/faces-page/person-side-panel.svelte
+++ b/web/src/lib/components/faces-page/person-side-panel.svelte
@@ -1,6 +1,7 @@
<script lang="ts">
import OnEvents from '$lib/components/OnEvents.svelte';
import { timeBeforeShowLoadingSpinner } from '$lib/constants';
+ import { eventManager } from '$lib/managers/event-manager.svelte';
import { assetViewingStore } from '$lib/stores/asset-viewing.store';
import { boundingBoxesArray } from '$lib/stores/people.store';
import { getPeopleThumbnailUrl, handlePromiseError } from '$lib/utils';
@@ -174,6 +175,8 @@
await deleteFace({ id: face.id, assetFaceDeleteDto: { force: false } });
+ eventManager.emit('PersonAssetDelete', { id: face.person.id, assetId });
+
peopleWithFaces = peopleWithFaces.filter((f) => f.id !== face.id);
await assetViewingStore.setAssetId(assetId);
diff --git a/web/src/lib/managers/event-manager.svelte.ts b/web/src/lib/managers/event-manager.svelte.ts
index 4093413d1a..ead2ffe4b0 100644
--- a/web/src/lib/managers/event-manager.svelte.ts
+++ b/web/src/lib/managers/event-manager.svelte.ts
@@ -48,6 +48,7 @@ export type Events = {
PersonUpdate: [PersonResponseDto];
PersonThumbnailReady: [{ id: string }];
+ PersonAssetDelete: [{ id: string; assetId: string }];
BackupDeleteStatus: [{ filename: string; isDeleting: boolean }];
BackupDeleted: [{ filename: string }];
diff --git a/web/src/routes/(user)/people/[personId]/[[photos=photos]]/[[assetId=id]]/+page.svelte b/web/src/routes/(user)/people/[personId]/[[photos=photos]]/[[assetId=id]]/+page.svelte
index 641510aae1..57c5730b45 100644
--- a/web/src/routes/(user)/people/[personId]/[[photos=photos]]/[[assetId=id]]/+page.svelte
+++ b/web/src/routes/(user)/people/[personId]/[[photos=photos]]/[[assetId=id]]/+page.svelte
@@ -297,6 +297,14 @@
person = response;
};
+ const handlePersonAssetDelete = async ({ id, assetId }: { id: string; assetId: string }) => {
+ if (id !== person.id) {
+ return;
+ }
+ timelineManager.removeAssets([assetId]);
+ await updateAssetCount();
+ };
+
const { SetDateOfBirth, Favorite, Unfavorite, HidePerson, ShowPerson } = $derived(getPersonActions($t, person));
const SelectFeaturePhoto: ActionItem = {
title: $t('select_featured_photo'),
@@ -315,7 +323,12 @@
};
</script>
-<OnEvents {onPersonUpdate} onAssetsDelete={updateAssetCount} onAssetsArchive={updateAssetCount} />
+<OnEvents
+ {onPersonUpdate}
+ onPersonAssetDelete={handlePersonAssetDelete}
+ onAssetsDelete={updateAssetCount}
+ onAssetsArchive={updateAssetCount}
+/>
<main
class="relative z-0 h-dvh overflow-hidden px-2 md:px-6 md:pt-(--navbar-height-md) pt-(--navbar-height)"