Skip to content

High performance self-hosted photo and video management solution.

fix(mobile): prevent timeline bucket selection provider leak (#32100)

Peter Ombodi6f042bad922b
diff --git a/mobile/lib/presentation/widgets/timeline/header.widget.dart b/mobile/lib/presentation/widgets/timeline/header.widget.dart
index 433118d13c..4f8e2820e2 100644
--- a/mobile/lib/presentation/widgets/timeline/header.widget.dart
+++ b/mobile/lib/presentation/widgets/timeline/header.widget.dart
@@ -102,7 +102,11 @@ class _BulkSelectIconButton extends ConsumerWidget {
}
final isReadonlyModeEnabled = ref.watch(readonlyModeProvider);
- final isAllSelected = ref.watch(bucketSelectionProvider(bucketAssets));
+ final isAllSelected = ref.watch(
+ multiSelectProvider.select(
+ (state) => bucketAssets.isNotEmpty && bucketAssets.every(state.selectedAssets.contains),
+ ),
+ );
return isReadonlyModeEnabled
? const SizedBox.shrink()
diff --git a/mobile/lib/providers/timeline/multiselect.provider.dart b/mobile/lib/providers/timeline/multiselect.provider.dart
index c7a7f9f654..7044e27618 100644
--- a/mobile/lib/providers/timeline/multiselect.provider.dart
+++ b/mobile/lib/providers/timeline/multiselect.provider.dart
@@ -102,14 +102,3 @@ class MultiSelectNotifier extends Notifier<MultiSelectState> {
state = state.copyWith(selectedAssets: selectedAssets);
}
}
-
-final bucketSelectionProvider = Provider.family<bool, List<BaseAsset>>((ref, bucketAssets) {
- final selectedAssets = ref.watch(multiSelectProvider.select((s) => s.selectedAssets));
-
- if (bucketAssets.isEmpty) {
- return false;
- }
-
- // Check if all assets in the bucket are selected
- return bucketAssets.every((asset) => selectedAssets.contains(asset));
-}, dependencies: [multiSelectProvider, timelineServiceProvider]);