Skip to content

High performance self-hosted photo and video management solution.

fix(web): correct tag rounding in search options (#26814)

Michel Heusschen8222781d1fbd
diff --git a/web/src/lib/components/shared-components/search-bar/search-tags-section.svelte b/web/src/lib/components/shared-components/search-bar/search-tags-section.svelte
index 208de3f8a4..b98ffeab90 100644
--- a/web/src/lib/components/shared-components/search-bar/search-tags-section.svelte
+++ b/web/src/lib/components/shared-components/search-bar/search-tags-section.svelte
@@ -2,11 +2,11 @@
import Combobox, { type ComboBoxOption } from '$lib/components/shared-components/combobox.svelte';
import { preferences } from '$lib/stores/user.store';
import { getAllTags, type TagResponseDto } from '@immich/sdk';
- import { Checkbox, Icon, Label, Text } from '@immich/ui';
- import { mdiClose } from '@mdi/js';
+ import { Checkbox, Label, Text } from '@immich/ui';
import { onMount } from 'svelte';
import { t } from 'svelte-i18n';
import { SvelteSet } from 'svelte/reactivity';
+ import TagPill from '../tag-pill.svelte';
interface Props {
selectedTags: SvelteSet<string> | null;
@@ -73,24 +73,7 @@
{#each selectedTags ?? [] as tagId (tagId)}
{@const tag = tagMap[tagId]}
{#if tag}
- <div class="flex group transition-all">
- <span
- class="inline-block h-min whitespace-nowrap ps-3 pe-1 group-hover:ps-3 py-1 text-center align-baseline leading-none text-gray-100 dark:text-immich-dark-gray bg-primary roudned-s-full hover:bg-immich-primary/80 dark:hover:bg-immich-dark-primary/80 transition-all"
- >
- <p class="text-sm">
- {tag.value}
- </p>
- </span>
-
- <button
- type="button"
- class="text-gray-100 dark:text-immich-dark-gray bg-immich-primary/95 dark:bg-immich-dark-primary/95 rounded-e-full place-items-center place-content-center pe-2 ps-1 py-1 hover:bg-immich-primary/80 dark:hover:bg-immich-dark-primary/80 transition-all"
- title={$t('remove_tag')}
- onclick={() => handleRemove(tagId)}
- >
- <Icon icon={mdiClose} />
- </button>
- </div>
+ <TagPill label={tag.value} onRemove={() => handleRemove(tagId)} />
{/if}
{/each}
</section>
diff --git a/web/src/lib/components/shared-components/tag-pill.svelte b/web/src/lib/components/shared-components/tag-pill.svelte
new file mode 100644
index 0000000000..43148c5954
--- /dev/null
+++ b/web/src/lib/components/shared-components/tag-pill.svelte
@@ -0,0 +1,31 @@
+<script lang="ts">
+ import { Icon } from '@immich/ui';
+ import { mdiClose } from '@mdi/js';
+ import { t } from 'svelte-i18n';
+
+ type Props = {
+ label: string;
+ onRemove: () => void;
+ };
+
+ let { label, onRemove }: Props = $props();
+</script>
+
+<div class="flex group transition-all">
+ <span
+ class="inline-block h-min whitespace-nowrap ps-3 pe-1 group-hover:ps-3 py-1 text-center align-baseline leading-none text-gray-100 dark:text-immich-dark-gray bg-primary rounded-s-full hover:bg-immich-primary/80 dark:hover:bg-immich-dark-primary/80 transition-all"
+ >
+ <p class="text-sm">
+ {label}
+ </p>
+ </span>
+
+ <button
+ type="button"
+ class="text-gray-100 dark:text-immich-dark-gray bg-immich-primary/95 dark:bg-immich-dark-primary/95 rounded-e-full place-items-center place-content-center pe-2 ps-1 py-1 hover:bg-immich-primary/80 dark:hover:bg-immich-dark-primary/80 transition-all"
+ title={$t('remove_tag')}
+ onclick={onRemove}
+ >
+ <Icon icon={mdiClose} />
+ </button>
+</div>
diff --git a/web/src/lib/modals/AssetTagModal.svelte b/web/src/lib/modals/AssetTagModal.svelte
index dbd5bdb118..5097be51aa 100644
--- a/web/src/lib/modals/AssetTagModal.svelte
+++ b/web/src/lib/modals/AssetTagModal.svelte
@@ -2,12 +2,13 @@
import { eventManager } from '$lib/managers/event-manager.svelte';
import { tagAssets } from '$lib/utils/asset-utils';
import { getAllTags, upsertTags, type TagResponseDto } from '@immich/sdk';
- import { FormModal, Icon } from '@immich/ui';
- import { mdiClose, mdiTag } from '@mdi/js';
+ import { FormModal } from '@immich/ui';
+ import { mdiTag } from '@mdi/js';
import { onMount } from 'svelte';
import { t } from 'svelte-i18n';
import { SvelteSet } from 'svelte/reactivity';
import Combobox, { type ComboBoxOption } from '../components/shared-components/combobox.svelte';
+ import TagPill from '../components/shared-components/tag-pill.svelte';
interface Props {
onClose: (updated?: boolean) => void;
@@ -81,24 +82,7 @@
{#each selectedIds as tagId (tagId)}
{@const tag = tagMap[tagId]}
{#if tag}
- <div class="flex group transition-all">
- <span
- class="inline-block h-min whitespace-nowrap ps-3 pe-1 group-hover:ps-3 py-1 text-center align-baseline leading-none text-gray-100 dark:text-immich-dark-gray bg-primary rounded-s-full hover:bg-immich-primary/80 dark:hover:bg-immich-dark-primary/80 transition-all"
- >
- <p class="text-sm">
- {tag.value}
- </p>
- </span>
-
- <button
- type="button"
- class="text-gray-100 dark:text-immich-dark-gray bg-immich-primary/95 dark:bg-immich-dark-primary/95 rounded-e-full place-items-center place-content-center pe-2 ps-1 py-1 hover:bg-immich-primary/80 dark:hover:bg-immich-dark-primary/80 transition-all"
- title={$t('remove_tag')}
- onclick={() => handleRemove(tagId)}
- >
- <Icon icon={mdiClose} />
- </button>
- </div>
+ <TagPill label={tag.value} onRemove={() => handleRemove(tagId)} />
{/if}
{/each}
</section>