High performance self-hosted photo and video management solution.
TypeScript backup-toolfluttergoogle-photosgoogle-photos-alternativejavascriptmobile-appnestjsnodejsphoto-galleryphotosphotos-managementself-hostedsveltesveltekittypescriptvideos
fix(web): timeline stuttering with many assets in 1 day (#28509)
Ben Beckford9733fa487230
diff --git a/web/src/lib/components/timeline/AssetLayout.svelte b/web/src/lib/components/timeline/AssetLayout.svelteindex 4ecf71f517..88f03ef46a 100644--- a/web/src/lib/components/timeline/AssetLayout.svelte+++ b/web/src/lib/components/timeline/AssetLayout.svelte@@ -1,6 +1,5 @@<script lang="ts">import type { TimelineAsset } from '$lib/managers/timeline-manager/types';- import { filterIsInOrNearViewport } from '$lib/managers/timeline-manager/utils.svelte';import type { ViewerAsset } from '$lib/managers/timeline-manager/viewer-asset.svelte';import type { VirtualScrollManager } from '$lib/managers/VirtualScrollManager/VirtualScrollManager.svelte';import { uploadAssetsStore } from '$lib/stores/upload';@@ -31,11 +30,14 @@const transitionDuration = $derived(manager.suspendTransitions && !$isUploading ? 0 : 150);const scaleDuration = $derived(transitionDuration === 0 ? 0 : transitionDuration + 100);++ const firstInOrNearViewport = $derived(viewerAssets.findIndex((a) => a.isInOrNearViewport));+ const lastInOrNearViewport = $derived(viewerAssets.findLastIndex((a) => a.isInOrNearViewport));</script><!-- Image grid --><div data-image-grid class="relative overflow-clip" style:height={height + 'px'} style:width={width + 'px'}>- {#each filterIsInOrNearViewport(viewerAssets) as viewerAsset (viewerAsset.id)}+ {#each viewerAssets.slice(firstInOrNearViewport, lastInOrNearViewport + 1) as viewerAsset (viewerAsset.id)}{@const position = viewerAsset.position!}{@const asset = viewerAsset.asset!}diff --git a/web/src/lib/managers/timeline-manager/timeline-day.svelte.ts b/web/src/lib/managers/timeline-manager/timeline-day.svelte.tsindex 73b2c259ae..c3d53be67a 100644--- a/web/src/lib/managers/timeline-manager/timeline-day.svelte.ts+++ b/web/src/lib/managers/timeline-manager/timeline-day.svelte.ts@@ -17,13 +17,13 @@ export class TimelineDay {height = $state(0);width = $state(0);- isInOrNearViewport = $derived.by(() => this.viewerAssets.some((viewAsset) => viewAsset.isInOrNearViewport));#top: number = $state(0);#start: number = $state(0);#row = $state(0);#col = $state(0);#deferredLayout = false;+ #lastInOrNearViewport = -1;constructor(timelineMonth: TimelineMonth, index: number, day: number, groupTitle: string, orderBy: AssetOrderBy) {this.index = index;@@ -154,4 +154,13 @@ export class TimelineDay {get absoluteTimelineDayTop() {return this.timelineMonth.top + this.#top;}++ get isInOrNearViewport() {+ if (this.#lastInOrNearViewport !== -1 && this.viewerAssets[this.#lastInOrNearViewport].isInOrNearViewport) {+ return true;+ }++ this.#lastInOrNearViewport = this.viewerAssets.findIndex((viewAsset) => viewAsset.isInOrNearViewport);+ return this.#lastInOrNearViewport !== -1;+ }}