High performance self-hosted photo and video management solution.
TypeScript backup-toolfluttergoogle-photosgoogle-photos-alternativejavascriptmobile-appnestjsnodejsphoto-galleryphotosphotos-managementself-hostedsveltesveltekittypescriptvideos
fix: pr template not being used and make some changes (#15893)
Nicholas Flamy99de52479e6f
diff --git a/.github/PULL_REQUEST_TEMPLATE/config.yml b/.github/PULL_REQUEST_TEMPLATE/config.ymlindex 6663b04cbc..4172e3df95 100644--- a/.github/PULL_REQUEST_TEMPLATE/config.yml+++ b/.github/PULL_REQUEST_TEMPLATE/config.yml@@ -1,2 +1 @@-blank_issues_enabled: falseblank_pull_request_template_enabled: falsediff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.mddeleted file mode 100644index 83a365eab9..0000000000--- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md+++ /dev/null@@ -1,22 +0,0 @@-## Description-<!--- Describe your changes in detail -->-<!--- Why is this change required? What problem does it solve? -->-<!--- If it fixes an open issue, please link to the issue here. -->--Fixes # (issue)---## How Has This Been Tested?--<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration -->--- [ ] Test A-- [ ] Test B--## Screenshots (if appropriate):---## Checklist:--- [ ] I have performed a self-review of my own code-- [ ] I have made corresponding changes to the documentation if applicable\ No newline at end of filediff --git a/.github/pull_request_template.md b/.github/pull_request_template.mdnew file mode 100644index 0000000000..5d4290fd7b--- /dev/null+++ b/.github/pull_request_template.md@@ -0,0 +1,36 @@+## Description++<!--- Describe your changes in detail -->+<!--- Why is this change required? What problem does it solve? -->+<!--- If it fixes an open issue, please link to the issue here. -->++Fixes # (issue)++## How Has This Been Tested?++<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration -->++- [ ] Test A+- [ ] Test B++<details><summary><h2>Screenshots (if appropriate)</h2></summary>++<!-- Images go below this line. -->++</details>++<!-- API endpoint changes (if relevant)+## API Changes+The `/api/something` endpoint is now `/api/something-else`+-->++## Checklist:++- [ ] I have performed a self-review of my own code+- [ ] I have made corresponding changes to the documentation if applicable+- [ ] I have no unrelated changes in the PR.+- [ ] I have confirmed that any new dependencies are strictly necessary.+- [ ] I have written tests for new code (if applicable)+- [ ] I have followed naming conventions/patterns in the surrounding code+- [ ] All code in `src/services` uses repositories implementations for database calls, filesystem operations, etc.+- [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services`)