High performance self-hosted photo and video management solution.
TypeScript backup-toolfluttergoogle-photosgoogle-photos-alternativejavascriptmobile-appnestjsnodejsphoto-galleryphotosphotos-managementself-hostedsveltesveltekittypescriptvideos
fix: add scoped API permissions to map endpoints (#25423)
Mees Frenselc320146538cf
diff --git a/mobile/openapi/lib/model/permission.dart b/mobile/openapi/lib/model/permission.dartindex d5b9bf5086..37aecc8b9c 100644--- a/mobile/openapi/lib/model/permission.dart+++ b/mobile/openapi/lib/model/permission.dart@@ -82,6 +82,8 @@ class Permission {static const timelinePeriodRead = Permission._(r'timeline.read');static const timelinePeriodDownload = Permission._(r'timeline.download');static const maintenance = Permission._(r'maintenance');+ static const mapPeriodRead = Permission._(r'map.read');+ static const mapPeriodSearch = Permission._(r'map.search');static const memoryPeriodCreate = Permission._(r'memory.create');static const memoryPeriodRead = Permission._(r'memory.read');static const memoryPeriodUpdate = Permission._(r'memory.update');@@ -238,6 +240,8 @@ class Permission {timelinePeriodRead,timelinePeriodDownload,maintenance,+ mapPeriodRead,+ mapPeriodSearch,memoryPeriodCreate,memoryPeriodRead,memoryPeriodUpdate,@@ -429,6 +433,8 @@ class PermissionTypeTransformer {case r'timeline.read': return Permission.timelinePeriodRead;case r'timeline.download': return Permission.timelinePeriodDownload;case r'maintenance': return Permission.maintenance;+ case r'map.read': return Permission.mapPeriodRead;+ case r'map.search': return Permission.mapPeriodSearch;case r'memory.create': return Permission.memoryPeriodCreate;case r'memory.read': return Permission.memoryPeriodRead;case r'memory.update': return Permission.memoryPeriodUpdate;diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.jsonindex 7f09f7b336..cb0c8f8a67 100644--- a/open-api/immich-openapi-specs.json+++ b/open-api/immich-openapi-specs.json@@ -6305,6 +6305,7 @@"state": "Stable"}],+ "x-immich-permission": "map.read","x-immich-state": "Stable"}},@@ -6376,6 +6377,7 @@"state": "Stable"}],+ "x-immich-permission": "map.search","x-immich-state": "Stable"}},@@ -18966,6 +18968,8 @@"timeline.read","timeline.download","maintenance",+ "map.read",+ "map.search","memory.create","memory.read","memory.update",diff --git a/open-api/typescript-sdk/src/fetch-client.ts b/open-api/typescript-sdk/src/fetch-client.tsindex 97745cc5a1..09a0860539 100644--- a/open-api/typescript-sdk/src/fetch-client.ts+++ b/open-api/typescript-sdk/src/fetch-client.ts@@ -5534,6 +5534,8 @@ export enum Permission {TimelineRead = "timeline.read",TimelineDownload = "timeline.download",Maintenance = "maintenance",+ MapRead = "map.read",+ MapSearch = "map.search",MemoryCreate = "memory.create",MemoryRead = "memory.read",MemoryUpdate = "memory.update",diff --git a/server/src/controllers/map.controller.ts b/server/src/controllers/map.controller.tsindex dbd1082561..ae3b56af28 100644--- a/server/src/controllers/map.controller.ts+++ b/server/src/controllers/map.controller.ts@@ -8,7 +8,7 @@ import {MapReverseGeocodeDto,MapReverseGeocodeResponseDto,} from 'src/dtos/map.dto';-import { ApiTag } from 'src/enum';+import { ApiTag, Permission } from 'src/enum';import { Auth, Authenticated } from 'src/middleware/auth.guard';import { MapService } from 'src/services/map.service';@@ -18,7 +18,7 @@ export class MapController {constructor(private service: MapService) {}@Get('markers')- @Authenticated()+ @Authenticated({ permission: Permission.MapRead })@Endpoint({summary: 'Retrieve map markers',description: 'Retrieve a list of latitude and longitude coordinates for every asset with location data.',@@ -28,8 +28,8 @@ export class MapController {return this.service.getMapMarkers(auth, options);}- @Authenticated()@Get('reverse-geocode')+ @Authenticated({ permission: Permission.MapSearch })@HttpCode(HttpStatus.OK)@Endpoint({summary: 'Reverse geocode coordinates',diff --git a/server/src/enum.ts b/server/src/enum.tsindex 8a7e1dc789..5a0f6bdbe0 100644--- a/server/src/enum.ts+++ b/server/src/enum.ts@@ -160,6 +160,9 @@ export enum Permission {Maintenance = 'maintenance',+ MapRead = 'map.read',+ MapSearch = 'map.search',+MemoryCreate = 'memory.create',MemoryRead = 'memory.read',MemoryUpdate = 'memory.update',