High performance self-hosted photo and video management solution.
TypeScript backup-toolfluttergoogle-photosgoogle-photos-alternativejavascriptmobile-appnestjsnodejsphoto-galleryphotosphotos-managementself-hostedsveltesveltekittypescriptvideos
fix: set min values for face detection to reasonable values (#12877)
Daniel Dietzlerec32a9e61093
diff --git a/mobile/openapi/lib/model/facial_recognition_config.dart b/mobile/openapi/lib/model/facial_recognition_config.dartindex 4acfd4e20f..439efbbfae 100644--- a/mobile/openapi/lib/model/facial_recognition_config.dart+++ b/mobile/openapi/lib/model/facial_recognition_config.dart@@ -22,14 +22,14 @@ class FacialRecognitionConfig {bool enabled;- /// Minimum value: 0+ /// Minimum value: 0.1/// Maximum value: 2double maxDistance;/// Minimum value: 1int minFaces;- /// Minimum value: 0+ /// Minimum value: 0.1/// Maximum value: 1double minScore;diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.jsonindex 4e7c711978..99ea313063 100644--- a/open-api/immich-openapi-specs.json+++ b/open-api/immich-openapi-specs.json@@ -9119,7 +9119,7 @@"maxDistance": {"format": "double","maximum": 2,- "minimum": 0,+ "minimum": 0.1,"type": "number"},"minFaces": {@@ -9129,7 +9129,7 @@"minScore": {"format": "double","maximum": 1,- "minimum": 0,+ "minimum": 0.1,"type": "number"},"modelName": {diff --git a/server/src/dtos/model-config.dto.ts b/server/src/dtos/model-config.dto.tsindex dffacc793d..f8b9e2043f 100644--- a/server/src/dtos/model-config.dto.ts+++ b/server/src/dtos/model-config.dto.ts@@ -27,14 +27,14 @@ export class DuplicateDetectionConfig extends TaskConfig {export class FacialRecognitionConfig extends ModelConfig {@IsNumber()- @Min(0)+ @Min(0.1)@Max(1)@Type(() => Number)@ApiProperty({ type: 'number', format: 'double' })minScore!: number;@IsNumber()- @Min(0)+ @Min(0.1)@Max(2)@Type(() => Number)@ApiProperty({ type: 'number', format: 'double' })diff --git a/web/src/lib/components/admin-page/settings/machine-learning-settings/machine-learning-settings.svelte b/web/src/lib/components/admin-page/settings/machine-learning-settings/machine-learning-settings.svelteindex 05a5224bd0..aac8cd5212 100644--- a/web/src/lib/components/admin-page/settings/machine-learning-settings/machine-learning-settings.svelte+++ b/web/src/lib/components/admin-page/settings/machine-learning-settings/machine-learning-settings.svelte@@ -145,7 +145,7 @@desc={$t('admin.machine_learning_min_detection_score_description')}bind:value={config.machineLearning.facialRecognition.minScore}step="0.1"- min={0}+ min={0.1}max={1}disabled={disabled || !config.machineLearning.enabled || !config.machineLearning.facialRecognition.enabled}isEdited={config.machineLearning.facialRecognition.minScore !==@@ -158,7 +158,7 @@desc={$t('admin.machine_learning_max_recognition_distance_description')}bind:value={config.machineLearning.facialRecognition.maxDistance}step="0.1"- min={0}+ min={0.1}max={2}disabled={disabled || !config.machineLearning.enabled || !config.machineLearning.facialRecognition.enabled}isEdited={config.machineLearning.facialRecognition.maxDistance !==