Skip to content

High performance self-hosted photo and video management solution.

fix: don't swallow fetch errors (#30496)

bo0tzzfbd5dc2c618c
diff --git a/server/src/repositories/machine-learning.repository.ts b/server/src/repositories/machine-learning.repository.ts
index c1b14fae0a..208a43aea8 100644
--- a/server/src/repositories/machine-learning.repository.ts
+++ b/server/src/repositories/machine-learning.repository.ts
@@ -178,9 +178,7 @@ export class MachineLearningRepository {
`Machine learning request to "${url}" failed with status ${response.status}: ${response.statusText}`,
);
} catch (error: Error | unknown) {
- this.logger.warn(
- `Machine learning request to "${url}" failed: ${error instanceof Error ? error.message : error}`,
- );
+ this.logger.warn(`Machine learning request to "${url}" failed`, error);
}
this.setHealthy(url, false);
diff --git a/server/src/repositories/oauth.repository.ts b/server/src/repositories/oauth.repository.ts
index 0d56343f53..8aa6cfee91 100644
--- a/server/src/repositories/oauth.repository.ts
+++ b/server/src/repositories/oauth.repository.ts
@@ -123,8 +123,7 @@ export class OAuthRepository {
);
}
- this.logger.error(`OAuth login failed: ${error.message}`);
- this.logger.error(error);
+ this.logger.error('OAuth login failed', error);
throw new Error('OAuth login failed', { cause: error });
}
@@ -223,7 +222,7 @@ export class OAuthRepository {
},
);
} catch (error: any | AggregateError) {
- this.logger.error(`Error in OAuth discovery: ${error}`, error?.stack, error?.errors);
+ this.logger.error('Error in OAuth discovery', error);
throw new InternalServerErrorException(`Error in OAuth discovery: ${error}`, { cause: error });
}
}