Skip to content

High performance self-hosted photo and video management solution.

fix: do not emit AlbumInvite event for owner (#28110)

Daniel Dietzlerfe9e5afcf401
diff --git a/server/src/services/album.service.spec.ts b/server/src/services/album.service.spec.ts
index 1d61272d5c..24e28a9701 100644
--- a/server/src/services/album.service.spec.ts
+++ b/server/src/services/album.service.spec.ts
@@ -196,6 +196,7 @@ describe(AlbumService.name, () => {
expect(mocks.user.get).toHaveBeenCalledWith(albumUser.userId, {});
expect(mocks.user.getMetadata).toHaveBeenCalledWith(owner.id);
expect(mocks.access.asset.checkOwnerAccess).toHaveBeenCalledWith(owner.id, new Set([assetId]), false);
+ expect(mocks.event.emit).toHaveBeenCalledTimes(1);
expect(mocks.event.emit).toHaveBeenCalledWith('AlbumInvite', {
id: album.id,
userId: albumUser.userId,
diff --git a/server/src/services/album.service.ts b/server/src/services/album.service.ts
index ef8a31dcb5..24b0668eb2 100644
--- a/server/src/services/album.service.ts
+++ b/server/src/services/album.service.ts
@@ -114,7 +114,6 @@ export class AlbumService extends BaseService {
throw new BadRequestException('Cannot share album with owner');
}
}
- albumUsers.unshift({ userId: auth.user.id, role: AlbumUserRole.Owner });
const allowedAssetIdsSet = await this.checkAccess({
auth,
@@ -133,7 +132,7 @@ export class AlbumService extends BaseService {
order: getPreferences(userMetadata).albums.defaultAssetOrder,
},
assetIds,
- albumUsers,
+ [{ userId: auth.user.id, role: AlbumUserRole.Owner }, ...albumUsers],
auth.user.id,
);