Skip to content

The design language that makes your AI harness better at design.

JavaScript

Fix: strip inline YAML comments when reading pnpm workspace globs (#570)

Abdul Wahab91f2c7b47e72
diff --git a/cli/engine/design-system.mjs b/cli/engine/design-system.mjs
index 1f07d5815..2601c0d54 100644
--- a/cli/engine/design-system.mjs
+++ b/cli/engine/design-system.mjs
@@ -603,7 +603,7 @@ function readWorkspacePatterns(dir) {
try {
let inPackages = false;
for (const line of fs.readFileSync(path.join(dir, 'pnpm-workspace.yaml'), 'utf-8').split(/\r?\n/)) {
- const trimmed = line.trim();
+ const trimmed = stripInlineYamlComment(line).trim();
if (!trimmed || trimmed.startsWith('#')) continue;
const flow = trimmed.match(/^packages:\s*\[(.*)\]\s*$/);
if (flow) {
diff --git a/tests/detect-cli-design-monorepo.test.mjs b/tests/detect-cli-design-monorepo.test.mjs
index c7767b6b4..1c4fe72c5 100644
--- a/tests/detect-cli-design-monorepo.test.mjs
+++ b/tests/detect-cli-design-monorepo.test.mjs
@@ -117,6 +117,23 @@ describe('detect CLI monorepo DESIGN.md inheritance', () => {
);
});
+ it('pnpm flow list with inline comment and non-standard dirs still detected', () => {
+ const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'impeccable-detect-mono-flow-'));
+ tempRoots.push(dir);
+ fs.writeFileSync(path.join(dir, 'DESIGN.md'), DESIGN_MD);
+ fs.writeFileSync(path.join(dir, 'pnpm-workspace.yaml'), 'packages: ["services/*"] # deploy targets\n');
+ fs.mkdirSync(path.join(dir, 'services/api'), { recursive: true });
+ fs.writeFileSync(path.join(dir, 'services/api/package.json'), '{"name":"api"}');
+ const page = path.join(dir, 'services/api/page.html');
+ fs.writeFileSync(page, PAGE_HTML);
+
+ const findings = runDetect(dir, [page]);
+ assert.ok(
+ fontFindingsFor(findings, page).some((f) => f.ignoreValue === 'verdana'),
+ 'inline YAML comment must not defeat workspace-glob recognition',
+ );
+ });
+
it('directory target: scan apps/web dir inherits root DESIGN.md', () => {
const { dir, page, webDir } = mkPnpmMonorepo();
const findings = runDetect(dir, [webDir]);