Skip to content

The design language that makes your AI harness better at design.

JavaScript

Fix: a waiver scoped to one served root must not hide findings on another

Guitaraholicce1c9f8dad66
diff --git a/skill/scripts/live-browser-ignores.js b/skill/scripts/live-browser-ignores.js
index fd78fe21b..649302fa6 100644
--- a/skill/scripts/live-browser-ignores.js
+++ b/skill/scripts/live-browser-ignores.js
@@ -89,6 +89,13 @@
// Each prefixed path also contributes its slash suffixes, mirroring
// findingMatchesScopedIgnoreFile in cli/lib/impeccable-config.mjs (which
// matches globs against every path suffix of the finding's file).
+ //
+ // With several roots configured, one URL has several possible identities
+ // and the browser cannot tell which root actually serves it. The rooted
+ // groups are therefore kept separate: matchesScope treats a root-prefixed
+ // match as valid only when it holds under every root, so a waiver scoped
+ // to src/foo.html never hides a finding on a page served from
+ // public/foo.html. With a single root this reduces to plain matching.
function pageCandidates(pathname, roots) {
let pagePath = String(pathname || '');
try {
@@ -101,33 +108,39 @@
// name files. Without this, /news/ never matches prototype/news/index.html.
if (pagePath === '' || pagePath.endsWith('/')) pagePath += 'index.html';
- const prefixes = [''];
- for (const entry of Array.isArray(roots) ? roots : []) {
- if (typeof entry !== 'string') continue;
- prefixes.push(entry === '' || entry.endsWith('/') ? entry : entry + '/');
- }
-
- const candidates = new Set();
- for (const prefix of prefixes) {
- const full = prefix + pagePath;
- const parts = full.split('/').filter(Boolean);
+ const suffixesOf = (fullPath) => {
+ const parts = fullPath.split('/').filter(Boolean);
+ const out = [];
for (let i = 0; i < parts.length; i++) {
- candidates.add(parts.slice(i).join('/'));
+ out.push(parts.slice(i).join('/'));
}
+ return out;
+ };
+
+ const rooted = [];
+ for (const entry of Array.isArray(roots) ? roots : []) {
+ if (typeof entry !== 'string') continue;
+ const prefix = entry === '' || entry.endsWith('/') ? entry : entry + '/';
+ rooted.push(suffixesOf(prefix + pagePath));
}
- return [...candidates];
+ return { bare: suffixesOf(pagePath), rooted };
}
function matchesScope(globs, candidates) {
- return globs.some((glob) => {
- let re;
+ const regexes = [];
+ for (const glob of globs) {
try {
- re = globToRegex(String(glob));
+ regexes.push(globToRegex(String(glob)));
} catch {
- return false;
+ // Malformed glob: skip it, as matchesAnyGlob does in the CLI.
}
- return candidates.some((candidate) => re.test(candidate));
- });
+ }
+ if (regexes.length === 0) return false;
+ const hits = (paths) => paths.some((path) => regexes.some((re) => re.test(path)));
+ // Matches on the URL path itself hold whichever root serves the page.
+ if (hits(candidates.bare)) return true;
+ // Root-prefixed matches only hold if no possible identity disagrees.
+ return candidates.rooted.length > 0 && candidates.rooted.every(hits);
}
/**
diff --git a/tests/live-browser-ignores.test.mjs b/tests/live-browser-ignores.test.mjs
index 38fa4f718..69586d86a 100644
--- a/tests/live-browser-ignores.test.mjs
+++ b/tests/live-browser-ignores.test.mjs
@@ -183,6 +183,37 @@ describe('live-browser-ignores resolver', () => {
assert.deepEqual(out.disabledRules, ['dark-glow']);
});
+ it('does not apply a waiver scoped to one root when several roots could serve the URL', () => {
+ // With src/**/*.html and public/**/*.html both configured, /foo.html
+ // could be served from either root. A waiver naming only src/foo.html
+ // must not hide a finding on a page actually served from
+ // public/foo.html; ambiguity resolves to showing the finding.
+ const ignores = {
+ roots: ['src/', 'public/'],
+ ignoreValues: [
+ { rule: 'dark-glow', value: '*', files: ['src/foo.html'] },
+ { rule: 'gradient-text', value: 'teal', files: ['src/foo.html'] },
+ ],
+ };
+ const out = resolve({ ignores, pathname: '/foo.html' });
+ assert.deepEqual(out, EMPTY);
+ });
+
+ it('applies a scoped waiver under several roots when every identity matches', () => {
+ const ignores = {
+ roots: ['src/', 'public/'],
+ ignoreValues: [
+ // Two globs covering both identities.
+ { rule: 'dark-glow', value: '*', files: ['src/foo.html', 'public/foo.html'] },
+ // A bare-path glob holds whichever root serves the page.
+ { rule: 'em-dash-overuse', value: '*', files: ['foo.html'] },
+ { rule: 'gradient-text', value: '*', files: ['**/foo.html'] },
+ ],
+ };
+ const out = resolve({ ignores, pathname: '/foo.html' });
+ assert.deepEqual(out.disabledRules.sort(), ['dark-glow', 'em-dash-overuse', 'gradient-text']);
+ });
+
it('survives malformed roots and percent-escapes without throwing', () => {
const out = resolve({
ignores: {