Skip to content

The design language that makes your AI harness better at design.

JavaScript

Brand surfaces skip local chrome and read a type logo's nested letters

Paul Bakausf85164f89616
diff --git a/crates/core/src/browser/driver.rs b/crates/core/src/browser/driver.rs
index d190523f8..ef189f0a7 100644
--- a/crates/core/src/browser/driver.rs
+++ b/crates/core/src/browser/driver.rs
@@ -844,8 +844,17 @@ fn brand_surface_colors(dom: &dyn Dom) -> Vec<crate::color::Rgba> {
if !ai_palette_is_visible(dom, el) {
continue;
}
- let logo = names_logo(dom, el);
- let bar = is_nav_bar(dom, el, &tag) && rect.width >= BRAND_BAR_MIN_WIDTH_SHARE * viewport_w;
+ // A logo or bar inside the page's content (an article's own header,
+ // a pagination nav, a row of partner logos in `main`) is local chrome,
+ // not the site's brand.
+ let local = dom
+ .parent(el)
+ .and_then(|p| super::dom::closest_or_none(dom, p, "main, article"))
+ .is_some();
+ let logo = !local && names_logo(dom, el);
+ let bar = !local
+ && is_nav_bar(dom, el, &tag)
+ && rect.width >= BRAND_BAR_MIN_WIDTH_SHARE * viewport_w;
let large = rect.width >= BRAND_BAND_MIN_WIDTH_SHARE * viewport_w
&& rect.width * rect.height >= BRAND_SURFACE_MIN_VIEWPORT_SHARE * viewport_area;
if !(logo || bar || large) {
@@ -860,8 +869,20 @@ fn brand_surface_colors(dom: &dyn Dom) -> Vec<crate::color::Rgba> {
}
}
}
- if logo && super::dom::has_direct_text_longer_than(dom, el, 0) {
- if let Some(ink) = parse_any_color(Some(&dom.style(el, "color"))) {
+ // A type logo's letters can sit in a child (`<a class=logo><span>`):
+ // its ink is the first text in the logo, wherever it is set.
+ let ink_el = if !logo {
+ None
+ } else if super::dom::has_direct_text_longer_than(dom, el, 0) {
+ Some(el)
+ } else {
+ dom.query_all(Some(el), "*")
+ .unwrap_or_default()
+ .into_iter()
+ .find(|d| super::dom::has_direct_text_longer_than(dom, *d, 0))
+ };
+ if let Some(ink_el) = ink_el {
+ if let Some(ink) = parse_any_color(Some(&dom.style(ink_el, "color"))) {
if ink.alpha_or_one() >= 0.9 && has_chroma(Some(&ink), Some(50.0)) {
out.push(ink);
}
@@ -2336,6 +2357,38 @@ mod tests {
}),
0
);
+ // The letters of a type logo set in a child span.
+ assert_eq!(
+ run(&|d, body| {
+ let logo = d.add(Some(body), "a");
+ d.set_attr(logo, "class", "site-logo");
+ d.set_rect(logo, 0.0, 0.0, 120.0, 40.0);
+ let word = d.add(Some(logo), "span");
+ d.set_rect(word, 0.0, 0.0, 120.0, 40.0);
+ d.add_text(word, "Acme");
+ d.set_style(word, "color", "rgb(124, 58, 237)");
+ }),
+ 0
+ );
+ // A partner logo in the page's content is not the site's brand, and
+ // neither is an article's own header bar.
+ assert_eq!(
+ run(&|d, body| {
+ let main = d.add(Some(body), "main");
+ d.set_rect(main, 0.0, 0.0, 1280.0, 3000.0);
+ let logo = d.add(Some(main), "a");
+ d.set_attr(logo, "class", "partner-logo");
+ d.set_rect(logo, 0.0, 1200.0, 120.0, 40.0);
+ d.add_text(logo, "Partner");
+ d.set_style(logo, "color", "rgb(124, 58, 237)");
+ let article = d.add(Some(main), "article");
+ d.set_rect(article, 0.0, 1300.0, 1280.0, 1000.0);
+ let header = d.add(Some(article), "header");
+ d.set_rect(header, 0.0, 1300.0, 1280.0, 80.0);
+ d.set_style(header, "backgroundColor", "rgb(124, 58, 237)");
+ }),
+ 1
+ );
// A footer band in the same violet.
assert_eq!(
run(&|d, body| {