Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

remove machine identity support

Andrey01a147a52503
diff --git a/backend/src/services/approval-policy/approval-policy-service.ts b/backend/src/services/approval-policy/approval-policy-service.ts
index b5d386ec49..2313e7abcf 100644
--- a/backend/src/services/approval-policy/approval-policy-service.ts
+++ b/backend/src/services/approval-policy/approval-policy-service.ts
@@ -1297,8 +1297,6 @@ export const approvalPolicyServiceFactory = ({
projectId,
ctx: {
requester: {
- userId: actor.type === ActorType.USER ? actor.id : null,
- machineIdentityId: machineIdentityId ?? null,
email: actor.type === ActorType.USER ? requesterEmail || null : null
}
}
diff --git a/backend/src/services/approval-policy/auto-approval/auto-approval-fns.test.ts b/backend/src/services/approval-policy/auto-approval/auto-approval-fns.test.ts
index 69d05550cc..1f8b02638c 100644
--- a/backend/src/services/approval-policy/auto-approval/auto-approval-fns.test.ts
+++ b/backend/src/services/approval-policy/auto-approval/auto-approval-fns.test.ts
@@ -38,7 +38,7 @@ const ticket: TAutoApprovalSubject<unknown, TFacts> = {
}
};
-const ctx: TAutoApprovalContext = { requester: { userId: "user-id", machineIdentityId: null, email: "[email protected]" } };
+const ctx: TAutoApprovalContext = { requester: { email: "[email protected]" } };
const condition = (id: string, constraint: string, values: string[], inputId: string | null = "input-1") => ({
id,
diff --git a/backend/src/services/approval-policy/auto-approval/auto-approval-types.ts b/backend/src/services/approval-policy/auto-approval/auto-approval-types.ts
index f28d1765f7..9f54f4078a 100644
--- a/backend/src/services/approval-policy/auto-approval/auto-approval-types.ts
+++ b/backend/src/services/approval-policy/auto-approval/auto-approval-types.ts
@@ -20,9 +20,6 @@ export type TAutoApprovalProviderDeps = {
export type TAutoApprovalContext = {
requester: {
- userId: string | null;
- machineIdentityId: string | null;
- // Empty for machine identities, which can never match a person in another service
email: string | null;
};
};
diff --git a/backend/src/services/approval-policy/auto-approval/providers/jira-auto-approval-provider.test.ts b/backend/src/services/approval-policy/auto-approval/providers/jira-auto-approval-provider.test.ts
index 835dcaf5b6..2d00324da2 100644
--- a/backend/src/services/approval-policy/auto-approval/providers/jira-auto-approval-provider.test.ts
+++ b/backend/src/services/approval-policy/auto-approval/providers/jira-auto-approval-provider.test.ts
@@ -12,7 +12,7 @@ import {
const conn = { credentials: { instanceUrl: "https://acme.atlassian.net" } } as Parameters<typeof parseJiraTicket>[1];
const ctx: TAutoApprovalContext = {
- requester: { userId: "user-id", machineIdentityId: null, email: "[email protected]" }
+ requester: { email: "[email protected]" }
};
const facts = (overrides: Partial<TJiraTicketFacts> = {}): TJiraTicketFacts => ({
diff --git a/backend/src/services/approval-policy/auto-approval/providers/jira-auto-approval-provider.ts b/backend/src/services/approval-policy/auto-approval/providers/jira-auto-approval-provider.ts
index 80dd10c724..22ee50b4a1 100644
--- a/backend/src/services/approval-policy/auto-approval/providers/jira-auto-approval-provider.ts
+++ b/backend/src/services/approval-policy/auto-approval/providers/jira-auto-approval-provider.ts
@@ -130,12 +130,8 @@ const matchAssigneeToRequester = (
ctx: TAutoApprovalContext
): NonNullable<TJiraTicketFacts["assignee"]> => {
const email = ctx.requester.email?.trim().toLowerCase();
- if (!email) {
- return { matchesRequester: false, reason: "Requests from machine identities can't match a Jira assignee" };
- }
-
const assigneeEmail = issue.fields?.assignee?.emailAddress?.trim().toLowerCase();
- return assigneeEmail === email
+ return email && assigneeEmail === email
? { matchesRequester: true, reason: null }
: { matchesRequester: false, reason: `${issue.key} isn't assigned to the requester` };
};
diff --git a/docs/documentation/platform/pam/access-requests/auto-approval.mdx b/docs/documentation/platform/pam/access-requests/auto-approval.mdx
index bd7043f8ae..6a4c852c30 100644
--- a/docs/documentation/platform/pam/access-requests/auto-approval.mdx
+++ b/docs/documentation/platform/pam/access-requests/auto-approval.mdx
@@ -83,7 +83,7 @@ Each condition runs one check on a linked record, and the checks available depen
| Check | Passes when |
| --- | --- |
-| **is assigned to the requester** | The ticket's assignee has the same email address in Jira as the requester has in Infisical (it never passes if the assignee hides their email address in Jira, or for a request from a [machine identity](/documentation/platform/identities/machine-identities), which has no email address) |
+| **is assigned to the requester** | The ticket's assignee has the same email address in Jira as the requester has in Infisical (it never passes if the assignee hides their email address in Jira) |
| **is approved in Jira** | The ticket is a Jira Service Management request, and its latest approval was approved |
| **has status** | The ticket's status is one of the values |
| **is in project** | The ticket is in one of the projects |