Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

improvement(ui): centralize wide sheet sizes (#8312)

Andrew Huang01ecb40d913f
diff --git a/frontend/src/components/pki-syncs/CreatePkiSyncModal.tsx b/frontend/src/components/pki-syncs/CreatePkiSyncModal.tsx
index b1af492770..3002a10044 100644
--- a/frontend/src/components/pki-syncs/CreatePkiSyncModal.tsx
+++ b/frontend/src/components/pki-syncs/CreatePkiSyncModal.tsx
@@ -66,7 +66,7 @@ export const CreatePkiSyncModal = ({
return (
<>
<Sheet open={isOpen} onOpenChange={handleSheetOpenChange}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 p-0 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="flex h-full max-h-full flex-col gap-y-0 p-0">
<SheetHeader className="border-b">
{selectedSync ? (
<>
diff --git a/frontend/src/components/pki-syncs/EditPkiSyncModal.tsx b/frontend/src/components/pki-syncs/EditPkiSyncModal.tsx
index 02865bb377..ea8d5b7226 100644
--- a/frontend/src/components/pki-syncs/EditPkiSyncModal.tsx
+++ b/frontend/src/components/pki-syncs/EditPkiSyncModal.tsx
@@ -54,7 +54,7 @@ export const EditPkiSyncModal = ({ isOpen, pkiSync, onOpenChange, initialStepKey
return (
<>
<Sheet open={isOpen} onOpenChange={handleSheetOpenChange}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<PkiSyncModalHeader isConfigured destination={pkiSync.destination} />
diff --git a/frontend/src/components/secret-rotations-v2/CreateSecretRotationV2Modal.tsx b/frontend/src/components/secret-rotations-v2/CreateSecretRotationV2Modal.tsx
index a4366d3ce2..d6be893a1f 100644
--- a/frontend/src/components/secret-rotations-v2/CreateSecretRotationV2Modal.tsx
+++ b/frontend/src/components/secret-rotations-v2/CreateSecretRotationV2Modal.tsx
@@ -128,7 +128,10 @@ export const CreateSecretRotationV2Modal = ({ onOpenChange, isOpen, ...props }:
return (
<>
<Sheet open={isOpen} onOpenChange={handleSheetOpenChange}>
- <SheetContent className="flex h-full max-h-full w-full flex-col gap-y-0 p-0 sm:w-3/4 sm:max-w-[1500px]">
+ <SheetContent
+ size="workspace"
+ className="flex h-full max-h-full w-full flex-col gap-y-0 p-0 sm:w-3/4"
+ >
<SheetHeader>
{selectedRotation ? (
<>
diff --git a/frontend/src/components/secret-rotations-v2/EditSecretRotationV2Modal.tsx b/frontend/src/components/secret-rotations-v2/EditSecretRotationV2Modal.tsx
index f8a055f127..5ca1ab14d8 100644
--- a/frontend/src/components/secret-rotations-v2/EditSecretRotationV2Modal.tsx
+++ b/frontend/src/components/secret-rotations-v2/EditSecretRotationV2Modal.tsx
@@ -43,7 +43,10 @@ export const EditSecretRotationV2Modal = ({ secretRotation, isOpen, onOpenChange
return (
<>
<Sheet open={isOpen} onOpenChange={handleSheetOpenChange}>
- <SheetContent className="flex h-full max-h-full w-full flex-col gap-y-0 p-0 sm:w-3/4 sm:max-w-[1500px]">
+ <SheetContent
+ size="workspace"
+ className="flex h-full max-h-full w-full flex-col gap-y-0 p-0 sm:w-3/4"
+ >
<SheetHeader>
<SheetTitle className="sr-only">Edit secret rotation</SheetTitle>
<SecretRotationV2ModalHeader isConfigured type={secretRotation.type} />
diff --git a/frontend/src/components/secret-syncs/CreateSecretSyncModal.tsx b/frontend/src/components/secret-syncs/CreateSecretSyncModal.tsx
index b137649979..dddfb3c92a 100644
--- a/frontend/src/components/secret-syncs/CreateSecretSyncModal.tsx
+++ b/frontend/src/components/secret-syncs/CreateSecretSyncModal.tsx
@@ -96,7 +96,7 @@ export const CreateSecretSyncModal = ({
return (
<>
<Sheet open={isOpen} onOpenChange={handleSheetOpenChange}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
{selectedSync ? (
<>
diff --git a/frontend/src/components/secret-syncs/EditSecretSyncModal.tsx b/frontend/src/components/secret-syncs/EditSecretSyncModal.tsx
index cf9f099a53..cbbbbf24b6 100644
--- a/frontend/src/components/secret-syncs/EditSecretSyncModal.tsx
+++ b/frontend/src/components/secret-syncs/EditSecretSyncModal.tsx
@@ -43,7 +43,7 @@ export const EditSecretSyncModal = ({ isOpen, secretSync, onOpenChange }: Props)
return (
<>
<Sheet open={isOpen} onOpenChange={handleSheetOpenChange}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle className="sr-only">Edit secret sync</SheetTitle>
<SecretSyncModalHeader
diff --git a/frontend/src/components/v3/generic/Sheet/Sheet.stories.tsx b/frontend/src/components/v3/generic/Sheet/Sheet.stories.tsx
index 25696557ab..2da7ff624f 100644
--- a/frontend/src/components/v3/generic/Sheet/Sheet.stories.tsx
+++ b/frontend/src/components/v3/generic/Sheet/Sheet.stories.tsx
@@ -1,6 +1,7 @@
import type { Meta, StoryObj } from "@storybook/react-vite";
import { Button } from "../Button";
+import { Field, FieldGroup, FieldLabel } from "../Field";
import { Input } from "../Input";
import { Label } from "../Label";
import {
@@ -50,7 +51,7 @@ export const Default: Story = {
docs: {
description: {
story:
- "The baseline slide-over — `side` defaults to `right`, the most common placement for detail panes and edit flows. Wrap the footer's Cancel button in `SheetClose` so it dismisses the sheet without managing state. `SheetContent` defaults to a responsive width (`w-3/4` with `sm:max-w-md`); override via `className` when you need more or less room."
+ 'The baseline slide-over — `side` defaults to `right`, the most common placement for detail panes and edit flows. Wrap the footer\'s Cancel button in `SheetClose` so it dismisses the sheet without managing state. `SheetContent` defaults to a responsive width (`w-3/4` with `sm:max-w-md`). Use `size="form"` for a full-width mobile form capped at 3xl, `size="wide"` for 1100px workflows, or `size="workspace"` for 1500px multi-column workspaces.'
}
}
},
@@ -83,6 +84,68 @@ export const Default: Story = {
)
};
+export const FormWidth: Story = {
+ name: "Example: Form Width",
+ render: () => (
+ <Sheet>
+ <SheetTrigger asChild>
+ <Button variant="outline">Create dynamic secret</Button>
+ </SheetTrigger>
+ <SheetContent size="form">
+ <SheetHeader>
+ <SheetTitle>Create Dynamic Secret</SheetTitle>
+ <SheetDescription>
+ Configure the provider and credentials for this secret.
+ </SheetDescription>
+ </SheetHeader>
+ <FieldGroup className="p-4">
+ <Field>
+ <FieldLabel htmlFor="dynamic-secret-name">Name</FieldLabel>
+ <Input id="dynamic-secret-name" placeholder="database-credentials" />
+ </Field>
+ <Field>
+ <FieldLabel htmlFor="dynamic-secret-path">Secret Path</FieldLabel>
+ <Input id="dynamic-secret-path" placeholder="/production" />
+ </Field>
+ </FieldGroup>
+ <SheetFooter>
+ <Button>Create Dynamic Secret</Button>
+ </SheetFooter>
+ </SheetContent>
+ </Sheet>
+ )
+};
+
+export const WorkspaceWidth: Story = {
+ name: "Example: Workspace Width",
+ render: () => (
+ <Sheet>
+ <SheetTrigger asChild>
+ <Button variant="outline">Create secret sync</Button>
+ </SheetTrigger>
+ <SheetContent size="workspace">
+ <SheetHeader>
+ <SheetTitle>Create Secret Sync</SheetTitle>
+ <SheetDescription>Choose a source and destination for these secrets.</SheetDescription>
+ </SheetHeader>
+ <div className="grid gap-4 p-4 sm:grid-cols-2">
+ <Field>
+ <FieldLabel htmlFor="sync-source">Source</FieldLabel>
+ <Input id="sync-source" placeholder="Production" />
+ </Field>
+ <Field>
+ <FieldLabel htmlFor="sync-destination">Destination</FieldLabel>
+ <Input id="sync-destination" placeholder="AWS Secrets Manager" />
+ </Field>
+ </div>
+ <SheetFooter>
+ <Button>Create Secret Sync</Button>
+ </SheetFooter>
+ </SheetContent>
+ </Sheet>
+ )
+};
+
export const LeftSide: Story = {
name: "Example: Left Side",
parameters: {
diff --git a/frontend/src/components/v3/generic/Sheet/Sheet.tsx b/frontend/src/components/v3/generic/Sheet/Sheet.tsx
index bfd24e9863..97d35d9318 100644
--- a/frontend/src/components/v3/generic/Sheet/Sheet.tsx
+++ b/frontend/src/components/v3/generic/Sheet/Sheet.tsx
@@ -49,11 +49,13 @@ function SheetContent({
className,
children,
side = "right",
+ size,
onPointerDownOutside,
onInteractOutside,
...props
}: React.ComponentProps<typeof SheetPrimitive.Content> & {
side?: "top" | "right" | "bottom" | "left";
+ size?: "form" | "wide" | "workspace";
}) {
return (
<SheetPortal>
@@ -84,6 +86,9 @@ function SheetContent({
"inset-x-0 top-0 h-auto border-b data-[state=closed]:slide-out-to-top-full data-[state=open]:slide-in-from-top-2",
side === "bottom" &&
"inset-x-0 bottom-0 h-auto border-t data-[state=closed]:slide-out-to-bottom-full data-[state=open]:slide-in-from-bottom-2",
+ (side === "right" || side === "left") && size === "form" && "w-full sm:max-w-3xl",
+ (side === "right" || side === "left") && size === "wide" && "sm:max-w-[1100px]",
+ (side === "right" || side === "left") && size === "workspace" && "sm:max-w-[1500px]",
className
)}
{...props}
diff --git a/frontend/src/pages/cert-manager/CertificateAuthoritiesPage/components/CreateCaWizard/CreateCaWizard.tsx b/frontend/src/pages/cert-manager/CertificateAuthoritiesPage/components/CreateCaWizard/CreateCaWizard.tsx
index 1dd8f9f02c..66d1eda226 100644
--- a/frontend/src/pages/cert-manager/CertificateAuthoritiesPage/components/CreateCaWizard/CreateCaWizard.tsx
+++ b/frontend/src/pages/cert-manager/CertificateAuthoritiesPage/components/CreateCaWizard/CreateCaWizard.tsx
@@ -156,7 +156,7 @@ export const CreateCaWizard = ({ isOpen, onOpenChange }: Props) => {
return (
<Sheet open={isOpen} onOpenChange={handleClose}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<div className="flex w-full items-start gap-2">
diff --git a/frontend/src/pages/cert-manager/CertificatesPage/components/CertificateWizardSheet.tsx b/frontend/src/pages/cert-manager/CertificatesPage/components/CertificateWizardSheet.tsx
index 5b77ed807b..2442216844 100644
--- a/frontend/src/pages/cert-manager/CertificatesPage/components/CertificateWizardSheet.tsx
+++ b/frontend/src/pages/cert-manager/CertificatesPage/components/CertificateWizardSheet.tsx
@@ -79,7 +79,7 @@ export const CertificateWizardSheet = ({
return (
<Sheet open={isOpen} onOpenChange={onOpenChange}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 p-0 sm:max-w-[1100px]">
+ <SheetContent size="wide" className="flex h-full max-h-full flex-col gap-y-0 p-0">
<SheetHeader className="border-b border-border">
<div className="flex w-full items-start gap-2">
<div className="flex h-10 w-10 items-center justify-center rounded-md bg-project/10 text-project">
diff --git a/frontend/src/pages/cert-manager/CodeSigningPage/components/CreateSignerWizard/CreateSignerWizard.tsx b/frontend/src/pages/cert-manager/CodeSigningPage/components/CreateSignerWizard/CreateSignerWizard.tsx
index e54b9b2211..16988b2681 100644
--- a/frontend/src/pages/cert-manager/CodeSigningPage/components/CreateSignerWizard/CreateSignerWizard.tsx
+++ b/frontend/src/pages/cert-manager/CodeSigningPage/components/CreateSignerWizard/CreateSignerWizard.tsx
@@ -352,7 +352,7 @@ export const CreateSignerWizard = ({ isOpen, onOpenChange, projectId }: Props) =
return (
<Sheet open={isOpen} onOpenChange={handleClose}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<div className="flex w-full items-start gap-2">
diff --git a/frontend/src/pages/cert-manager/SettingsPage/components/HsmConnectorsTab/CreateHsmConnectorWizard/CreateHsmConnectorWizard.tsx b/frontend/src/pages/cert-manager/SettingsPage/components/HsmConnectorsTab/CreateHsmConnectorWizard/CreateHsmConnectorWizard.tsx
index 717d9f9474..de07281a43 100644
--- a/frontend/src/pages/cert-manager/SettingsPage/components/HsmConnectorsTab/CreateHsmConnectorWizard/CreateHsmConnectorWizard.tsx
+++ b/frontend/src/pages/cert-manager/SettingsPage/components/HsmConnectorsTab/CreateHsmConnectorWizard/CreateHsmConnectorWizard.tsx
@@ -166,7 +166,7 @@ export const CreateHsmConnectorWizard = ({ isOpen, onOpenChange }: Props) => {
return (
<Sheet open={isOpen} onOpenChange={handleClose}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<div className="flex w-full items-start gap-2">
diff --git a/frontend/src/pages/cert-manager/SettingsPage/components/HsmConnectorsTab/EditHsmConnectorSheet.tsx b/frontend/src/pages/cert-manager/SettingsPage/components/HsmConnectorsTab/EditHsmConnectorSheet.tsx
index 804276a284..28edf60258 100644
--- a/frontend/src/pages/cert-manager/SettingsPage/components/HsmConnectorsTab/EditHsmConnectorSheet.tsx
+++ b/frontend/src/pages/cert-manager/SettingsPage/components/HsmConnectorsTab/EditHsmConnectorSheet.tsx
@@ -166,7 +166,7 @@ export const EditHsmConnectorSheet = ({ connector, onClose }: Props) => {
return (
<Sheet open={isOpen} onOpenChange={(open) => !open && onClose()}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1100px]">
+ <SheetContent size="wide" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<div className="flex w-full items-start gap-2">
diff --git a/frontend/src/pages/cert-manager/SignerDetailPage/components/EditSignerModal/EditSignerModal.tsx b/frontend/src/pages/cert-manager/SignerDetailPage/components/EditSignerModal/EditSignerModal.tsx
index 7b3307fb24..0016ee71de 100644
--- a/frontend/src/pages/cert-manager/SignerDetailPage/components/EditSignerModal/EditSignerModal.tsx
+++ b/frontend/src/pages/cert-manager/SignerDetailPage/components/EditSignerModal/EditSignerModal.tsx
@@ -298,7 +298,7 @@ export const EditSignerModal = ({ isOpen, onOpenChange, signer }: Props) => {
return (
<Sheet open={isOpen} onOpenChange={handleOpenChange}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1100px]">
+ <SheetContent size="wide" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<div className="flex w-full items-start gap-2">
diff --git a/frontend/src/pages/cert-manager/SignerDetailPage/components/EditSignerPolicyModal/EditSignerPolicyModal.tsx b/frontend/src/pages/cert-manager/SignerDetailPage/components/EditSignerPolicyModal/EditSignerPolicyModal.tsx
index a79944c8e6..0f7d783c2b 100644
--- a/frontend/src/pages/cert-manager/SignerDetailPage/components/EditSignerPolicyModal/EditSignerPolicyModal.tsx
+++ b/frontend/src/pages/cert-manager/SignerDetailPage/components/EditSignerPolicyModal/EditSignerPolicyModal.tsx
@@ -227,7 +227,7 @@ export const EditSignerPolicyModal = ({
return (
<Sheet open={isOpen} onOpenChange={handleClose}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<div className="flex w-full items-start gap-2">
diff --git a/frontend/src/pages/cert-manager/SignerDetailPage/components/PreApproveSigningSheet.tsx b/frontend/src/pages/cert-manager/SignerDetailPage/components/PreApproveSigningSheet.tsx
index ad3bdfafce..2d51fd6a04 100644
--- a/frontend/src/pages/cert-manager/SignerDetailPage/components/PreApproveSigningSheet.tsx
+++ b/frontend/src/pages/cert-manager/SignerDetailPage/components/PreApproveSigningSheet.tsx
@@ -153,7 +153,7 @@ export const PreApproveSigningSheet = ({ isOpen, onOpenChange, signerId }: Props
return (
<Sheet open={isOpen} onOpenChange={handleClose}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1100px]">
+ <SheetContent size="wide" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<div className="flex w-full items-start gap-2">
diff --git a/frontend/src/pages/cert-manager/SignerDetailPage/components/RequestToSignSheet.tsx b/frontend/src/pages/cert-manager/SignerDetailPage/components/RequestToSignSheet.tsx
index 64060b8526..df93a1fd38 100644
--- a/frontend/src/pages/cert-manager/SignerDetailPage/components/RequestToSignSheet.tsx
+++ b/frontend/src/pages/cert-manager/SignerDetailPage/components/RequestToSignSheet.tsx
@@ -115,7 +115,7 @@ export const RequestToSignSheet = ({ isOpen, onOpenChange, signerId }: Props) =>
return (
<Sheet open={isOpen} onOpenChange={handleClose}>
- <SheetContent className="flex h-full max-h-full flex-col gap-y-0 sm:max-w-[1100px]">
+ <SheetContent size="wide" className="flex h-full max-h-full flex-col gap-y-0">
<SheetHeader className="border-b">
<SheetTitle>
<div className="flex w-full items-start gap-2">
diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/CopySecretsSheet/CopySecretsSheet.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/CopySecretsSheet/CopySecretsSheet.tsx
index 7e37243503..d52c4d4bdc 100644
--- a/frontend/src/pages/secret-manager/OverviewPage/components/CopySecretsSheet/CopySecretsSheet.tsx
+++ b/frontend/src/pages/secret-manager/OverviewPage/components/CopySecretsSheet/CopySecretsSheet.tsx
@@ -574,7 +574,7 @@ const CopySecretsSession = ({
return (
<>
<Sheet open={isOpen} onOpenChange={(open) => !isSubmitting && onOpenChange(open)}>
- <SheetContent className="w-full sm:w-3/4 sm:max-w-[1500px]">
+ <SheetContent size="workspace" className="w-full sm:w-3/4">
<form
className="flex min-h-0 flex-1 flex-col"
onSubmit={(event) => event.preventDefault()}
diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/CreateDynamicSecretForm/CreateDynamicSecretForm.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/CreateDynamicSecretForm/CreateDynamicSecretForm.tsx
index 632fa005e4..ee715f9f0b 100644
--- a/frontend/src/pages/secret-manager/OverviewPage/components/CreateDynamicSecretForm/CreateDynamicSecretForm.tsx
+++ b/frontend/src/pages/secret-manager/OverviewPage/components/CreateDynamicSecretForm/CreateDynamicSecretForm.tsx
@@ -128,7 +128,7 @@ export const CreateDynamicSecretForm = ({
return (
<>
<Sheet open={isOpen} onOpenChange={(open) => !open && requestClose()}>
- <SheetContent className="flex h-full max-h-full w-full flex-col gap-y-0 p-0 sm:w-3/4 sm:max-w-[1500px]">
+ <SheetContent size="form" className="flex h-full max-h-full flex-col gap-y-0 p-0">
{content}
</SheetContent>
</Sheet>
diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/EditDynamicSecretForm/EditDynamicSecretForm.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/EditDynamicSecretForm/EditDynamicSecretForm.tsx
index 5542e68724..866ce5050c 100644
--- a/frontend/src/pages/secret-manager/OverviewPage/components/EditDynamicSecretForm/EditDynamicSecretForm.tsx
+++ b/frontend/src/pages/secret-manager/OverviewPage/components/EditDynamicSecretForm/EditDynamicSecretForm.tsx
@@ -82,7 +82,7 @@ export const EditDynamicSecretForm = ({
return (
<>
<Sheet open={isOpen} onOpenChange={(open) => !open && requestDiscard()}>
- <SheetContent className="w-full sm:max-w-3xl">
+ <SheetContent size="form">
<SheetHeader>
<SheetTitle>Edit Dynamic Secret</SheetTitle>
<SheetDescription>Update dynamic secret parameters.</SheetDescription>