Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
improvement(frontend): focus dominant search inputs with the / hotkey (#8069)
claude[bot]0c01d1faeb8f
diff --git a/frontend/src/hooks/index.ts b/frontend/src/hooks/index.tsindex 14e8f9b1dd..fd2055b0ff 100644--- a/frontend/src/hooks/index.ts+++ b/frontend/src/hooks/index.ts@@ -17,6 +17,7 @@ export { useResetPageHelper } from "./useResetPageHelper";export * from "./useResizableHeaderHeight";export { useScopeVariant } from "./useScopeVariant";export { useSecretsActivationNudge } from "./useSecretsActivationNudge";+export { useSlashFocusSearch } from "./useSlashFocusSearch";export { useSyntaxHighlight } from "./useSyntaxHighlight";export { useTimedReset } from "./useTimedReset";export { useTimeRemaining } from "./useTimeRemaining";diff --git a/frontend/src/hooks/useSlashFocusSearch.ts b/frontend/src/hooks/useSlashFocusSearch.tsnew file mode 100644index 0000000000..84b828f961--- /dev/null+++ b/frontend/src/hooks/useSlashFocusSearch.ts@@ -0,0 +1,52 @@+import { RefObject, useEffect } from "react";++const EDITABLE_SELECTOR = [+ "input",+ "textarea",+ "select",+ '[contenteditable]:not([contenteditable="false"])',+ '[role="dialog"]',+ '[role="alertdialog"]',+ '[role="combobox"]',+ '[role="listbox"]',+ '[role="menu"]',+ "[cmdk-root]",+ ".cm-editor",+ ".monaco-editor",+ ".xterm"+].join(", ");++const OPEN_OVERLAY_SELECTOR = '[role="dialog"], [role="alertdialog"], [cmdk-root]';++const isEditable = (element: EventTarget | Element | null) =>+ element instanceof Element && Boolean(element.closest(EDITABLE_SELECTOR));++export const useSlashFocusSearch = (ref: RefObject<HTMLInputElement | null>) => {+ useEffect(() => {+ const handleKeyDown = (event: KeyboardEvent) => {+ if (+ event.key !== "/" ||+ event.repeat ||+ event.defaultPrevented ||+ event.metaKey ||+ event.ctrlKey ||+ event.altKey+ ) {+ return;+ }++ if (isEditable(event.target) || isEditable(document.activeElement)) return;+ if (document.querySelector(OPEN_OVERLAY_SELECTOR)) return;++ const input = ref.current;+ if (!input || !input.isConnected || input.disabled || input.readOnly) return;++ event.preventDefault();+ input.focus();+ input.select();+ };++ document.addEventListener("keydown", handleKeyDown);+ return () => document.removeEventListener("keydown", handleKeyDown);+ }, [ref]);+};diff --git a/frontend/src/pages/cert-manager/CertificatesPage/components/CertificatesTable.tsx b/frontend/src/pages/cert-manager/CertificatesPage/components/CertificatesTable.tsxindex 21c402b008..ed1146a0f6 100644--- a/frontend/src/pages/cert-manager/CertificatesPage/components/CertificatesTable.tsx+++ b/frontend/src/pages/cert-manager/CertificatesPage/components/CertificatesTable.tsx@@ -1,5 +1,5 @@/* eslint-disable no-nested-ternary */-import { useCallback, useEffect, useMemo, useState } from "react";+import { useCallback, useEffect, useMemo, useRef, useState } from "react";import { subject } from "@casl/ability";import { useNavigate } from "@tanstack/react-router";import { format } from "date-fns";@@ -65,6 +65,7 @@ import {useProjectPermission,useUser} from "@app/context";+import { useSlashFocusSearch } from "@app/hooks";import { useUpdateRenewalConfig } from "@app/hooks/api";import { caSupportsCapability } from "@app/hooks/api/ca/constants";import { CaCapability, CaType } from "@app/hooks/api/ca/enums";@@ -185,6 +186,8 @@ export const CertificatesTable = ({const [page, setPage] = useState(1);const [perPage, setPerPage] = useState(PER_PAGE_INIT);const [search, setSearch] = useState(externalFilter?.search || "");+ const searchInputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(searchInputRef);const [appliedSearch, setAppliedSearch] = useState(externalFilter?.search || "");const { data: appPermissionData } = useGetPkiApplicationPermissions(applicationId ?? "");@@ -734,6 +737,7 @@ export const CertificatesTable = ({<InputGroupInputvalue={search}onChange={(e) => setSearch(e.target.value)}+ ref={searchInputRef}placeholder="Search by SAN, CN, ID or Serial Number"/></InputGroup>diff --git a/frontend/src/pages/cert-manager/IntegrationsListPage/components/PkiSyncsTab/PkiSyncTable/PkiSyncsTable.tsx b/frontend/src/pages/cert-manager/IntegrationsListPage/components/PkiSyncsTab/PkiSyncTable/PkiSyncsTable.tsxindex e55bf45ac7..0592d1beae 100644--- a/frontend/src/pages/cert-manager/IntegrationsListPage/components/PkiSyncsTab/PkiSyncTable/PkiSyncsTable.tsx+++ b/frontend/src/pages/cert-manager/IntegrationsListPage/components/PkiSyncsTab/PkiSyncTable/PkiSyncsTable.tsx@@ -1,4 +1,4 @@-import { useMemo, useState } from "react";+import { useMemo, useRef, useState } from "react";import {CheckCircle2Icon,ChevronDownIcon,@@ -42,7 +42,7 @@ import {PreferenceKey,setUserTablePreference} from "@app/helpers/userTablePreferences";-import { usePagination, usePopUp, useResetPageHelper } from "@app/hooks";+import { usePagination, usePopUp, useResetPageHelper, useSlashFocusSearch } from "@app/hooks";import { OrderByDirection } from "@app/hooks/api/generic/types";import {PkiSync,@@ -122,6 +122,8 @@ export const PkiSyncsTable = ({ pkiSyncs, applicationName }: Props) => {} = usePagination<PkiSyncsOrderBy>(PkiSyncsOrderBy.Name, {initPerPage: getUserTablePreference("pkiSyncTable", PreferenceKey.PerPage, 20)});+ const searchInputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(searchInputRef);const handlePerPageChange = (newPerPage: number) => {setPerPage(newPerPage);@@ -260,6 +262,7 @@ export const PkiSyncsTable = ({ pkiSyncs, applicationName }: Props) => {<InputGroupInputvalue={search}onChange={(e) => setSearch(e.target.value)}+ ref={searchInputRef}placeholder="Search certificate syncs..."/></InputGroup>diff --git a/frontend/src/pages/kms/OverviewPage/components/CmekTable.tsx b/frontend/src/pages/kms/OverviewPage/components/CmekTable.tsxindex 1dca2456ca..c42ad6bcc6 100644--- a/frontend/src/pages/kms/OverviewPage/components/CmekTable.tsx+++ b/frontend/src/pages/kms/OverviewPage/components/CmekTable.tsx@@ -1,4 +1,4 @@-import { useEffect, useState } from "react";+import { useEffect, useRef, useState } from "react";import {CheckIcon,ChevronDownIcon,@@ -75,7 +75,13 @@ import {PreferenceKey,setUserTablePreference} from "@app/helpers/userTablePreferences";-import { usePagination, usePopUp, useResetPageHelper, useTimedReset } from "@app/hooks";+import {+ usePagination,+ usePopUp,+ useResetPageHelper,+ useSlashFocusSearch,+ useTimedReset+} from "@app/hooks";import {useBulkExportCmekPrivateKeys,useGetCmeksByProjectId,@@ -133,6 +139,8 @@ export const CmekTable = () => {} = usePagination(CmekOrderBy.Name, {initPerPage: getUserTablePreference("cmekClientTable", PreferenceKey.PerPage, 20)});+ const searchInputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(searchInputRef);const handlePerPageChange = (newPerPage: number) => {setPerPage(newPerPage);@@ -385,6 +393,7 @@ export const CmekTable = () => {onChange={(e) => {setSearch(e.target.value);}}+ ref={searchInputRef}placeholder="Search keys by name or ID..."/></InputGroup>diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsxindex cdd923d080..815f00fc35 100644--- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsx+++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsx@@ -1,4 +1,4 @@-import { useEffect, useMemo, useState } from "react";+import { useEffect, useMemo, useRef, useState } from "react";import { useNavigate, useSearch } from "@tanstack/react-router";import { ChevronDownIcon, FilterIcon, PlusIcon, SearchIcon } from "lucide-react";import { twMerge } from "tailwind-merge";@@ -48,7 +48,13 @@ import {PreferenceKey,setUserTablePreference} from "@app/helpers/userTablePreferences";-import { usePagination, usePopUp, useResetPageHelper, useScopeVariant } from "@app/hooks";+import {+ usePagination,+ usePopUp,+ useResetPageHelper,+ useScopeVariant,+ useSlashFocusSearch+} from "@app/hooks";import {TAppConnection,useListAppConnections,@@ -148,6 +154,8 @@ export const AppConnectionsTable = ({ projectId, projectType }: Props) => {} = usePagination<AppConnectionsOrderBy>(AppConnectionsOrderBy.App, {initPerPage: getUserTablePreference("appConnectionsTable", PreferenceKey.PerPage, 20)});+ const searchInputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(searchInputRef);const handlePerPageChange = (newPerPage: number) => {setPerPage(newPerPage);@@ -347,6 +355,7 @@ export const AppConnectionsTable = ({ projectId, projectType }: Props) => {<SearchIcon /></InputGroupAddon><InputGroupInput+ ref={searchInputRef}placeholder="Search connections..."value={search}onChange={(e) => setSearch(e.target.value)}diff --git a/frontend/src/pages/organization/ProjectsPage/ProjectTypePage/ProjectTypePage.tsx b/frontend/src/pages/organization/ProjectsPage/ProjectTypePage/ProjectTypePage.tsxindex 64dee37f51..8c4bba21ad 100644--- a/frontend/src/pages/organization/ProjectsPage/ProjectTypePage/ProjectTypePage.tsx+++ b/frontend/src/pages/organization/ProjectsPage/ProjectTypePage/ProjectTypePage.tsx@@ -1,5 +1,5 @@/* eslint-disable @typescript-eslint/no-use-before-define */-import { ReactNode, useEffect, useMemo, useState } from "react";+import { ReactNode, useEffect, useMemo, useRef, useState } from "react";import { Helmet } from "react-helmet";import { Link, useNavigate, useParams } from "@tanstack/react-router";import { format } from "date-fns";@@ -79,7 +79,13 @@ import {PreferenceKey,setUserTablePreference} from "@app/helpers/userTablePreferences";-import { useDebounce, usePagination, usePopUp, useResetPageHelper } from "@app/hooks";+import {+ useDebounce,+ usePagination,+ usePopUp,+ useResetPageHelper,+ useSlashFocusSearch+} from "@app/hooks";import {useGetMyPendingProjectAccessRequests,useGetUserProjects,@@ -998,99 +1004,105 @@ const Toolbar = ({onUpgradePlan: () => void;isAddingProjectsAllowed: boolean;isGridDisabled?: boolean;-}) => (- <div className="flex w-full flex-row flex-wrap items-center gap-2 md:flex-nowrap">- {!hideProjectListToggle && (- <ProjectListToggle value={projectListView} onChange={onProjectListViewChange} />- )}- <InputGroup className="flex-1">- <InputGroupAddon align="inline-start">- <SearchIcon />- </InputGroupAddon>- <InputGroupInput- placeholder="Search by project name..."- value={searchFilter}- onChange={(e) => onSearchChange(e.target.value)}- />- </InputGroup>- <Tooltip>- <TooltipTrigger asChild>+}) => {+ const searchInputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(searchInputRef);++ return (+ <div className="flex w-full flex-row flex-wrap items-center gap-2 md:flex-nowrap">+ {!hideProjectListToggle && (+ <ProjectListToggle value={projectListView} onChange={onProjectListViewChange} />+ )}+ <InputGroup className="flex-1">+ <InputGroupAddon align="inline-start">+ <SearchIcon />+ </InputGroupAddon>+ <InputGroupInput+ ref={searchInputRef}+ placeholder="Search by project name..."+ value={searchFilter}+ onChange={(e) => onSearchChange(e.target.value)}+ />+ </InputGroup>+ <Tooltip>+ <TooltipTrigger asChild>+ <IconButton+ variant="outline"+ size="sm"+ aria-label={`Sort ${+ orderDirection === OrderByDirection.ASC ? "descending" : "ascending"+ }`}+ onClick={onToggleOrderDirection}+ >+ {orderDirection === OrderByDirection.ASC ? <ArrowDownAZIcon /> : <ArrowUpAZIcon />}+ </IconButton>+ </TooltipTrigger>+ <TooltipContent>Toggle Sort Direction</TooltipContent>+ </Tooltip>+ <ButtonGroup>+ {isGridDisabled ? (+ <Tooltip>+ <TooltipTrigger tabIndex={-1} asChild>+ <span className="cursor-not-allowed">+ <IconButton+ variant="outline"+ size="sm"+ aria-label="Grid view"+ className="rounded-r-none"+ isDisabled+ >+ <LayoutGridIcon />+ </IconButton>+ </span>+ </TooltipTrigger>+ <TooltipContent>Disabled across All Project view.</TooltipContent>+ </Tooltip>+ ) : (+ <IconButton+ variant={projectsViewMode === ProjectsViewMode.GRID ? "project" : "outline"}+ size="sm"+ aria-label="Grid view"+ className={projectsViewMode === ProjectsViewMode.GRID ? "z-10" : ""}+ onClick={() => onViewModeChange(ProjectsViewMode.GRID)}+ >+ <LayoutGridIcon />+ </IconButton>+ )}<IconButton- variant="outline"+ variant={projectsViewMode === ProjectsViewMode.LIST ? "project" : "outline"}size="sm"- aria-label={`Sort ${- orderDirection === OrderByDirection.ASC ? "descending" : "ascending"- }`}- onClick={onToggleOrderDirection}+ aria-label="List view"+ onClick={() => onViewModeChange(ProjectsViewMode.LIST)}>- {orderDirection === OrderByDirection.ASC ? <ArrowDownAZIcon /> : <ArrowUpAZIcon />}+ <ListIcon /></IconButton>- </TooltipTrigger>- <TooltipContent>Toggle Sort Direction</TooltipContent>- </Tooltip>- <ButtonGroup>- {isGridDisabled ? (- <Tooltip>- <TooltipTrigger tabIndex={-1} asChild>- <span className="cursor-not-allowed">- <IconButton- variant="outline"+ </ButtonGroup>+ <OrgPermissionCan I={OrgPermissionActions.Create} an={OrgPermissionSubjects.Workspace}>+ {(isOldProjectV1Allowed) => (+ <OrgPermissionCan I={OrgPermissionActions.Create} an={OrgPermissionSubjects.Project}>+ {(isAllowed) => (+ <Button+ isDisabled={!isAllowed && !isOldProjectV1Allowed}size="sm"- aria-label="Grid view"- className="rounded-r-none"- isDisabled+ variant="project"+ onClick={() => {+ if (isAddingProjectsAllowed) {+ onAddNewProject();+ } else {+ onUpgradePlan();+ }+ }}>- <LayoutGridIcon />- </IconButton>- </span>- </TooltipTrigger>- <TooltipContent>Disabled across All Project view.</TooltipContent>- </Tooltip>- ) : (- <IconButton- variant={projectsViewMode === ProjectsViewMode.GRID ? "project" : "outline"}- size="sm"- aria-label="Grid view"- className={projectsViewMode === ProjectsViewMode.GRID ? "z-10" : ""}- onClick={() => onViewModeChange(ProjectsViewMode.GRID)}- >- <LayoutGridIcon />- </IconButton>- )}- <IconButton- variant={projectsViewMode === ProjectsViewMode.LIST ? "project" : "outline"}- size="sm"- aria-label="List view"- onClick={() => onViewModeChange(ProjectsViewMode.LIST)}- >- <ListIcon />- </IconButton>- </ButtonGroup>- <OrgPermissionCan I={OrgPermissionActions.Create} an={OrgPermissionSubjects.Workspace}>- {(isOldProjectV1Allowed) => (- <OrgPermissionCan I={OrgPermissionActions.Create} an={OrgPermissionSubjects.Project}>- {(isAllowed) => (- <Button- isDisabled={!isAllowed && !isOldProjectV1Allowed}- size="sm"- variant="project"- onClick={() => {- if (isAddingProjectsAllowed) {- onAddNewProject();- } else {- onUpgradePlan();- }- }}- >- <PlusIcon />- Add New Project- </Button>- )}- </OrgPermissionCan>- )}- </OrgPermissionCan>- </div>-);+ <PlusIcon />+ Add New Project+ </Button>+ )}+ </OrgPermissionCan>+ )}+ </OrgPermissionCan>+ </div>+ );+};const EmptyState = ({projectType,diff --git a/frontend/src/pages/pam/PamAccountsPage/PamAccountsPage.tsx b/frontend/src/pages/pam/PamAccountsPage/PamAccountsPage.tsxindex c6e0decae5..0e4192da2d 100644--- a/frontend/src/pages/pam/PamAccountsPage/PamAccountsPage.tsx+++ b/frontend/src/pages/pam/PamAccountsPage/PamAccountsPage.tsx@@ -1,4 +1,4 @@-import { useMemo, useState } from "react";+import { useMemo, useRef, useState } from "react";import { Helmet } from "react-helmet";import { useTranslation } from "react-i18next";import { useNavigate } from "@tanstack/react-router";@@ -56,6 +56,7 @@ import { ProjectType } from "@app/hooks/api/projects/types";import { useDebounce } from "@app/hooks/useDebounce";import { usePamSheetState } from "@app/hooks/usePamSheetState";import { usePopUp } from "@app/hooks/usePopUp";+import { useSlashFocusSearch } from "@app/hooks/useSlashFocusSearch";import { LaunchSessionSheet } from "../components/LaunchSessionSheet";import { RequestAccessSheet } from "../components/RequestAccessSheet";@@ -77,6 +78,8 @@ export const PamAccountsPage = () => {const navigate = useNavigate();const { currentOrg } = useOrganization();const [searchInput, setSearchInput] = useState("");+ const searchInputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(searchInputRef);// Every role sees the same folder/account structure; permissions only disable actions on a row,// never hide it. Capabilities just drive the create affordances and the empty-state copy.@@ -229,6 +232,7 @@ export const PamAccountsPage = () => {<Search /></InputGroupAddon><InputGroupInput+ ref={searchInputRef}placeholder="Search accounts..."value={searchInput}onChange={(e) => setSearchInput(e.target.value)}diff --git a/frontend/src/pages/pam/PamAccountsPage/PamFolderPage/PamFolderPage.tsx b/frontend/src/pages/pam/PamAccountsPage/PamFolderPage/PamFolderPage.tsxindex f3ad1d0bf7..6cd708367d 100644--- a/frontend/src/pages/pam/PamAccountsPage/PamFolderPage/PamFolderPage.tsx+++ b/frontend/src/pages/pam/PamAccountsPage/PamFolderPage/PamFolderPage.tsx@@ -1,4 +1,4 @@-import { useState } from "react";+import { useRef, useState } from "react";import { Helmet } from "react-helmet";import { useTranslation } from "react-i18next";import { Link, useNavigate, useParams } from "@tanstack/react-router";@@ -59,6 +59,7 @@ import { ProjectType } from "@app/hooks/api/projects/types";import { useDebounce } from "@app/hooks/useDebounce";import { PamSheetTab, usePamSheetState } from "@app/hooks/usePamSheetState";import { usePopUp } from "@app/hooks/usePopUp";+import { useSlashFocusSearch } from "@app/hooks/useSlashFocusSearch";import { LaunchSessionSheet } from "../../components/LaunchSessionSheet";import { PAM_FOLDER_TABS } from "../../components/pamResourceTabs";@@ -81,6 +82,8 @@ export const PamFolderPage = () => {const navigate = useNavigate();const [searchInput, setSearchInput] = useState("");+ const searchInputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(searchInputRef);const [selectedAccountType, setSelectedAccountType] = useState<string>("");const [debouncedSearch] = useDebounce(searchInput);@@ -324,6 +327,7 @@ export const PamFolderPage = () => {<Search /></InputGroupAddon><InputGroupInput+ ref={searchInputRef}placeholder="Search accounts..."value={searchInput}onChange={(e) => setSearchInput(e.target.value)}diff --git a/frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncsTable.tsx b/frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncsTable.tsxindex 931b44257a..d58e8d00b4 100644--- a/frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncsTable.tsx+++ b/frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncsTable.tsx@@ -1,4 +1,4 @@-import { useMemo, useState } from "react";+import { useMemo, useRef, useState } from "react";import {CheckIcon,ChevronDownIcon,@@ -46,7 +46,7 @@ import {PreferenceKey,setUserTablePreference} from "@app/helpers/userTablePreferences";-import { usePagination, usePopUp, useResetPageHelper } from "@app/hooks";+import { usePagination, usePopUp, useResetPageHelper, useSlashFocusSearch } from "@app/hooks";import { OrderByDirection } from "@app/hooks/api/generic/types";import {SecretSync,@@ -135,6 +135,8 @@ export const SecretSyncsTable = ({ secretSyncs, isPending }: Props) => {} = usePagination<SecretSyncsOrderBy>(SecretSyncsOrderBy.Name, {initPerPage: getUserTablePreference("secretSyncTable", PreferenceKey.PerPage, 20)});+ const searchInputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(searchInputRef);const handlePerPageChange = (newPerPage: number) => {setPerPage(newPerPage);@@ -281,6 +283,7 @@ export const SecretSyncsTable = ({ secretSyncs, isPending }: Props) => {<InputGroupInputvalue={search}onChange={(e) => setSearch(e.target.value)}+ ref={searchInputRef}placeholder="Search secret syncs..."/></InputGroup>diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/ResourceSearchInput/ResourceSearchInput.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/ResourceSearchInput/ResourceSearchInput.tsxindex 5e542bd012..c4cb3c2af6 100644--- a/frontend/src/pages/secret-manager/OverviewPage/components/ResourceSearchInput/ResourceSearchInput.tsx+++ b/frontend/src/pages/secret-manager/OverviewPage/components/ResourceSearchInput/ResourceSearchInput.tsx@@ -14,7 +14,7 @@ import {TooltipContent,TooltipTrigger} from "@app/components/v3";-import { useDebounce } from "@app/hooks";+import { useDebounce, useSlashFocusSearch } from "@app/hooks";import { QuickSearchModal, QuickSearchModalProps } from "../SecretSearchInput/components";import { getResourceSearchStateTransition } from "./resourceSearchState";@@ -37,6 +37,7 @@ export const ResourceSearchInput = ({const [isOptionHighlighted, setIsOptionHighlighted] = useState(false);const deepSearchBtnRef = useRef<HTMLButtonElement>(null);const inputRef = useRef<HTMLInputElement>(null);+ useSlashFocusSearch(inputRef);// local input state so typing doesn't re-render the whole tableconst [inputValue, setInputValue] = useState(externalValue);