Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix(agent-vault): put Cancel first in the delegation and grant dialogs

Scott Wilson16a448229827
diff --git a/frontend/src/components/agent-vault/AddDelegationSubjectsDialog.tsx b/frontend/src/components/agent-vault/AddDelegationSubjectsDialog.tsx
index 590b0ada57..839ad61f8c 100644
--- a/frontend/src/components/agent-vault/AddDelegationSubjectsDialog.tsx
+++ b/frontend/src/components/agent-vault/AddDelegationSubjectsDialog.tsx
@@ -80,7 +80,6 @@ export const AddDelegationSubjectsDialog = ({
const listedUserIds = new Set(delegation?.users.map((user) => user.id));
const listedGroupIds = new Set(delegation?.groups.map((group) => group.id));
- const listedCount = listedUserIds.size + listedGroupIds.size;
const options = useMemo<SubjectOption[]>(
() => [
@@ -144,16 +143,11 @@ export const AddDelegationSubjectsDialog = ({
}
};
- const replacementNote = () => {
- if (isAllMembers && listedCount) {
- return `This replaces the ${listedCount} ${listedCount === 1 ? "user or group" : "users and groups"} listed.`;
- }
- if (!isAllMembers && isCurrentlyAllMembers) {
- return "This replaces All Agent Vault Members with the users and groups you pick.";
- }
- return null;
- };
- const note = replacementNote();
+ // Only narrowing gets a note: switching to all members still covers everyone listed.
+ const note =
+ !isAllMembers && isCurrentlyAllMembers
+ ? "This replaces All Agent Vault Members with the users and groups you pick."
+ : null;
return (
<Dialog open={isOpen} onOpenChange={onOpenChange}>
@@ -246,6 +240,9 @@ export const AddDelegationSubjectsDialog = ({
)}
<DialogFooter>
+ <Button variant="ghost" onClick={() => onOpenChange(false)}>
+ Cancel
+ </Button>
<Button
variant="av"
isDisabled={isUnchanged}
@@ -254,9 +251,6 @@ export const AddDelegationSubjectsDialog = ({
>
{isAllMembers ? "Allow All Members" : "Add"}
</Button>
- <Button variant="outline" onClick={() => onOpenChange(false)}>
- Cancel
- </Button>
</DialogFooter>
</DialogContent>
</Dialog>
diff --git a/frontend/src/components/agent-vault/GrantAccessDialog.tsx b/frontend/src/components/agent-vault/GrantAccessDialog.tsx
index ae95bc1d05..e4ec44e3ae 100644
--- a/frontend/src/components/agent-vault/GrantAccessDialog.tsx
+++ b/frontend/src/components/agent-vault/GrantAccessDialog.tsx
@@ -177,6 +177,9 @@ export const GrantAccessDialog = ({ isOpen, onOpenChange, accessBundleId }: Prop
</Field>
<DialogFooter>
+ <Button variant="ghost" onClick={() => onOpenChange(false)}>
+ Cancel
+ </Button>
<Button
variant="av"
isDisabled={!selected.length}
@@ -185,9 +188,6 @@ export const GrantAccessDialog = ({ isOpen, onOpenChange, accessBundleId }: Prop
>
Grant Access
</Button>
- <Button variant="outline" onClick={() => onOpenChange(false)}>
- Cancel
- </Button>
</DialogFooter>
</DialogContent>
</Dialog>