Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

refactor(validation): remove limit on described failing secrets in validation errors

Dimitris Staratzis178a1b540bf6
diff --git a/backend/src/services/secret-validation-rule/secret-validation-rule-constants.ts b/backend/src/services/secret-validation-rule/secret-validation-rule-constants.ts
index 5341ff823a..60a1587cad 100644
--- a/backend/src/services/secret-validation-rule/secret-validation-rule-constants.ts
+++ b/backend/src/services/secret-validation-rule/secret-validation-rule-constants.ts
@@ -6,6 +6,3 @@ export const MAX_GENERATED_CONSTRAINT_LENGTH = 2048;
export const MAX_CONSTRAINT_PATTERN_LENGTH = 4096;
export const MAX_CONSTRAINT_AFFIX_LENGTH = 1024;
-
-// a bulk write or a folder move can fail on every secret it carries, so the error describes only the first few
-export const MAX_DESCRIBED_FAILING_SECRETS = 5;
diff --git a/backend/src/services/secret-validation-rule/secret-validation-rule-errors.ts b/backend/src/services/secret-validation-rule/secret-validation-rule-errors.ts
index d24d20c78f..007c3c76e8 100644
--- a/backend/src/services/secret-validation-rule/secret-validation-rule-errors.ts
+++ b/backend/src/services/secret-validation-rule/secret-validation-rule-errors.ts
@@ -1,6 +1,5 @@
import { BadRequestError } from "@app/lib/errors";
-import { MAX_DESCRIBED_FAILING_SECRETS } from "./secret-validation-rule-constants";
import { TConstraintViolation } from "./secret-validation-rule-constraint-fns";
export type TCanDescribeLocation = (environment: string, secretPath: string) => boolean;
@@ -28,18 +27,7 @@ export const describeSecretValidationFailures = (
failures: TSecretValidationFailure[],
canDescribeLocation?: TCanDescribeLocation
) => {
- // capped by secret rather than by failure, so every failure of a secret that is listed stays visible
- const failingKeys = [...new Set(failures.map((failure) => failure.secretKey))];
- const describedKeys = new Set(failingKeys.slice(0, MAX_DESCRIBED_FAILING_SECRETS));
- const described = failures
- .filter((failure) => describedKeys.has(failure.secretKey))
- .map((failure) => describeFailure(failure, canDescribeLocation));
-
- const remaining = failingKeys.length - describedKeys.size;
- if (remaining > 0) {
- described.push(`...and ${remaining} more ${remaining === 1 ? "secret" : "secrets"} failed validation`);
- }
-
+ const described = failures.map((failure) => describeFailure(failure, canDescribeLocation));
return `Secret validation failed:\n${described.join("\n\n")}`;
};