Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

address bot reviews

Andrey17ad1382db2e
diff --git a/backend/src/ee/services/pam-web-access/pam-web-access-service.ts b/backend/src/ee/services/pam-web-access/pam-web-access-service.ts
index afb3f11b9e..f45e6b9406 100644
--- a/backend/src/ee/services/pam-web-access/pam-web-access-service.ts
+++ b/backend/src/ee/services/pam-web-access/pam-web-access-service.ts
@@ -687,7 +687,7 @@ export const pamWebAccessServiceFactory = ({
const sessionId = session?.id;
if (!sessionId || cleanedUp) return;
try {
- if (!(await pamSessionDAL.isSessionTerminated(sessionId))) return;
+ if (!(await pamSessionDAL.isSessionTerminated(sessionId)) || cleanedUp) return;
await cleanup();
sendSessionEndAndClose(socket, SessionEndReason.Terminated);
} catch (err) {
diff --git a/backend/src/ee/services/pam-web-access/snowflake/pam-snowflake-data-explorer-fns.test.ts b/backend/src/ee/services/pam-web-access/snowflake/pam-snowflake-data-explorer-fns.test.ts
index 9109842b0d..abba07450c 100644
--- a/backend/src/ee/services/pam-web-access/snowflake/pam-snowflake-data-explorer-fns.test.ts
+++ b/backend/src/ee/services/pam-web-access/snowflake/pam-snowflake-data-explorer-fns.test.ts
@@ -98,3 +98,12 @@ describe("nextTransactionState", () => {
expect(nextTransactionState("SELECT", false)).toBe(false);
});
});
+
+describe("nextTransactionState", () => {
+ test("DDL implicitly ends a transaction", () => {
+ expect(nextTransactionState("BEGIN", false)).toBe(true);
+ expect(nextTransactionState("CREATE", true)).toBe(false);
+ expect(nextTransactionState("SELECT", true)).toBe(true);
+ expect(nextTransactionState("COMMIT", true)).toBe(false);
+ });
+});
diff --git a/backend/src/ee/services/pam-web-access/snowflake/pam-snowflake-data-explorer-fns.ts b/backend/src/ee/services/pam-web-access/snowflake/pam-snowflake-data-explorer-fns.ts
index 7c66766894..109e5985d5 100644
--- a/backend/src/ee/services/pam-web-access/snowflake/pam-snowflake-data-explorer-fns.ts
+++ b/backend/src/ee/services/pam-web-access/snowflake/pam-snowflake-data-explorer-fns.ts
@@ -98,7 +98,17 @@ export const extractCommand = (sql: string): string => {
};
const TRANSACTION_OPENING_COMMANDS = new Set(["BEGIN", "START"]);
-const TRANSACTION_CLOSING_COMMANDS = new Set(["COMMIT", "ROLLBACK"]);
+// Snowflake commits an open transaction implicitly before running any of these
+const TRANSACTION_CLOSING_COMMANDS = new Set([
+ "COMMIT",
+ "ROLLBACK",
+ "CREATE",
+ "ALTER",
+ "DROP",
+ "TRUNCATE",
+ "GRANT",
+ "REVOKE"
+]);
// Snowflake reports no transaction flag on a result, so it is tracked from the statements run
export const nextTransactionState = (command: string, current: boolean): boolean => {