Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

feat: completed next set of secrets

=20d09f2c96fc
diff --git a/tests/suites/secretmanager/secrets/batch_test.go b/tests/suites/secretmanager/secrets/batch_test.go
new file mode 100644
index 0000000000..800852e9df
--- /dev/null
+++ b/tests/suites/secretmanager/secrets/batch_test.go
@@ -0,0 +1,204 @@
+package secrets_test
+
+import (
+ "net/http"
+ "slices"
+ "testing"
+
+ "github.com/Infisical/infisical/tests/clients/api"
+ "github.com/Infisical/infisical/tests/fixture"
+ "github.com/Infisical/infisical/tests/fixture/secretmanager"
+ "github.com/Infisical/infisical/tests/harness"
+ "github.com/stretchr/testify/require"
+)
+
+func TestSecret_Batch(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ createBody := func(proj *fixture.Project, values map[string]string) api.CreateManySecretsV4JSONRequestBody {
+ body := api.CreateManySecretsV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev"}
+ body.Secrets = slices.Grow(body.Secrets, len(values))[:len(values)]
+ i := 0
+ for key, value := range values {
+ body.Secrets[i].SecretKey, body.Secrets[i].SecretValue = key, value
+ i++
+ }
+ return body
+ }
+
+ valuesOf := func(t *testing.T, proj *fixture.Project, opts ...secretmanager.SecretOption) map[string]string {
+ t.Helper()
+ values := map[string]string{}
+ for _, s := range secretmanager.ListSecrets(t, proj, "dev", opts...) {
+ values[s.Key] = s.Value
+ }
+ return values
+ }
+
+ t.Run("should create every secret in one call", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ want := map[string]string{"A": "a", "B": "b", "C": "c"}
+
+ // Action
+ res, err := tn.Admin.API.CreateManySecretsV4WithResponse(t.Context(), createBody(proj, want))
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, res.StatusCode(), "batch create returned %s", res.Body)
+ require.Equal(t, want, valuesOf(t, proj))
+ })
+
+ t.Run("should refuse the whole batch and create none of it when one name already exists", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateSecret(t, proj, "dev", "B", "original")
+
+ // Action
+ res, err := tn.Admin.API.CreateManySecretsV4WithResponse(t.Context(),
+ createBody(proj, map[string]string{"A": "a", "B": "b", "C": "c"}))
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusBadRequest, res.StatusCode())
+ require.Equal(t, "Secret already exists: 'B' in path '/' of environment 'dev'", res.JSON400.Message)
+ require.Equal(t, map[string]string{"B": "original"}, valuesOf(t, proj))
+ })
+
+ t.Run("should update every secret's value", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateSecret(t, proj, "dev", "A", "old-a")
+ secretmanager.CreateSecret(t, proj, "dev", "B", "old-b")
+ body := api.UpdateManySecretsV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev"}
+ body.Secrets = slices.Grow(body.Secrets, 2)[:2]
+ body.Secrets[0].SecretKey, body.Secrets[0].SecretValue = "A", new("new-a")
+ body.Secrets[1].SecretKey, body.Secrets[1].SecretValue = "B", new("new-b")
+
+ // Action
+ res, err := tn.Admin.API.UpdateManySecretsV4WithResponse(t.Context(), body)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, res.StatusCode(), "batch update returned %s", res.Body)
+ require.Equal(t, map[string]string{"A": "new-a", "B": "new-b"}, valuesOf(t, proj))
+ })
+
+ t.Run("should refuse the whole update and change nothing when one name does not exist", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateSecret(t, proj, "dev", "A", "old-a")
+ body := api.UpdateManySecretsV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev", Mode: new(api.FailOnNotFound)}
+ body.Secrets = slices.Grow(body.Secrets, 2)[:2]
+ body.Secrets[0].SecretKey, body.Secrets[0].SecretValue = "A", new("new-a")
+ body.Secrets[1].SecretKey, body.Secrets[1].SecretValue = "MISSING", new("value")
+
+ // Action
+ res, err := tn.Admin.API.UpdateManySecretsV4WithResponse(t.Context(), body)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusNotFound, res.StatusCode())
+ require.Equal(t, "Secret does not exist: MISSING in path /", res.JSON404.Message)
+ require.Equal(t, map[string]string{"A": "old-a"}, valuesOf(t, proj))
+ })
+
+ t.Run("should create the missing secrets when updating in upsert mode", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateSecret(t, proj, "dev", "EXISTING", "old")
+ body := api.UpdateManySecretsV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev", Mode: new(api.Upsert)}
+ body.Secrets = slices.Grow(body.Secrets, 2)[:2]
+ body.Secrets[0].SecretKey, body.Secrets[0].SecretValue = "EXISTING", new("new")
+ body.Secrets[1].SecretKey, body.Secrets[1].SecretValue = "BRAND_NEW", new("created")
+
+ // Action
+ res, err := tn.Admin.API.UpdateManySecretsV4WithResponse(t.Context(), body)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, res.StatusCode(), "upsert returned %s", res.Body)
+ require.Equal(t, map[string]string{"EXISTING": "new", "BRAND_NEW": "created"}, valuesOf(t, proj))
+ })
+
+ t.Run("should write each secret to its own path when upserting with per-secret paths", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateFolder(t, proj, "dev", "/app")
+ body := api.UpdateManySecretsV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev", Mode: new(api.Upsert)}
+ body.Secrets = slices.Grow(body.Secrets, 2)[:2]
+ body.Secrets[0].SecretKey, body.Secrets[0].SecretValue, body.Secrets[0].SecretPath = "ROOT_KEY", new("root"), new("/")
+ body.Secrets[1].SecretKey, body.Secrets[1].SecretValue, body.Secrets[1].SecretPath = "APP_KEY", new("app"), new("/app")
+
+ // Action
+ res, err := tn.Admin.API.UpdateManySecretsV4WithResponse(t.Context(), body)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, res.StatusCode(), "upsert returned %s", res.Body)
+ require.Equal(t, map[string]string{"ROOT_KEY": "root"}, valuesOf(t, proj))
+ require.Equal(t, map[string]string{"APP_KEY": "app"}, valuesOf(t, proj, secretmanager.WithPath("/app")))
+ })
+
+ t.Run("should delete every listed secret and keep the rest", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ for _, key := range []string{"A", "B", "KEPT"} {
+ secretmanager.CreateSecret(t, proj, "dev", key, "value")
+ }
+ body := api.DeleteManySecretsV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev"}
+ body.Secrets = slices.Grow(body.Secrets, 2)[:2]
+ body.Secrets[0].SecretKey, body.Secrets[1].SecretKey = "A", "B"
+
+ // Action
+ res, err := tn.Admin.API.DeleteManySecretsV4WithResponse(t.Context(), body)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, res.StatusCode(), "batch delete returned %s", res.Body)
+ require.Equal(t, map[string]string{"KEPT": "value"}, valuesOf(t, proj))
+ })
+
+ t.Run("should refuse the whole delete and keep every secret when one name does not exist", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateSecret(t, proj, "dev", "A", "value")
+ body := api.DeleteManySecretsV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev"}
+ body.Secrets = slices.Grow(body.Secrets, 2)[:2]
+ body.Secrets[0].SecretKey, body.Secrets[1].SecretKey = "A", "MISSING"
+
+ // Action
+ res, err := tn.Admin.API.DeleteManySecretsV4WithResponse(t.Context(), body)
+
+ // Assert
+ require.NoError(t, err)
+ // Status only: the message names the keys that do exist rather than the missing one.
+ require.Equal(t, http.StatusNotFound, res.StatusCode())
+ require.Equal(t, map[string]string{"A": "value"}, valuesOf(t, proj))
+ })
+}
diff --git a/tests/suites/secretmanager/secrets/duplicate_test.go b/tests/suites/secretmanager/secrets/duplicate_test.go
new file mode 100644
index 0000000000..b2ca2e2ffe
--- /dev/null
+++ b/tests/suites/secretmanager/secrets/duplicate_test.go
@@ -0,0 +1,138 @@
+package secrets_test
+
+import (
+ "fmt"
+ "net/http"
+ "testing"
+
+ "github.com/Infisical/infisical/tests/clients/api"
+ "github.com/Infisical/infisical/tests/fixture"
+ "github.com/Infisical/infisical/tests/fixture/secretmanager"
+ "github.com/Infisical/infisical/tests/harness"
+ "github.com/google/uuid"
+ "github.com/stretchr/testify/require"
+)
+
+func TestSecret_Duplicate(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ t.Run("should copy only the attributes asked for and leave the source untouched", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ created, err := tn.Admin.API.CreateSecretV4WithResponse(t.Context(), "API_KEY", api.CreateSecretV4JSONRequestBody{
+ ProjectId: proj.ID, Environment: "dev", SecretValue: "value", SecretComment: new("rotate monthly"),
+ })
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, created.StatusCode(), "creating returned %s", created.Body)
+ source := secretmanager.GetSecret(t, proj, "dev", "API_KEY")
+ body := api.DuplicateSecretV4JSONRequestBody{
+ ProjectId: proj.ID,
+ SourceEnvironment: "dev",
+ DestinationEnvironment: "prod",
+ SecretIds: []uuid.UUID{uuid.MustParse(source.ID)},
+ }
+ body.AttributesToCopy = &struct {
+ Comment *bool `json:"comment,omitempty"`
+ Metadata *bool `json:"metadata,omitempty"`
+ SkipMultilineEncoding *bool `json:"skipMultilineEncoding,omitempty"`
+ Tags *bool `json:"tags,omitempty"`
+ Value *bool `json:"value,omitempty"`
+ }{Value: new(true), Comment: new(false)}
+
+ // Action
+ res, err := tn.Admin.API.DuplicateSecretV4WithResponse(t.Context(), body)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, res.StatusCode(), "duplicating returned %s", res.Body)
+ copied := commentAndValue(t, tn.Admin.API, proj, "prod")
+ require.Equal(t, [2]string{"", "value"}, copied, "the copy should carry the value but not the comment")
+ require.Equal(t, [2]string{"rotate monthly", "value"}, commentAndValue(t, tn.Admin.API, proj, "dev"))
+ })
+
+ t.Run("should refuse duplicating into the same environment and path", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ source := secretmanager.CreateSecret(t, proj, "dev", "API_KEY", "value")
+
+ // Action
+ res, err := tn.Admin.API.DuplicateSecretV4WithResponse(t.Context(), api.DuplicateSecretV4JSONRequestBody{
+ ProjectId: proj.ID,
+ SourceEnvironment: "dev",
+ DestinationEnvironment: "dev",
+ SecretIds: []uuid.UUID{uuid.MustParse(source.ID)},
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusBadRequest, res.StatusCode())
+ require.Equal(t, "Cannot duplicate secrets to the same environment and path", res.JSON400.Message)
+ require.Len(t, secretmanager.ListSecrets(t, proj, "dev"), 1)
+ })
+
+ t.Run("should refuse and keep the destination when the name exists there without overwrite", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ source := secretmanager.CreateSecret(t, proj, "dev", "API_KEY", "from-dev")
+ secretmanager.CreateSecret(t, proj, "prod", "API_KEY", "from-prod")
+
+ // Action
+ res, err := tn.Admin.API.DuplicateSecretV4WithResponse(t.Context(), api.DuplicateSecretV4JSONRequestBody{
+ ProjectId: proj.ID,
+ SourceEnvironment: "dev",
+ DestinationEnvironment: "prod",
+ SecretIds: []uuid.UUID{uuid.MustParse(source.ID)},
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusBadRequest, res.StatusCode())
+ require.Equal(t, "Secret with key 'API_KEY' already exists at destination. Set shouldOverwrite to true to replace it.",
+ res.JSON400.Message)
+ require.Equal(t, "from-prod", secretmanager.GetSecret(t, proj, "prod", "API_KEY").Value)
+ })
+
+ t.Run("should refuse a secret that is not in the source folder", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ elsewhere := secretmanager.CreateSecret(t, proj, "staging", "API_KEY", "value")
+
+ // Action
+ res, err := tn.Admin.API.DuplicateSecretV4WithResponse(t.Context(), api.DuplicateSecretV4JSONRequestBody{
+ ProjectId: proj.ID,
+ SourceEnvironment: "dev",
+ DestinationEnvironment: "prod",
+ SecretIds: []uuid.UUID{uuid.MustParse(elsewhere.ID)},
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusNotFound, res.StatusCode())
+ require.Equal(t,
+ fmt.Sprintf("Secret with ID '%s' not found in source folder with path '/' and environment slug 'dev'", elsewhere.ID),
+ res.JSON404.Message)
+ require.Empty(t, secretmanager.ListSecrets(t, proj, "prod"))
+ })
+}
+
+func commentAndValue(t *testing.T, client *api.ClientWithResponses, proj *fixture.Project, env string) [2]string {
+ t.Helper()
+ res, err := client.GetSecretByNameV4WithResponse(t.Context(), "API_KEY",
+ &api.GetSecretByNameV4Params{ProjectId: proj.ID, Environment: &env})
+ require.NoError(t, err)
+ require.NotNilf(t, res.JSON200, "reading API_KEY in %s returned %d: %s", env, res.StatusCode(), res.Body)
+ return [2]string{res.JSON200.Secret.SecretComment, res.JSON200.Secret.SecretValue}
+}
diff --git a/tests/suites/secretmanager/secrets/move_test.go b/tests/suites/secretmanager/secrets/move_test.go
new file mode 100644
index 0000000000..3995fbb2dc
--- /dev/null
+++ b/tests/suites/secretmanager/secrets/move_test.go
@@ -0,0 +1,118 @@
+package secrets_test
+
+import (
+ "net/http"
+ "testing"
+
+ "github.com/Infisical/infisical/tests/clients/api"
+ "github.com/Infisical/infisical/tests/fixture"
+ "github.com/Infisical/infisical/tests/fixture/secretmanager"
+ "github.com/Infisical/infisical/tests/harness"
+ "github.com/stretchr/testify/require"
+)
+
+func TestSecret_Move(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ t.Run("should move the secret to the destination and remove it from the source", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateFolder(t, proj, "prod", "/app")
+ moved := secretmanager.CreateSecret(t, proj, "dev", "API_KEY", "value")
+
+ // Action
+ res, err := tn.Admin.API.MoveSecretsV4WithResponse(t.Context(), api.MoveSecretsV4JSONRequestBody{
+ ProjectId: proj.ID,
+ SourceEnvironment: "dev",
+ DestinationEnvironment: "prod",
+ DestinationSecretPath: new("/app"),
+ SecretIds: []string{moved.ID},
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.NotNilf(t, res.JSON200, "moving returned %d: %s", res.StatusCode(), res.Body)
+ require.True(t, res.JSON200.IsSourceUpdated)
+ require.True(t, res.JSON200.IsDestinationUpdated)
+ require.Empty(t, secretmanager.ListSecrets(t, proj, "dev"))
+ require.Equal(t, "value", secretmanager.GetSecret(t, proj, "prod", "API_KEY", secretmanager.WithPath("/app")).Value)
+ })
+
+ t.Run("should refuse and move nothing when the destination holds a different value without overwrite", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ moved := secretmanager.CreateSecret(t, proj, "dev", "API_KEY", "from-dev")
+ secretmanager.CreateSecret(t, proj, "prod", "API_KEY", "from-prod")
+
+ // Action
+ res, err := tn.Admin.API.MoveSecretsV4WithResponse(t.Context(), api.MoveSecretsV4JSONRequestBody{
+ ProjectId: proj.ID,
+ SourceEnvironment: "dev",
+ DestinationEnvironment: "prod",
+ SecretIds: []string{moved.ID},
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusBadRequest, res.StatusCode())
+ require.Equal(t, "Failed to move secrets. The following secrets already exist in the destination: API_KEY", res.JSON400.Message)
+ require.Equal(t, "from-dev", secretmanager.GetSecret(t, proj, "dev", "API_KEY").Value)
+ require.Equal(t, "from-prod", secretmanager.GetSecret(t, proj, "prod", "API_KEY").Value)
+ })
+
+ t.Run("should replace the destination value when overwrite is set", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ moved := secretmanager.CreateSecret(t, proj, "dev", "API_KEY", "from-dev")
+ secretmanager.CreateSecret(t, proj, "prod", "API_KEY", "from-prod")
+
+ // Action
+ res, err := tn.Admin.API.MoveSecretsV4WithResponse(t.Context(), api.MoveSecretsV4JSONRequestBody{
+ ProjectId: proj.ID,
+ SourceEnvironment: "dev",
+ DestinationEnvironment: "prod",
+ SecretIds: []string{moved.ID},
+ ShouldOverwrite: new(true),
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, res.StatusCode(), "moving returned %s", res.Body)
+ require.Equal(t, "from-dev", secretmanager.GetSecret(t, proj, "prod", "API_KEY").Value)
+ require.Empty(t, secretmanager.ListSecrets(t, proj, "dev"))
+ })
+
+ t.Run("should refuse and move nothing when the destination folder does not exist", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ moved := secretmanager.CreateSecret(t, proj, "dev", "API_KEY", "value")
+
+ // Action
+ res, err := tn.Admin.API.MoveSecretsV4WithResponse(t.Context(), api.MoveSecretsV4JSONRequestBody{
+ ProjectId: proj.ID,
+ SourceEnvironment: "dev",
+ DestinationEnvironment: "prod",
+ DestinationSecretPath: new("/missing"),
+ SecretIds: []string{moved.ID},
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusNotFound, res.StatusCode())
+ require.Equal(t, "Destination folder with path '/missing' in environment with slug 'prod' not found", res.JSON404.Message)
+ require.Equal(t, "value", secretmanager.GetSecret(t, proj, "dev", "API_KEY").Value)
+ })
+}
diff --git a/tests/suites/secretmanager/secrets/personal_test.go b/tests/suites/secretmanager/secrets/personal_test.go
new file mode 100644
index 0000000000..2f12f7e7c3
--- /dev/null
+++ b/tests/suites/secretmanager/secrets/personal_test.go
@@ -0,0 +1,142 @@
+package secrets_test
+
+import (
+ "net/http"
+ "testing"
+
+ "github.com/Infisical/infisical/tests/clients/api"
+ "github.com/Infisical/infisical/tests/fixture"
+ "github.com/Infisical/infisical/tests/fixture/secretmanager"
+ "github.com/Infisical/infisical/tests/harness"
+ "github.com/stretchr/testify/require"
+)
+
+func TestSecret_PersonalOverride(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ t.Run("should refuse an override when no shared secret has that name", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ proj := fixture.NewProject(t, h.NewTenant(t), fixture.WithProjectType("secret-manager"))
+ owner := proj.NewUser(t, fixture.WithPrincipalName("owner"))
+
+ // Action
+ res, err := owner.API.CreateSecretV4WithResponse(t.Context(), "DB_PASS", api.CreateSecretV4JSONRequestBody{
+ ProjectId: proj.ID,
+ Environment: "dev",
+ SecretValue: "mine",
+ Type: new(api.CreateSecretV4JSONBodyTypePersonal),
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusBadRequest, res.StatusCode())
+ require.Equal(t, "Failed to create personal secret override for no corresponding shared secret", res.JSON400.Message)
+ require.Empty(t, secretmanager.ListSecrets(t, proj, "dev", secretmanager.As(owner), secretmanager.WithPersonal()))
+ })
+
+ t.Run("should show the owner their override only when overrides are included", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ proj := fixture.NewProject(t, h.NewTenant(t), fixture.WithProjectType("secret-manager"))
+ owner := proj.NewUser(t, fixture.WithPrincipalName("owner"))
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "shared")
+
+ // Action
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "mine", secretmanager.As(owner), secretmanager.WithPersonal())
+
+ // Assert
+ withOverrides := secretmanager.ListSecrets(t, proj, "dev", secretmanager.As(owner), secretmanager.WithPersonal())
+ require.Len(t, withOverrides, 1)
+ require.Equal(t, "mine", withOverrides[0].Value)
+ withoutOverrides := secretmanager.ListSecrets(t, proj, "dev", secretmanager.As(owner))
+ require.Len(t, withoutOverrides, 1)
+ require.Equal(t, "shared", withoutOverrides[0].Value)
+ })
+
+ t.Run("should show another member only the shared value", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ proj := fixture.NewProject(t, h.NewTenant(t), fixture.WithProjectType("secret-manager"))
+ owner := proj.NewUser(t, fixture.WithPrincipalName("owner"))
+ other := proj.NewUser(t, fixture.WithPrincipalName("other"))
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "shared")
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "mine", secretmanager.As(owner), secretmanager.WithPersonal())
+
+ // Action
+ seen := secretmanager.ListSecrets(t, proj, "dev", secretmanager.As(other), secretmanager.WithPersonal())
+
+ // Assert
+ require.Len(t, seen, 1)
+ require.Equal(t, "shared", seen[0].Value)
+ })
+
+ t.Run("should keep the shared secret when the override is deleted", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ proj := fixture.NewProject(t, h.NewTenant(t), fixture.WithProjectType("secret-manager"))
+ owner := proj.NewUser(t, fixture.WithPrincipalName("owner"))
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "shared")
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "mine", secretmanager.As(owner), secretmanager.WithPersonal())
+
+ // Action
+ secretmanager.DeleteSecret(t, proj, "dev", "DB_PASS", secretmanager.As(owner), secretmanager.WithPersonal())
+
+ // Assert
+ seen := secretmanager.ListSecrets(t, proj, "dev", secretmanager.As(owner), secretmanager.WithPersonal())
+ require.Len(t, seen, 1)
+ require.Equal(t, "shared", seen[0].Value)
+ })
+
+ t.Run("should refuse an override from a machine identity", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ proj := fixture.NewProject(t, h.NewTenant(t), fixture.WithProjectType("secret-manager"))
+ identity := proj.NewMachineIdentity(t, fixture.WithRoles("member"))
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "shared")
+
+ // Action
+ res, err := identity.API.CreateSecretV4WithResponse(t.Context(), "DB_PASS", api.CreateSecretV4JSONRequestBody{
+ ProjectId: proj.ID,
+ Environment: "dev",
+ SecretValue: "mine",
+ Type: new(api.CreateSecretV4JSONBodyTypePersonal),
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusBadRequest, res.StatusCode())
+ require.Equal(t, "Must be user to create personal secret", res.JSON400.Message)
+ require.Equal(t, "shared", secretmanager.GetSecret(t, proj, "dev", "DB_PASS").Value)
+ })
+
+ t.Run("should refuse renaming an override and keep its name", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ proj := fixture.NewProject(t, h.NewTenant(t), fixture.WithProjectType("secret-manager"))
+ owner := proj.NewUser(t, fixture.WithPrincipalName("owner"))
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "shared")
+ secretmanager.CreateSecret(t, proj, "dev", "DB_PASS", "mine", secretmanager.As(owner), secretmanager.WithPersonal())
+
+ // Action
+ res, err := owner.API.UpdateSecretV4WithResponse(t.Context(), "DB_PASS", api.UpdateSecretV4JSONRequestBody{
+ ProjectId: proj.ID,
+ Environment: "dev",
+ Type: new(api.UpdateSecretV4JSONBodyTypePersonal),
+ NewSecretName: new("RENAMED"),
+ })
+
+ // Assert
+ require.NoError(t, err)
+ require.Equal(t, http.StatusBadRequest, res.StatusCode())
+ require.Equal(t, "Personal secret cannot change the key name", res.JSON400.Message)
+ require.Equal(t, "mine", secretmanager.GetSecret(t, proj, "dev", "DB_PASS", secretmanager.As(owner), secretmanager.WithPersonal()).Value)
+ })
+}