Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

chore: remove V2-era overlay z-index overrides (#9036)

Andrew Huang2aa87c95377e
diff --git a/frontend/src/components/external-migrations/VaultRoleImportModal.tsx b/frontend/src/components/external-migrations/VaultRoleImportModal.tsx
index 3665207eaf..965c2a942d 100644
--- a/frontend/src/components/external-migrations/VaultRoleImportModal.tsx
+++ b/frontend/src/components/external-migrations/VaultRoleImportModal.tsx
@@ -279,12 +279,7 @@ const VaultRoleImportModal = <TRole extends VaultRole>({
return (
<Dialog open={isOpen} onOpenChange={onOpenChange}>
{isOpen && (
- // Match the legacy parent modal's layer; portal order keeps this dialog and its comboboxes above it.
- <DialogContent
- className="z-[60] max-w-2xl"
- overlayClassName="z-[60]"
- onOpenAutoFocus={(event) => event.preventDefault()}
- >
+ <DialogContent className="max-w-2xl" onOpenAutoFocus={(event) => event.preventDefault()}>
<DialogHeader>
<DialogTitle>{config.title}</DialogTitle>
<DialogDescription>{config.description}</DialogDescription>
diff --git a/frontend/src/components/license/UpgradeGate/ProductUpgradeSuccessDialog.tsx b/frontend/src/components/license/UpgradeGate/ProductUpgradeSuccessDialog.tsx
index 7aa98beb58..5a9ac56648 100644
--- a/frontend/src/components/license/UpgradeGate/ProductUpgradeSuccessDialog.tsx
+++ b/frontend/src/components/license/UpgradeGate/ProductUpgradeSuccessDialog.tsx
@@ -36,8 +36,7 @@ export const ProductUpgradeSuccessDialog = ({
height="auto"
showCloseButton={false}
onOpenAutoFocus={focusUpgradeContinuation}
- overlayClassName="z-[70]"
- className="z-[70] max-w-sm gap-5"
+ className="max-w-sm gap-5"
>
<DialogBody role="status" className="flex flex-col items-center gap-4 text-center">
<div aria-hidden="true" className="relative shrink-0">
diff --git a/frontend/src/components/license/UpgradeGate/UpgradeDialogLayout.tsx b/frontend/src/components/license/UpgradeGate/UpgradeDialogLayout.tsx
index b0b2a01251..f8731e9e90 100644
--- a/frontend/src/components/license/UpgradeGate/UpgradeDialogLayout.tsx
+++ b/frontend/src/components/license/UpgradeGate/UpgradeDialogLayout.tsx
@@ -55,8 +55,7 @@ export const UpgradeDialogLayout = ({
onCloseAutoFocus={onCloseAutoFocus}
showCloseButton={false}
height="fixed"
- overlayClassName="z-[70]"
- className="@container z-[70] gap-0 overflow-hidden bg-container p-0 sm:max-w-4xl"
+ className="@container gap-0 overflow-hidden bg-container p-0 sm:max-w-4xl"
>
<div className="grid h-full min-h-0 grid-rows-[auto_minmax(0,1fr)] @min-[48rem]:grid-cols-[minmax(16rem,0.9fr)_minmax(0,1.25fr)] @min-[48rem]:grid-rows-1">
<aside
diff --git a/frontend/src/components/license/UpgradeGate/UpgradeGate.tsx b/frontend/src/components/license/UpgradeGate/UpgradeGate.tsx
index c9b645a9da..955af23f9a 100644
--- a/frontend/src/components/license/UpgradeGate/UpgradeGate.tsx
+++ b/frontend/src/components/license/UpgradeGate/UpgradeGate.tsx
@@ -440,10 +440,9 @@ const ProductUpgradeGate = ({ intent, paywallKey, isOpen, onOpenChange }: Props)
return (
<Dialog open onOpenChange={onOpenChange}>
<DialogContent
- overlayClassName="z-[70]"
onOpenAutoFocus={focusUpgradeContinuation}
showCloseButton={false}
- className="z-[70] sm:max-w-xl"
+ className="sm:max-w-xl"
>
<ProductUpgradeHeader
product={product}
@@ -475,10 +474,9 @@ const ProductUpgradeGate = ({ intent, paywallKey, isOpen, onOpenChange }: Props)
return (
<Dialog open onOpenChange={onOpenChange}>
<DialogContent
- overlayClassName="z-[70]"
onOpenAutoFocus={focusUpgradeContinuation}
showCloseButton={false}
- className="z-[70] sm:max-w-xl"
+ className="sm:max-w-xl"
>
<ProductUpgradeHeader
product={product}
@@ -538,10 +536,9 @@ const ProductUpgradeGate = ({ intent, paywallKey, isOpen, onOpenChange }: Props)
}}
>
<DialogContent
- overlayClassName="z-[70]"
key="loading"
showCloseButton={false}
- className="z-[70] w-auto gap-0 border-0 bg-transparent p-0 shadow-none"
+ className="w-auto gap-0 border-0 bg-transparent p-0 shadow-none"
aria-describedby={undefined}
>
<DialogTitle className="sr-only">Loading {productName} plans</DialogTitle>
@@ -556,7 +553,6 @@ const ProductUpgradeGate = ({ intent, paywallKey, isOpen, onOpenChange }: Props)
return (
<Dialog open onOpenChange={onOpenChange}>
<DialogContent
- overlayClassName="z-[70]"
onOpenAutoFocus={(event) => {
const action = (event.currentTarget as HTMLElement | null)?.querySelector<HTMLElement>(
"[data-upgrade-cta]:not(:disabled)"
@@ -566,7 +562,7 @@ const ProductUpgradeGate = ({ intent, paywallKey, isOpen, onOpenChange }: Props)
action.focus({ preventScroll: true });
}}
showCloseButton={false}
- className="z-[70] sm:max-w-xl"
+ className="sm:max-w-xl"
>
<ProductUpgradeHeader
product={product}
@@ -631,10 +627,9 @@ const ProductUpgradeGate = ({ intent, paywallKey, isOpen, onOpenChange }: Props)
return (
<Dialog open onOpenChange={dismissBillingReturn}>
<DialogContent
- overlayClassName="z-[70]"
onOpenAutoFocus={focusUpgradeContinuation}
showCloseButton={false}
- className="z-[70] sm:max-w-xl"
+ className="sm:max-w-xl"
>
<DialogHeader>
<DialogTitle>Check Billing Status</DialogTitle>
@@ -680,10 +675,9 @@ const ProductUpgradeGate = ({ intent, paywallKey, isOpen, onOpenChange }: Props)
return (
<Dialog open onOpenChange={onOpenChange}>
<DialogContent
- overlayClassName="z-[70]"
onOpenAutoFocus={focusUpgradeContinuation}
showCloseButton={false}
- className="z-[70] sm:max-w-xl"
+ className="sm:max-w-xl"
>
<ProductUpgradeHeader
product={product}
diff --git a/frontend/src/components/v3/platform/GatewayPicker/GatewayPicker.tsx b/frontend/src/components/v3/platform/GatewayPicker/GatewayPicker.tsx
index 0bd6ec2cb3..b83081648f 100644
--- a/frontend/src/components/v3/platform/GatewayPicker/GatewayPicker.tsx
+++ b/frontend/src/components/v3/platform/GatewayPicker/GatewayPicker.tsx
@@ -139,7 +139,7 @@ export const GatewayPicker = ({
<SelectTrigger className={className ?? "w-full"} isError={isError}>
<SelectValue placeholder={placeholder ?? "Select gateway..."} />
</SelectTrigger>
- <SelectContent position="popper" className="z-[70]">
+ <SelectContent position="popper">
{!isRequired && (
<SelectItem value="internet">
<span className="flex items-center gap-2">
diff --git a/frontend/src/hooks/api/reactQuery.tsx b/frontend/src/hooks/api/reactQuery.tsx
index 7fd6bd8079..c444d99bdf 100644
--- a/frontend/src/hooks/api/reactQuery.tsx
+++ b/frontend/src/hooks/api/reactQuery.tsx
@@ -58,8 +58,7 @@ function ValidationErrorModal({
}
}}
>
- {/* z-[70] keeps this dialog above v2 Modals (z-[60]) hosting the form that errored */}
- <DialogContent className="z-[70] sm:max-w-2xl" overlayClassName="z-[70]">
+ <DialogContent className="sm:max-w-2xl">
<DialogHeader>
<DialogTitle>Validation Error Details</DialogTitle>
<DialogDescription>These fields did not pass validation.</DialogDescription>
@@ -212,8 +211,7 @@ export const onRequestError = (
Show more
</Button>
</DialogTrigger>
- {/* z-[70] keeps this dialog above v2 Modals (z-[60]) hosting the form that errored */}
- <DialogContent className="z-[70] sm:max-w-2xl" overlayClassName="z-[70]">
+ <DialogContent className="sm:max-w-2xl">
<DialogHeader>
<DialogTitle>Validation Rules</DialogTitle>
<DialogDescription>Please review the allowed rules below.</DialogDescription>
@@ -281,7 +279,7 @@ export const onRequestError = (
Show more
</Button>
</DialogTrigger>
- <DialogContent className="z-[70] sm:max-w-2xl" overlayClassName="z-[70]">
+ <DialogContent className="sm:max-w-2xl">
<DialogHeader>
<DialogTitle>Missing Permissions</DialogTitle>
<DialogDescription>
diff --git a/frontend/src/pages/organization/NetworkingPage/components/GatewayTab/components/PoolDetailSheet.tsx b/frontend/src/pages/organization/NetworkingPage/components/GatewayTab/components/PoolDetailSheet.tsx
index ea4cefffd3..13212822b8 100644
--- a/frontend/src/pages/organization/NetworkingPage/components/GatewayTab/components/PoolDetailSheet.tsx
+++ b/frontend/src/pages/organization/NetworkingPage/components/GatewayTab/components/PoolDetailSheet.tsx
@@ -253,7 +253,7 @@ export const PoolDetailSheet = ({ isOpen, onOpenChange, pool }: Props) => {
<FontAwesomeIcon icon={faEllipsisV} />
</IconButton>
</DropdownMenuTrigger>
- <DropdownMenuContent align="end" className="z-[60] min-w-[180px]">
+ <DropdownMenuContent align="end" className="min-w-[180px]">
<DropdownMenuItem onSelect={() => handleHealthCheck(gw.id)}>
<FontAwesomeIcon icon={faHeartPulse} />
Trigger health check
diff --git a/frontend/src/pages/pam/PamAccountsPage/components/RecordingConnectionPicker.tsx b/frontend/src/pages/pam/PamAccountsPage/components/RecordingConnectionPicker.tsx
index 27f8ca9d3b..67a45ae9eb 100644
--- a/frontend/src/pages/pam/PamAccountsPage/components/RecordingConnectionPicker.tsx
+++ b/frontend/src/pages/pam/PamAccountsPage/components/RecordingConnectionPicker.tsx
@@ -27,7 +27,7 @@ export const RecordingConnectionPicker = ({ value, onChange, isError, includeNon
<SelectTrigger className="w-full" isError={isError}>
<SelectValue placeholder="Select an S3 connection..." />
</SelectTrigger>
- <SelectContent position="popper" className="z-[70]">
+ <SelectContent position="popper">
{includeNone && <SelectItem value={NONE_VALUE}>None</SelectItem>}
{recordingConnections.length === 0 && (
<div className="px-2 py-3 text-center text-xs text-muted">
diff --git a/frontend/src/pages/project/IdentityDetailsByIDPage/components/IdentityRoleDetailsSection/IdentityRoleModify.tsx b/frontend/src/pages/project/IdentityDetailsByIDPage/components/IdentityRoleDetailsSection/IdentityRoleModify.tsx
index 9783cc8fed..9c4546c749 100644
--- a/frontend/src/pages/project/IdentityDetailsByIDPage/components/IdentityRoleDetailsSection/IdentityRoleModify.tsx
+++ b/frontend/src/pages/project/IdentityDetailsByIDPage/components/IdentityRoleDetailsSection/IdentityRoleModify.tsx
@@ -160,7 +160,7 @@ export const IdentityRoleAssignmentRow = ({
<SelectTrigger id={selectId} className="w-full">
<SelectValue />
</SelectTrigger>
- <SelectContent position="popper" className="z-[70]">
+ <SelectContent position="popper">
{getRolesForSelect(field.value).map(({ name, slug, id }) => {
const isAssignable = assignableRoleSlugs.has(slug);
return (
@@ -204,7 +204,6 @@ export const IdentityRoleAssignmentRow = ({
</Tooltip>
<PopoverContent
side="right"
- className="z-[70]"
onWheel={(event) => event.stopPropagation()}
onOpenAutoFocus={(event) => event.preventDefault()}
>
diff --git a/frontend/src/pages/project/MemberDetailsByIDPage/components/MemberRoleDetailsSection/RoleAssignmentRow.tsx b/frontend/src/pages/project/MemberDetailsByIDPage/components/MemberRoleDetailsSection/RoleAssignmentRow.tsx
index 8e69a485fa..1a79ccbb0d 100644
--- a/frontend/src/pages/project/MemberDetailsByIDPage/components/MemberRoleDetailsSection/RoleAssignmentRow.tsx
+++ b/frontend/src/pages/project/MemberDetailsByIDPage/components/MemberRoleDetailsSection/RoleAssignmentRow.tsx
@@ -131,7 +131,7 @@ export const RoleAssignmentRow = ({
<SelectTrigger id={roleSelectId} className="w-full">
<SelectValue />
</SelectTrigger>
- <SelectContent position="popper" className="z-[70]">
+ <SelectContent position="popper">
{rolesForSelect.map(({ name, slug, id }) => {
const isAssignable = assignableRoleSlugs.has(slug);
return (
@@ -176,7 +176,6 @@ export const RoleAssignmentRow = ({
</Tooltip>
<PopoverContent
side="right"
- className="z-[70]"
onWheel={(e) => e.stopPropagation()}
onOpenAutoFocus={(e) => e.preventDefault()}
>
diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/components/ReviewAccessModal.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/components/ReviewAccessModal.tsx
index fa958855b3..ad64fe4176 100644
--- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/components/ReviewAccessModal.tsx
+++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/components/ReviewAccessModal.tsx
@@ -692,7 +692,7 @@ export const ReviewAccessRequestModal = ({
</PopoverTrigger>
<PopoverContent
align="end"
- className="z-[70] max-h-64 thin-scrollbar w-72 overflow-y-auto px-3 py-2.5"
+ className="max-h-64 thin-scrollbar w-72 overflow-y-auto px-3 py-2.5"
aria-label={`Reviewer progress for approval step ${approver.sequence ?? 1}`}
>
<div className="mb-2 text-sm font-medium text-foreground">Reviewer Progress</div>
@@ -974,7 +974,7 @@ export const ReviewAccessRequestModal = ({
{group.conditions.length === 1 ? "condition" : "conditions"}
</button>
</HoverCardTrigger>
- <HoverCardContent align="end" className="z-[70] w-auto max-w-xs">
+ <HoverCardContent align="end" className="w-auto max-w-xs">
<div className="mb-1.5 text-xs font-medium text-foreground">
Conditions
</div>
diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx
index 11ce659a06..8b02edcbbe 100644
--- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx
+++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx
@@ -477,7 +477,7 @@ export const SecretApprovalRequestChanges = ({
{myReview ? "Update Review" : "Review Changes"}
</Button>
</PopoverTrigger>
- <PopoverContent align={myReview ? "end" : "start"} className="z-[70] w-96">
+ <PopoverContent align={myReview ? "end" : "start"} className="w-96">
{reviewForm}
</PopoverContent>
</Popover>