Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix(agent-vault): count-only setup banners and the API's username limit

Scott Wilson2dd4b1384bd6
diff --git a/frontend/src/components/agent-vault/PersonalValuesDialog.tsx b/frontend/src/components/agent-vault/PersonalValuesDialog.tsx
index 26a46964e7..50eb952004 100644
--- a/frontend/src/components/agent-vault/PersonalValuesDialog.tsx
+++ b/frontend/src/components/agent-vault/PersonalValuesDialog.tsx
@@ -78,6 +78,8 @@ const fieldLabel = (
return credentialType === AgentVaultCredentialType.Basic ? "Password" : "Token";
};
+// The API's limits: a username like the admin's, a token or password like theirs.
+const MAX_USERNAME_LENGTH = 256;
const MAX_LENGTH = 8192;
type TFormData = { secret: string; username: string };
@@ -98,11 +100,15 @@ const buildSchema = (
: data[formField];
const at = (message: string) =>
ctx.addIssue({ code: z.ZodIssueCode.custom, path: [formField], message });
+ const maxLength =
+ field === AgentVaultVariableReferenceField.CredentialUsername
+ ? MAX_USERNAME_LENGTH
+ : MAX_LENGTH;
if (!value) {
if (!savedFields.has(field)) at("Required");
- } else if (value.length > MAX_LENGTH) {
- at(`This can be at most ${MAX_LENGTH} characters.`);
+ } else if (value.length > maxLength) {
+ at(`This can be at most ${maxLength} characters.`);
} else if (!NO_CONTROL_CHARS_RE.test(value)) at(CONTROL_CHARS_MESSAGE);
else {
// Only once the list has loaded: until then no key can be called missing.
diff --git a/frontend/src/pages/agent-vault/AgentVaultAccessBundleDetailPage/AgentVaultAccessBundleDetailPage.tsx b/frontend/src/pages/agent-vault/AgentVaultAccessBundleDetailPage/AgentVaultAccessBundleDetailPage.tsx
index 7df7b96e15..4801a52ca1 100644
--- a/frontend/src/pages/agent-vault/AgentVaultAccessBundleDetailPage/AgentVaultAccessBundleDetailPage.tsx
+++ b/frontend/src/pages/agent-vault/AgentVaultAccessBundleDetailPage/AgentVaultAccessBundleDetailPage.tsx
@@ -14,7 +14,6 @@ import {
import { AccessBundleFormDialog } from "@app/components/agent-vault/AccessBundleFormDialog";
import { ManageAccessSheet } from "@app/components/agent-vault/ManageAccessSheet";
-import { nameList } from "@app/components/agent-vault/nameList";
import { PersonalValuesDialog } from "@app/components/agent-vault/PersonalValuesDialog";
import { ServiceSheet } from "@app/components/agent-vault/service-sheet";
import {
@@ -142,7 +141,7 @@ export const AgentVaultAccessBundleDetailPage = () => {
<p>
{needsSetup.length === 1
? `${needsSetup[0].name} requires your personal values.`
- : `${needsSetup.length} services require your personal values: ${nameList(needsSetup.map((service) => service.name))}.`}{" "}
+ : `${needsSetup.length} services require your personal values.`}{" "}
Sessions from this bundle can&apos;t reach {needsSetup.length === 1 ? "it" : "them"}{" "}
until you set {needsSetup.length === 1 ? "it" : "them"} up.
</p>
diff --git a/frontend/src/pages/agent-vault/AgentVaultAccessBundlesPage/AgentVaultAccessBundlesPage.tsx b/frontend/src/pages/agent-vault/AgentVaultAccessBundlesPage/AgentVaultAccessBundlesPage.tsx
index d7984e7525..3517cd9403 100644
--- a/frontend/src/pages/agent-vault/AgentVaultAccessBundlesPage/AgentVaultAccessBundlesPage.tsx
+++ b/frontend/src/pages/agent-vault/AgentVaultAccessBundlesPage/AgentVaultAccessBundlesPage.tsx
@@ -177,10 +177,7 @@ export const AgentVaultAccessBundlesPage = () => {
<p>
{bundlesNeedingSetupCount === 1
? `${bundlesNeedingSetup[0].name} has services that require your personal values.`
- : `${bundlesNeedingSetupCount} access bundles have services that require your personal values: ${nameList(
- bundlesNeedingSetup.map((bundle) => bundle.name),
- bundlesNeedingSetupCount
- )}.`}{" "}
+ : `${bundlesNeedingSetupCount} access bundles have services that require your personal values.`}{" "}
Sessions can&apos;t reach those services until you set them up.
</p>
<AlertAction>