Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
fix(reminders): name migrated reminder alerts generically
Calvin324ad4f8fc99
diff --git a/backend/e2e-test/routes/v1/secret-reminder.spec.ts b/backend/e2e-test/routes/v1/secret-reminder.spec.tsindex ae94f744a2..aed50d700b 100644--- a/backend/e2e-test/routes/v1/secret-reminder.spec.ts+++ b/backend/e2e-test/routes/v1/secret-reminder.spec.ts@@ -92,7 +92,7 @@ describe("Secret reminders delivered through alerts", () => {const secretId = await createSecret("KEEP_WEBHOOK");await setSecretReminder({ secretId, authToken, repeatDays: 30, message: "rotate it", recipients: [member.userId] });const [alert] = await reminderAlerts(secretId);- expect(alert.name).toBe("Reminder for KEEP_WEBHOOK");+ expect(alert.name).toBe("Secret reminder");expect(alert.channels).toEqual([expect.objectContaining({channelType: "email",@@ -424,7 +424,7 @@ describe("Secret reminders delivered through alerts", () => {await migrateRemindersToAlerts(testDb);const [alert] = await reminderAlerts(secretId);- expect(alert).toMatchObject({ name: "Reminder for MIGRATE", triggerType: "event" });+ expect(alert).toMatchObject({ name: "Secret reminder", triggerType: "event" });expect(alert.channels).toHaveLength(1);expect(alert.channels[0].recipients).toEqual([{ principalType: "user", principalId: member.userId }]);// The API does not report who created an alert.diff --git a/backend/src/db/migrations/20260929130000_migrate-secret-reminders-to-alerts.ts b/backend/src/db/migrations/20260929130000_migrate-secret-reminders-to-alerts.tsindex 0824fe8699..0c1cf767be 100644--- a/backend/src/db/migrations/20260929130000_migrate-secret-reminders-to-alerts.ts+++ b/backend/src/db/migrations/20260929130000_migrate-secret-reminders-to-alerts.ts@@ -19,7 +19,7 @@ import { getMigrationEncryptionServices, getMigrationHsmService } from "./utils/// migration did.const RESOURCE_TYPE = "secret.reminder";const EVENT_TYPE = "secret.reminder.due";-const MAX_ALERT_NAME_LENGTH = 255;+const ALERT_NAME = "Secret reminder";const MAX_RECIPIENTS_PER_CHANNEL = 20;const CATCH_UP_DAYS = 7;const DAY_MS = 24 * 60 * 60 * 1000;@@ -29,7 +29,6 @@ const BATCH_STATEMENT_TIMEOUT_MS = 60_000;type TReminderRow = {id: string;secretId: string;- secretKey: string;projectId: string;orgId: string;};@@ -112,7 +111,6 @@ export async function up(knex: Knex): Promise<void> {.select(knex.ref("id").withSchema(TableName.Reminder),knex.ref("secretId").withSchema(TableName.Reminder),- knex.ref("key").withSchema(TableName.SecretV2).as("secretKey"),knex.ref("id").withSchema(TableName.Project).as("projectId"),knex.ref("orgId").withSchema(TableName.Project).as("orgId"))) as TReminderRow[];@@ -187,7 +185,7 @@ export async function up(knex: Knex): Promise<void> {for (const reminder of pending.filter(({ id }) => recipientsByReminder.has(id))) {const [alert] = (await tx(TableName.Alert).insert({- name: `Reminder for ${reminder.secretKey}`.slice(0, MAX_ALERT_NAME_LENGTH),+ name: ALERT_NAME,resourceType: RESOURCE_TYPE,resourceId: reminder.secretId,eventType: EVENT_TYPE,