Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix: error message

adilson3294b334b37d
diff --git a/backend/src/ee/services/secret-approval-request/secret-approval-request-commit-fns.test.ts b/backend/src/ee/services/secret-approval-request/secret-approval-request-commit-fns.test.ts
index 0c3451050a..ef02a680ec 100644
--- a/backend/src/ee/services/secret-approval-request/secret-approval-request-commit-fns.test.ts
+++ b/backend/src/ee/services/secret-approval-request/secret-approval-request-commit-fns.test.ts
@@ -238,6 +238,28 @@ describe("buildSecretApprovalCommits", () => {
).rejects.toBeInstanceOf(NotFoundError);
});
+ test("names the secrets missing from a rename, not the ones that were found", async () => {
+ const stored = [
+ { id: "secret-1", key: "KEEP", version: 1 },
+ { id: "secret-2", key: "GONE", version: 1 }
+ ];
+ const { fns, deps } = buildFns({ stored });
+ deps.secretV2BridgeDAL.findBySecretKeys.mockResolvedValueOnce(stored).mockResolvedValueOnce([stored[0]]);
+
+ await expect(
+ fns.buildSecretApprovalCommits(
+ input({
+ data: {
+ [SecretOperations.Update]: [
+ { secretKey: "KEEP", newSecretName: "KEEP2" },
+ { secretKey: "GONE", newSecretName: "GONE2" }
+ ]
+ }
+ })
+ )
+ ).rejects.toEqual(expect.objectContaining({ name: "NotFound", message: "Secret does not exist: GONE" }));
+ });
+
test("upsert turns missing updates into creates without duplicating a key already being created", async () => {
const { fns } = buildFns();
diff --git a/backend/src/ee/services/secret-approval-request/secret-approval-request-commit-fns.ts b/backend/src/ee/services/secret-approval-request/secret-approval-request-commit-fns.ts
index a65d47cd27..bd2542ba3b 100644
--- a/backend/src/ee/services/secret-approval-request/secret-approval-request-commit-fns.ts
+++ b/backend/src/ee/services/secret-approval-request/secret-approval-request-commit-fns.ts
@@ -3,7 +3,7 @@ import { Knex } from "knex";
import { ActionProjectType, SecretType, TableName, TSecretApprovalRequestsSecretsV2Insert } from "@app/db/schemas";
import { BadRequestError, NotFoundError } from "@app/lib/errors";
-import { groupBy, unique } from "@app/lib/fn";
+import { diff, groupBy, unique } from "@app/lib/fn";
import { setKnexStringValue } from "@app/lib/knex";
import { ActorType } from "@app/services/auth/auth-type";
import { TKmsServiceFactory } from "@app/services/kms/kms-service";
@@ -328,7 +328,10 @@ export const secretApprovalRequestCommitFnsFactory = ({
if (secrets.length !== secretsWithNewName.length)
throw new NotFoundError({
- message: `Secret does not exist: ${secrets.map((el) => el.key).join(",")}`
+ message: `Secret does not exist: ${diff(
+ secretsWithNewName.map((el) => el.secretKey),
+ secrets.map((el) => el.key)
+ ).join(", ")}`
});
// the new name must not already be taken by another secret in the folder