Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
fix: lint, type and e2e test errors on access approval bridge
adilson36f8ee8c9667
diff --git a/backend/e2e-test/routes/v1/access-approval-global-request-lifecycle.spec.ts b/backend/e2e-test/routes/v1/access-approval-global-request-lifecycle.spec.tsindex 6dc8c492a2..4f84b8441a 100644--- a/backend/e2e-test/routes/v1/access-approval-global-request-lifecycle.spec.ts+++ b/backend/e2e-test/routes/v1/access-approval-global-request-lifecycle.spec.ts@@ -234,7 +234,7 @@ describe("Access approval request lifecycle on the global system", () => {expect(approved.policy.id).toBeNull();expect(approved.policy.deletedAt).toBeTruthy();expect(approved.policy.secretPath).toBe("/lifecycle-deleted-policy");- expect(approved.environment).toBe(seedData1.environment.slug);+ expect(approved.environmentName).toBe(seedData1.environment.slug);expect(approved.status).toBe("revoked");expect(approved.privilege).toBeNull();diff --git a/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.test.ts b/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.test.tsindex 9782c7b2a7..22ecc5da66 100644--- a/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.test.ts+++ b/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.test.ts@@ -474,7 +474,7 @@ describe("isPendingSecretAccessRequestItem", () => {const pendingItem = {policy: { deletedAt: null },status: ApprovalStatus.PENDING,- reviewers: [{ userId: "approver-a", status: ApprovalRequestApprovalDecision.Approved, isOrgMembershipActive: true }],+ reviewers: [{ status: ApprovalRequestApprovalDecision.Approved }],expiresAt: null};@@ -488,9 +488,7 @@ describe("isPendingSecretAccessRequestItem", () => {isPendingSecretAccessRequestItem({...pendingItem,- reviewers: [- { userId: "approver-a", status: ApprovalRequestApprovalDecision.Rejected, isOrgMembershipActive: true }- ]+ reviewers: [{ status: ApprovalRequestApprovalDecision.Rejected }]},now)diff --git a/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.ts b/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.tsindex c9aad69175..47151f0611 100644--- a/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.ts+++ b/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.ts@@ -491,7 +491,10 @@ export const composeSecretAccessRequestRows = ({};type TSecretAccessRequestComposedRow = ReturnType<typeof composeSecretAccessRequestRows>[number];-type TSecretAccessRequestListPolicy = Omit<NonNullable<TSecretAccessRequestComposedRow["policy"]>, "id" | "deletedAt"> & {+type TSecretAccessRequestListPolicy = Omit<+ NonNullable<TSecretAccessRequestComposedRow["policy"]>,+ "id" | "deletedAt"+> & {id: string | null;deletedAt: Date | null;};