Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix: remove the path and environment from request data

adilson37bb46c12c07
diff --git a/backend/src/db/migrations/20260930120000_approval-policy-secret-environments.ts b/backend/src/db/migrations/20260930120000_approval-policy-secret-environments.ts
index 1a8d310b77..44bea57e21 100644
--- a/backend/src/db/migrations/20260930120000_approval-policy-secret-environments.ts
+++ b/backend/src/db/migrations/20260930120000_approval-policy-secret-environments.ts
@@ -17,7 +17,7 @@ export async function up(knex: Knex): Promise<void> {
t.string("secretPath").notNullable();
t.timestamps(true, true, true);
- t.unique(["policyId", "envId"]);
+ t.unique(["policyId", "envId", "secretPath"]);
});
await createOnUpdateTrigger(knex, TableName.ApprovalPolicySecretEnvironment);
diff --git a/backend/src/services/approval-policy/secret-access/secret-access-policy-fns.test.ts b/backend/src/services/approval-policy/secret-access/secret-access-policy-fns.test.ts
index 2d463ac1b5..de2070524d 100644
--- a/backend/src/services/approval-policy/secret-access/secret-access-policy-fns.test.ts
+++ b/backend/src/services/approval-policy/secret-access/secret-access-policy-fns.test.ts
@@ -2,14 +2,12 @@ import {
getSecretAccessGrantWindow,
hasSameAccessCriteria,
isSecretAccessBreakGlassEligible,
+ parseSecretAccessRequestData,
validateSecretAccessConstraints
} from "./secret-access-policy-fns";
import { TSecretAccessRequestData } from "./secret-access-policy-types";
const storedRequest: TSecretAccessRequestData = {
- envId: "7b8f3a52-91c4-4d0e-9a6b-2f1c5e8d4a73",
- envSlug: "dev",
- secretPath: "/app",
permissions: [["read", "secrets", { environment: "dev", secretPath: { $glob: "/app" } }]],
isTemporary: false,
temporaryRange: null
diff --git a/backend/src/services/approval-policy/secret-access/secret-access-policy-schemas.ts b/backend/src/services/approval-policy/secret-access/secret-access-policy-schemas.ts
index bca2e003bb..beb81bbf08 100644
--- a/backend/src/services/approval-policy/secret-access/secret-access-policy-schemas.ts
+++ b/backend/src/services/approval-policy/secret-access/secret-access-policy-schemas.ts
@@ -11,19 +11,16 @@ export const SecretAccessPolicyConstraintsSchema = z.object({
});
export const SecretAccessPolicyRequestDataSchema = z.object({
- envId: z.string().uuid(),
- envSlug: z.string(),
- secretPath: z.string(),
permissions: z.unknown(),
isTemporary: z.boolean(),
temporaryRange: z.string().nullable()
});
-export const SecretAccessPolicyInputsSchema = SecretAccessPolicyRequestDataSchema.pick({
- envId: true,
- secretPath: true,
- permissions: true,
- isTemporary: true
+export const SecretAccessPolicyInputsSchema = z.object({
+ envId: z.string().uuid(),
+ secretPath: z.string(),
+ permissions: z.unknown(),
+ isTemporary: z.boolean()
});
export const SecretAccessPolicySchema = BaseApprovalPolicySchema.extend({
diff --git a/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-fns.test.ts b/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-fns.test.ts
index d9e484da9c..5f0fccefac 100644
--- a/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-fns.test.ts
+++ b/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-fns.test.ts
@@ -32,9 +32,6 @@ const updatedAt = new Date("2026-01-02T00:00:00.000Z");
const storedRequestData = (overrides: Partial<{ isTemporary: boolean; temporaryRange: string | null }> = {}) => ({
version: 1,
requestData: {
- envId: ENV_ID,
- envSlug: "dev",
- secretPath: "/app",
permissions: PERMISSIONS,
isTemporary: false,
temporaryRange: null,
diff --git a/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-fns.ts b/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-fns.ts
index 2b739331a0..dc440c03ee 100644
--- a/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-fns.ts
+++ b/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-fns.ts
@@ -125,13 +125,17 @@ export const notifySecretAccessStepApprovers = async (
request,
project,
requestedByUser,
- data
+ data,
+ environment,
+ secretPath
}: {
step: ApprovalPolicyStep;
request: TSecretAccessRequestRow;
project: { id: string; name: string; orgId: string };
requestedByUser: { firstName?: string | null; lastName?: string | null; email?: string | null };
data: TSecretAccessRequestData;
+ environment: { slug: string };
+ secretPath: string;
},
{
userDAL,
@@ -168,8 +172,8 @@ export const notifySecretAccessStepApprovers = async (
requesterFullName,
isTemporary: data.isTemporary,
requesterEmail: request.requesterEmail,
- secretPath: data.secretPath,
- environment: data.envSlug,
+ secretPath,
+ environment: environment.slug,
permissions: accessTypes,
approvalUrl,
note: request.justification ?? undefined
@@ -192,7 +196,7 @@ export const notifySecretAccessStepApprovers = async (
orgId: request.organizationId,
type: NotificationType.ACCESS_APPROVAL_REQUEST,
title: "Access Approval Request",
- body: `**${requesterFullName}** (${requestedByUser.email}) has requested ${data.isTemporary ? "temporary" : "permanent"} access to **${data.secretPath}** in the **${data.envSlug}** environment for project **${project.name}**.`,
+ body: `**${requesterFullName}** (${requestedByUser.email}) has requested ${data.isTemporary ? "temporary" : "permanent"} access to **${secretPath}** in the **${environment.slug}** environment for project **${project.name}**.`,
link: approvalPath
}))
);
@@ -208,8 +212,8 @@ export const notifySecretAccessStepApprovers = async (
requesterEmail: requestedByUser.email,
isTemporary: data.isTemporary,
...(data.isTemporary && data.temporaryRange && { expiresIn: msFn(ms(data.temporaryRange), { long: true }) }),
- secretPath: data.secretPath,
- environment: data.envSlug,
+ secretPath,
+ environment: environment.slug,
permissions: accessTypes,
approvalUrl,
note: request.justification ?? undefined
diff --git a/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-service.ts b/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-service.ts
index f02a698890..87696e3f33 100644
--- a/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-service.ts
+++ b/backend/src/services/secret-access-approval-request-bridge/secret-access-approval-request-bridge-service.ts
@@ -280,9 +280,6 @@ export const secretAccessApprovalRequestBridgeServiceFactory = ({
note
}: TCreateSecretAccessApprovalRequestDTO) => {
const requestData: TSecretAccessRequestData = {
- envId,
- envSlug,
- secretPath,
permissions,
isTemporary,
temporaryRange: temporaryRange || null
@@ -351,7 +348,15 @@ export const secretAccessApprovalRequestBridgeServiceFactory = ({
const request = await $findRequestById(created.id);
await notifySecretAccessStepApprovers(
- { step: policy.steps[0], request, project, requestedByUser, data: requestData },
+ {
+ step: policy.steps[0],
+ request,
+ project,
+ requestedByUser,
+ data: requestData,
+ environment: { slug: envSlug },
+ secretPath
+ },
{
userDAL,
userGroupMembershipDAL,
@@ -533,7 +538,7 @@ export const secretAccessApprovalRequestBridgeServiceFactory = ({
project,
policy,
actingUser,
- environmentName: policy.environment?.name ?? data.envSlug,
+ environmentName: policy.environment.name,
bypassReason: trimmedBypassReason
},
{ userDAL, userGroupMembershipDAL, notificationService, smtpService }
@@ -641,7 +646,15 @@ export const secretAccessApprovalRequestBridgeServiceFactory = ({
const requestedByUser = await userDAL.findById(request.requesterId);
if (requestedByUser) {
await notifySecretAccessStepApprovers(
- { step: nextStep, request, project, requestedByUser, data },
+ {
+ step: nextStep,
+ request,
+ project,
+ requestedByUser,
+ data,
+ environment: policy.environment,
+ secretPath: policy.secretPath
+ },
{
userDAL,
userGroupMembershipDAL,