Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
Minor fixes
Carlos Monastyrski490df0bb9751
diff --git a/backend/src/server/routes/v1/app-connection-routers/ultradns-connection-router.ts b/backend/src/server/routes/v1/app-connection-routers/ultradns-connection-router.tsindex 59792659e4..3e3d2f94e3 100644--- a/backend/src/server/routes/v1/app-connection-routers/ultradns-connection-router.ts+++ b/backend/src/server/routes/v1/app-connection-routers/ultradns-connection-router.ts@@ -30,18 +30,18 @@ export const registerUltraDNSConnectionRouter = async (server: FastifyZodProvideschema: {operationId: "listUltraDnsZones",params: z.object({- connectionId: z.string().uuid()+ connectionId: z.string().uuid().describe("The ID of the UltraDNS Connection to list zones from.")}),response: {200: z.object({- id: z.string(),- name: z.string()+ id: z.string().describe("The fully qualified name of the UltraDNS zone, used as its ID."),+ name: z.string().describe("The fully qualified name of the UltraDNS zone.")}).array()}},- onRequest: verifyAuth([AuthMode.JWT]),+ onRequest: verifyAuth([AuthMode.JWT, AuthMode.OAUTH]),handler: async (req) => {const { connectionId } = req.params;const zones = await server.services.appConnection.ultraDNS.listZones(connectionId, req.permission);diff --git a/backend/src/services/app-connection/ultradns/ultradns-connection-schema.ts b/backend/src/services/app-connection/ultradns/ultradns-connection-schema.tsindex 6932a5927b..b1cd09347c 100644--- a/backend/src/services/app-connection/ultradns/ultradns-connection-schema.ts+++ b/backend/src/services/app-connection/ultradns/ultradns-connection-schema.ts@@ -12,9 +12,23 @@ import { APP_CONNECTION_NAME_MAP } from "../app-connection-maps";import { UltraDNSConnectionMethod, UltraDNSEnvironment } from "./ultradns-connection-enum";export const UltraDNSConnectionUsernamePasswordCredentialsSchema = z.object({- username: z.string().trim().min(1, "Username required").max(256, "Username cannot exceed 256 characters"),- password: z.string().trim().min(1, "Password required").max(256, "Password cannot exceed 256 characters"),- environment: z.nativeEnum(UltraDNSEnvironment)+ username: z+ .string()+ .trim()+ .min(1, "Username required")+ .max(256, "Username cannot exceed 256 characters")+ .describe("The username of the UltraDNS user. The user can't have Two Factor Mobile Authentication enabled."),+ password: z+ .string()+ .trim()+ .min(1, "Password required")+ .max(256, "Password cannot exceed 256 characters")+ .describe("The password of the UltraDNS user."),+ environment: z+ .nativeEnum(UltraDNSEnvironment)+ .describe(+ "The UltraDNS API to connect to: production (api.ultradns.com) or test (the UltraDNS customer test environment at test-api.ultradns.com)."+ )});const BaseUltraDNSConnectionSchema = BaseAppConnectionSchema.extend({diff --git a/backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.ts b/backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.tsindex 2444010e6e..7d87c02902 100644--- a/backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.ts+++ b/backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.ts@@ -537,7 +537,8 @@ export const executeAcmeOrder = async (connection as TUltraDNSConnection,acmeCa.configuration.dnsProviderConfig.hostedZoneId,recordName,- recordValue+ recordValue,+ { keyStore });break;}@@ -616,7 +617,8 @@ export const executeAcmeOrder = async (connection as TUltraDNSConnection,acmeCa.configuration.dnsProviderConfig.hostedZoneId,recordName,- recordValue+ recordValue,+ { keyStore });break;}diff --git a/backend/src/services/certificate-authority/acme/dns-providers/dns-record-lock.ts b/backend/src/services/certificate-authority/acme/dns-providers/dns-record-lock.tsnew file mode 100644index 0000000000..cf6ce258b8--- /dev/null+++ b/backend/src/services/certificate-authority/acme/dns-providers/dns-record-lock.ts@@ -0,0 +1,34 @@+import { KeyStorePrefixes, TKeyStoreFactory } from "@app/keystore/keystore";+import { logger } from "@app/lib/logger";++const DNS_RECORD_LOCK_RETRY = { retryCount: 50, retryDelay: 2_000, retryJitter: 300 };++export const withDnsRecordLock = async <T>(+ {+ providerName,+ connectionId,+ zoneId,+ name,+ lockTtlMs+ }: { providerName: string; connectionId: string; zoneId: string; name: string; lockTtlMs: number },+ keyStore: Pick<TKeyStoreFactory, "acquireLock">,+ operation: () => Promise<T>+): Promise<T> => {+ const lock = await keyStore+ .acquireLock([KeyStorePrefixes.AcmeDnsRecordLock(connectionId, zoneId, name)], lockTtlMs, DNS_RECORD_LOCK_RETRY)+ .catch(() => null);++ if (!lock) {+ throw new Error(+ `Timed out waiting to update the ${providerName} record '${name}'. Another certificate order is still using it.`+ );+ }++ try {+ return await operation();+ } finally {+ await lock.release().catch((error) => {+ logger.warn(error, `Failed to release ${providerName} record lock [zoneId=${zoneId}] [name=${name}]`);+ });+ }+};diff --git a/backend/src/services/certificate-authority/acme/dns-providers/powerdns.ts b/backend/src/services/certificate-authority/acme/dns-providers/powerdns.tsindex 96585e6951..1d54c2425b 100644--- a/backend/src/services/certificate-authority/acme/dns-providers/powerdns.ts+++ b/backend/src/services/certificate-authority/acme/dns-providers/powerdns.ts@@ -1,4 +1,4 @@-import { KeyStorePrefixes, TKeyStoreFactory } from "@app/keystore/keystore";+import { TKeyStoreFactory } from "@app/keystore/keystore";import { logger } from "@app/lib/logger";import {getPowerDnsZoneRrset,@@ -11,73 +11,25 @@ import {TPowerDnsConnectionConfig} from "@app/services/app-connection/powerdns/powerdns-connection-types";+import { withDnsRecordLock } from "./dns-record-lock";+const ACME_CHALLENGE_TTL_SECONDS = 60;const RRSET_LOCK_TTL_MS = POWERDNS_REQUEST_TIMEOUT_MS * 2 + 30_000;-const RRSET_LOCK_RETRY = { retryCount: 50, retryDelay: 2_000, retryJitter: 300 };export type TPowerDnsProviderDeps = TPowerDnsGatewayDeps & {- keyStore?: Pick<TKeyStoreFactory, "acquireLock">;+ keyStore: Pick<TKeyStoreFactory, "acquireLock">;};const toFqdn = (name: string) => (name.endsWith(".") ? name : `${name}.`);const toConnectionConfig = (connection: TPowerDnsConnection) => connection as unknown as TPowerDnsConnectionConfig;-const pendingRrsetOperations = new Map<string, Promise<void>>();--const withLocalRrsetLock = async <T>(key: string, operation: () => Promise<T>): Promise<T> => {- const pending = pendingRrsetOperations.get(key) ?? Promise.resolve();- const result = pending.then(operation, operation);- const settled = result.then(- () => undefined,- () => undefined- );-- pendingRrsetOperations.set(key, settled);- void settled.then(() => {- if (pendingRrsetOperations.get(key) === settled) pendingRrsetOperations.delete(key);- });-- return result;-};--const withRrsetLock = async <T>(- { connectionId, zoneId, name }: { connectionId: string; zoneId: string; name: string },- keyStore: Pick<TKeyStoreFactory, "acquireLock"> | undefined,- operation: () => Promise<T>-): Promise<T> =>- withLocalRrsetLock(`${connectionId}|${zoneId}|${name}`, async () => {- if (!keyStore) return operation();-- const lock = await keyStore- .acquireLock(- [KeyStorePrefixes.AcmeDnsRecordLock(connectionId, zoneId, name)],- RRSET_LOCK_TTL_MS,- RRSET_LOCK_RETRY- )- .catch(() => null);-- if (!lock) {- throw new Error(- `Timed out waiting to update the PowerDNS record '${name}'. Another certificate order is still using it.`- );- }-- try {- return await operation();- } finally {- await lock.release().catch((error) => {- logger.warn(error, `Failed to release PowerDNS record lock [zoneId=${zoneId}] [name=${name}]`);- });- }- });-export const powerDnsInsertTxtRecord = async (connection: TPowerDnsConnection,hostedZoneId: string,domain: string,value: string,- deps: TPowerDnsProviderDeps = {}+ deps: TPowerDnsProviderDeps) => {const { keyStore, ...gatewayDeps } = deps;const config = toConnectionConfig(connection);@@ -86,29 +38,33 @@ export const powerDnsInsertTxtRecord = async (logger.info({ zoneId, name }, `Inserting TXT record for PowerDNS [zoneId=${zoneId}] [name=${name}]`);- await withRrsetLock({ connectionId: connection.id, zoneId, name }, keyStore, async () => {- const existing = await getPowerDnsZoneRrset(config, { zoneId, name, type: "TXT" }, gatewayDeps);- const existingRecords = existing?.records ?? [];-- if (existingRecords.some((record) => record.content === value)) return;-- await patchPowerDnsZoneRrsets(- config,- {- zoneId,- rrsets: [- {- name,- type: "TXT",- ttl: ACME_CHALLENGE_TTL_SECONDS,- changetype: "REPLACE",- records: [...existingRecords, { content: value, disabled: false }]- }- ]- },- gatewayDeps- );- });+ await withDnsRecordLock(+ { providerName: "PowerDNS", connectionId: connection.id, zoneId, name, lockTtlMs: RRSET_LOCK_TTL_MS },+ keyStore,+ async () => {+ const existing = await getPowerDnsZoneRrset(config, { zoneId, name, type: "TXT" }, gatewayDeps);+ const existingRecords = existing?.records ?? [];++ if (existingRecords.some((record) => record.content === value)) return;++ await patchPowerDnsZoneRrsets(+ config,+ {+ zoneId,+ rrsets: [+ {+ name,+ type: "TXT",+ ttl: ACME_CHALLENGE_TTL_SECONDS,+ changetype: "REPLACE",+ records: [...existingRecords, { content: value, disabled: false }]+ }+ ]+ },+ gatewayDeps+ );+ }+ );};export const powerDnsDeleteTxtRecord = async (@@ -116,7 +72,7 @@ export const powerDnsDeleteTxtRecord = async (hostedZoneId: string,domain: string,value: string,- deps: TPowerDnsProviderDeps = {}+ deps: TPowerDnsProviderDeps) => {const { keyStore, ...gatewayDeps } = deps;const config = toConnectionConfig(connection);@@ -125,33 +81,37 @@ export const powerDnsDeleteTxtRecord = async (logger.info({ zoneId, name }, `Deleting TXT record for PowerDNS [zoneId=${zoneId}] [name=${name}]`);- await withRrsetLock({ connectionId: connection.id, zoneId, name }, keyStore, async () => {- const existing = await getPowerDnsZoneRrset(config, { zoneId, name, type: "TXT" }, gatewayDeps);- const existingRecords = existing?.records ?? [];- const remainingRecords = existingRecords.filter((record) => record.content !== value);-- if (remainingRecords.length === existingRecords.length) {- logger.warn({ zoneId, name }, `PowerDNS TXT record to delete not found [zoneId=${zoneId}] [name=${name}]`);- return;+ await withDnsRecordLock(+ { providerName: "PowerDNS", connectionId: connection.id, zoneId, name, lockTtlMs: RRSET_LOCK_TTL_MS },+ keyStore,+ async () => {+ const existing = await getPowerDnsZoneRrset(config, { zoneId, name, type: "TXT" }, gatewayDeps);+ const existingRecords = existing?.records ?? [];+ const remainingRecords = existingRecords.filter((record) => record.content !== value);++ if (remainingRecords.length === existingRecords.length) {+ logger.warn({ zoneId, name }, `PowerDNS TXT record to delete not found [zoneId=${zoneId}] [name=${name}]`);+ return;+ }++ await patchPowerDnsZoneRrsets(+ config,+ {+ zoneId,+ rrsets: remainingRecords.length+ ? [+ {+ name,+ type: "TXT",+ ttl: existing?.ttl ?? ACME_CHALLENGE_TTL_SECONDS,+ changetype: "REPLACE",+ records: remainingRecords+ }+ ]+ : [{ name, type: "TXT", changetype: "DELETE" }]+ },+ gatewayDeps+ );}-- await patchPowerDnsZoneRrsets(- config,- {- zoneId,- rrsets: remainingRecords.length- ? [- {- name,- type: "TXT",- ttl: existing?.ttl ?? ACME_CHALLENGE_TTL_SECONDS,- changetype: "REPLACE",- records: remainingRecords- }- ]- : [{ name, type: "TXT", changetype: "DELETE" }]- },- gatewayDeps- );- });+ );};diff --git a/backend/src/services/certificate-authority/acme/dns-providers/ultradns.ts b/backend/src/services/certificate-authority/acme/dns-providers/ultradns.tsindex 62140dd1f1..751fb13311 100644--- a/backend/src/services/certificate-authority/acme/dns-providers/ultradns.ts+++ b/backend/src/services/certificate-authority/acme/dns-providers/ultradns.ts@@ -2,6 +2,7 @@import { isAxiosError } from "axios";+import { TKeyStoreFactory } from "@app/keystore/keystore";import { request } from "@app/lib/config/request";import { delay } from "@app/lib/delay";import { logger } from "@app/lib/logger";@@ -13,10 +14,18 @@ import {} from "@app/services/app-connection/ultradns/ultradns-connection-fns";import { TUltraDNSConnection } from "@app/services/app-connection/ultradns/ultradns-connection-types";+import { withDnsRecordLock } from "./dns-record-lock";+const TXT_RECORD_TTL = 60;const MAX_WRITE_ATTEMPTS = 3;const WRITE_RETRY_DELAY_MS = 3000;const APPLY_PENDING_STATUS = 202;+const NON_RETRYABLE_WRITE_STATUSES = [401, 403, 404];+const RECORD_LOCK_TTL_MS = 120_000;++export type TUltraDNSProviderDeps = {+ keyStore: Pick<TKeyStoreFactory, "acquireLock">;+};const toFullyQualifiedName = (name: string) => (name.endsWith(".") ? name : `${name}.`);@@ -85,6 +94,7 @@ const applyToTxtRecordSet = async (hasWritten = true;shouldWaitBeforeRetry = status === APPLY_PENDING_STATUS;} catch (error) {+ if (isAxiosError(error) && NON_RETRYABLE_WRITE_STATUSES.includes(error.response?.status ?? 0)) throw error;lastWriteError = error instanceof Error ? error : new Error(String(error));shouldWaitBeforeRetry = true;}@@ -100,29 +110,41 @@ export const ultraDNSInsertTxtRecord = async (connection: TUltraDNSConnection,zoneName: string,recordName: string,- value: string+ value: string,+ { keyStore }: TUltraDNSProviderDeps) => {const {credentials: { username, password, environment }} = connection;+ const zoneId = toFullyQualifiedName(zoneName);+ const name = toFullyQualifiedName(recordName);try {- const accessToken = await getUltraDNSAccessToken(environment, username, password);- const { isConfirmed, lastWriteError } = await applyToTxtRecordSet(- getTxtRrSetUrl(environment, zoneName, recordName),- accessToken,- (currentValues) =>- currentValues.some((current) => unquote(current) === unquote(value)) ? null : [...currentValues, value]+ await withDnsRecordLock(+ { providerName: "UltraDNS", connectionId: connection.id, zoneId, name, lockTtlMs: RECORD_LOCK_TTL_MS },+ keyStore,+ async () => {+ const accessToken = await getUltraDNSAccessToken(environment, username, password);+ const { isConfirmed, lastWriteError } = await applyToTxtRecordSet(+ getTxtRrSetUrl(environment, zoneId, name),+ accessToken,+ (currentValues) =>+ currentValues.some((current) => unquote(current) === unquote(value)) ? null : [...currentValues, value]+ );++ if (!isConfirmed) {+ logger.warn(+ { zoneName: zoneId, recordName: name, err: lastWriteError },+ "UltraDNS has not confirmed the ACME challenge TXT record as published"+ );+ }+ });-- if (!isConfirmed) {- logger.warn(- { zoneName, recordName, err: lastWriteError },- "UltraDNS has not confirmed the ACME challenge TXT record as published"- );- }} catch (error) {- throw new Error(getUltraDNSErrorMessage(error));+ throw new Error(+ `Failed to create UltraDNS TXT record '${name}' in zone '${zoneId}': ${getUltraDNSErrorMessage(error)}`,+ { cause: error }+ );}};@@ -130,30 +152,42 @@ export const ultraDNSDeleteTxtRecord = async (connection: TUltraDNSConnection,zoneName: string,recordName: string,- value: string+ value: string,+ { keyStore }: TUltraDNSProviderDeps) => {const {credentials: { username, password, environment }} = connection;+ const zoneId = toFullyQualifiedName(zoneName);+ const name = toFullyQualifiedName(recordName);try {- const accessToken = await getUltraDNSAccessToken(environment, username, password);- const { isConfirmed, lastWriteError } = await applyToTxtRecordSet(- getTxtRrSetUrl(environment, zoneName, recordName),- accessToken,- (currentValues) => {- const remainingValues = currentValues.filter((current) => unquote(current) !== unquote(value));- return remainingValues.length === currentValues.length ? null : remainingValues;+ await withDnsRecordLock(+ { providerName: "UltraDNS", connectionId: connection.id, zoneId, name, lockTtlMs: RECORD_LOCK_TTL_MS },+ keyStore,+ async () => {+ const accessToken = await getUltraDNSAccessToken(environment, username, password);+ const { isConfirmed, lastWriteError } = await applyToTxtRecordSet(+ getTxtRrSetUrl(environment, zoneId, name),+ accessToken,+ (currentValues) => {+ const remainingValues = currentValues.filter((current) => unquote(current) !== unquote(value));+ return remainingValues.length === currentValues.length ? null : remainingValues;+ }+ );++ if (!isConfirmed) {+ logger.warn(+ { zoneName: zoneId, recordName: name, err: lastWriteError },+ "Could not remove the UltraDNS TXT record for the ACME challenge"+ );+ }});-- if (!isConfirmed) {- logger.warn(- { zoneName, recordName, err: lastWriteError },- "Could not remove the UltraDNS TXT record for the ACME challenge"- );- }} catch (error) {- throw new Error(getUltraDNSErrorMessage(error));+ throw new Error(+ `Failed to delete UltraDNS TXT record '${name}' in zone '${zoneId}': ${getUltraDNSErrorMessage(error)}`,+ { cause: error }+ );}};diff --git a/docs/api-reference/endpoints/app-connections/ultradns/available.mdx b/docs/api-reference/endpoints/app-connections/ultradns/available.mdxnew file mode 100644index 0000000000..82ced30e40--- /dev/null+++ b/docs/api-reference/endpoints/app-connections/ultradns/available.mdx@@ -0,0 +1,4 @@+---+title: "Available"+openapi: "GET /api/v1/app-connections/ultradns/available"+---diff --git a/docs/api-reference/endpoints/app-connections/ultradns/create.mdx b/docs/api-reference/endpoints/app-connections/ultradns/create.mdxnew file mode 100644index 0000000000..85e55c224e--- /dev/null+++ b/docs/api-reference/endpoints/app-connections/ultradns/create.mdx@@ -0,0 +1,10 @@+---+title: "Create"+openapi: "POST /api/v1/app-connections/ultradns"+---++<Note>+ Check out the configuration docs for [UltraDNS+ Connections](/integrations/app-connections/ultradns) to learn how to obtain the required+ credentials.+</Note>diff --git a/docs/api-reference/endpoints/app-connections/ultradns/delete.mdx b/docs/api-reference/endpoints/app-connections/ultradns/delete.mdxnew file mode 100644index 0000000000..89319fb7b6--- /dev/null+++ b/docs/api-reference/endpoints/app-connections/ultradns/delete.mdx@@ -0,0 +1,4 @@+---+title: "Delete"+openapi: "DELETE /api/v1/app-connections/ultradns/{connectionId}"+---diff --git a/docs/api-reference/endpoints/app-connections/ultradns/get-by-id.mdx b/docs/api-reference/endpoints/app-connections/ultradns/get-by-id.mdxnew file mode 100644index 0000000000..b80be3e96a--- /dev/null+++ b/docs/api-reference/endpoints/app-connections/ultradns/get-by-id.mdx@@ -0,0 +1,4 @@+---+title: "Get by ID"+openapi: "GET /api/v1/app-connections/ultradns/{connectionId}"+---diff --git a/docs/api-reference/endpoints/app-connections/ultradns/get-by-name.mdx b/docs/api-reference/endpoints/app-connections/ultradns/get-by-name.mdxnew file mode 100644index 0000000000..7227bce0e0--- /dev/null+++ b/docs/api-reference/endpoints/app-connections/ultradns/get-by-name.mdx@@ -0,0 +1,4 @@+---+title: "Get by name"+openapi: "GET /api/v1/app-connections/ultradns/connection-name/{connectionName}"+---diff --git a/docs/api-reference/endpoints/app-connections/ultradns/list.mdx b/docs/api-reference/endpoints/app-connections/ultradns/list.mdxnew file mode 100644index 0000000000..d40e4f6cc1--- /dev/null+++ b/docs/api-reference/endpoints/app-connections/ultradns/list.mdx@@ -0,0 +1,4 @@+---+title: "List"+openapi: "GET /api/v1/app-connections/ultradns"+---diff --git a/docs/api-reference/endpoints/app-connections/ultradns/update.mdx b/docs/api-reference/endpoints/app-connections/ultradns/update.mdxnew file mode 100644index 0000000000..f023f8b757--- /dev/null+++ b/docs/api-reference/endpoints/app-connections/ultradns/update.mdx@@ -0,0 +1,10 @@+---+title: "Update"+openapi: "PATCH /api/v1/app-connections/ultradns/{connectionId}"+---++<Note>+ Check out the configuration docs for [UltraDNS+ Connections](/integrations/app-connections/ultradns) to learn how to obtain the required+ credentials.+</Note>diff --git a/docs/docs.json b/docs/docs.jsonindex 06b4d4db10..d283abfab4 100644--- a/docs/docs.json+++ b/docs/docs.json@@ -2466,6 +2466,18 @@"api-reference/endpoints/app-connections/travis-ci/create"]},+ {+ "group": "UltraDNS",+ "pages": [+ "api-reference/endpoints/app-connections/ultradns/list",+ "api-reference/endpoints/app-connections/ultradns/available",+ "api-reference/endpoints/app-connections/ultradns/get-by-id",+ "api-reference/endpoints/app-connections/ultradns/get-by-name",+ "api-reference/endpoints/app-connections/ultradns/create",+ "api-reference/endpoints/app-connections/ultradns/update",+ "api-reference/endpoints/app-connections/ultradns/delete"+ ]+ },{"group": "Venafi","pages": [diff --git a/docs/documentation/platform/pki/ca/acme-ca.mdx b/docs/documentation/platform/pki/ca/acme-ca.mdxindex a3a22f1fdf..56d062f48a 100644--- a/docs/documentation/platform/pki/ca/acme-ca.mdx+++ b/docs/documentation/platform/pki/ca/acme-ca.mdx@@ -142,7 +142,7 @@ In the following steps, we explore how to connect Infisical to an ACME-compatibl<Tab title="UltraDNS">1. In **Certificate Manager**, go to **Settings → App Connections** and create a new UltraDNS connection.- 2. Ensure the UltraDNS user can read zones and manage resource records in the zone you want to use for validation. Only primary zones can be used, since secondary zones cannot accept record changes.+ 2. Ensure the UltraDNS user can read zones and manage resource records in the zone you want to use for validation. Only primary zones can be used, since secondary zones can't accept record changes.<Note>For UltraDNS the zone is identified by its fully qualified name, such as `example.com.`, rather thandiff --git a/docs/integrations/app-connections/ultradns.mdx b/docs/integrations/app-connections/ultradns.mdxindex e8c96a66c9..5e84e6b7de 100644--- a/docs/integrations/app-connections/ultradns.mdx+++ b/docs/integrations/app-connections/ultradns.mdx@@ -1,5 +1,6 @@----title: "UltraDNS"+title: "UltraDNS connection"+sidebarTitle: "UltraDNS"description: "Learn how to configure an UltraDNS Connection for Infisical."---@@ -15,17 +16,15 @@ Infisical connects to UltraDNS with the username and password of an UltraDNS use<Steps><Step title="Create a user for Infisical">Sign in to the [UltraDNS Portal](https://portal.ultradns.com) and go to **Account → Users**, then add a user- that Infisical will authenticate as. A dedicated user keeps the access auditable and lets you revoke it without- affecting anyone else.+ that Infisical will authenticate as. You can then revoke its access without affecting anyone else.</Step><Step title="Grant zone and record permissions">Assign the user a role that can read zones and read, create, update, and delete resource records in the zones youwant Infisical to manage. For ACME certificate issuance, Infisical writes a TXT record at`_acme-challenge.<your-domain>` and removes it once the certificate authority has validated the domain.</Step>- <Step title="Confirm REST API access">- Verify the user can sign in, and that Two Factor Mobile Authentication isn't enabled for it. Only zones of type- **Primary** are available to Infisical, because secondary zones can't accept record changes.+ <Step title="Confirm the zone type">+ Only zones of type **Primary** are available to Infisical, because secondary zones can't accept record changes.</Step></Steps>@@ -33,7 +32,7 @@ Infisical connects to UltraDNS with the username and password of an UltraDNS use<Steps><Step title="Navigate to App Connections">- Navigate to the **Integrations** tab in the desired project, then select **App Connections**.+ In **Certificate Manager**, go to **Settings → App Connections**.</Step><Step title="Add Connection">@@ -48,10 +47,10 @@ Infisical connects to UltraDNS with the username and password of an UltraDNS usevalid against the one its credentials belong to.<Warning>- Keep these credentials secure and do not share them. Anyone with access to them can manage your UltraDNS records.+ Keep these credentials secure and don't share them. Anyone with access to them can manage your UltraDNS records.</Warning></Step><Step title="Connection Created">- Your **UltraDNS Connection** is now available for use in your Infisical projects.+ Your **UltraDNS Connection** is now available for use in Certificate Manager.</Step></Steps>diff --git a/frontend/src/pages/cert-manager/CertificateAuthoritiesPage/components/ExternalCaFields/AcmeFields.tsx b/frontend/src/pages/cert-manager/CertificateAuthoritiesPage/components/ExternalCaFields/AcmeFields.tsxindex 29f6bb9bd8..91d5454881 100644--- a/frontend/src/pages/cert-manager/CertificateAuthoritiesPage/components/ExternalCaFields/AcmeFields.tsx+++ b/frontend/src/pages/cert-manager/CertificateAuthoritiesPage/components/ExternalCaFields/AcmeFields.tsx@@ -125,7 +125,9 @@ export const AcmeFields = ({control={control}render={({ field: { value, onChange }, fieldState: { error } }) => (<Field className="mb-4">- <FieldLabel>Zone</FieldLabel>+ <FieldLabel>+ Zone <span className="text-danger">*</span>+ </FieldLabel><FilterableSelectisLoading={isZonesPending && !!dnsAppConnection.id}isDisabled={!dnsAppConnection.id}diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/UltraDNSConnectionForm.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/UltraDNSConnectionForm.tsxindex 3a7df1d117..b33e086576 100644--- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/UltraDNSConnectionForm.tsx+++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/UltraDNSConnectionForm.tsx@@ -5,6 +5,7 @@ import { z } from "zod";import {Field,+ FieldDescription,FieldError,FieldLabel,Input,@@ -119,6 +120,10 @@ export const UltraDNSConnectionForm = ({ appConnection, onSubmit }: Props) => {render={({ field: { value, onChange }, fieldState: { error } }) => (<Field className="mb-4"><FieldLabel htmlFor="username">Username</FieldLabel>+ <FieldDescription>+ An UltraDNS user without Two Factor Mobile Authentication, which the UltraDNS REST+ API doesn't support.+ </FieldDescription><Inputid="username"value={value}@@ -137,8 +142,14 @@ export const UltraDNSConnectionForm = ({ appConnection, onSubmit }: Props) => {render={({ field: { value, onChange }, fieldState: { error } }) => (<Field className="mb-4"><FieldLabel htmlFor="password">Password</FieldLabel>- <SecretInput value={value} onChange={(e) => onChange(e.target.value)} />- <FieldError errors={[error]} />+ <SecretInput+ aria-describedby={error ? "password-error" : undefined}+ isError={Boolean(error)}+ id="password"+ value={value}+ onChange={(e) => onChange(e.target.value)}+ />+ <FieldError id="password-error" errors={[error]} /></Field>)}/>