Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix url

Matheus Nogueira505c3d956147
diff --git a/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.test.ts b/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.test.ts
index 5a6e949066..bd70cb8f55 100644
--- a/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.test.ts
+++ b/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.test.ts
@@ -90,7 +90,10 @@ describe("getPullRequestScanCheckRunResult", () => {
...finding,
id: "0a1b2c3d-0000-4000-8000-000000000000",
status: SecretScanningFindingStatus.Unresolved,
- details: { ...(finding.details as object), link: "https://github.com/acme/api/blob/abc123/my file.go#L1" }
+ details: {
+ ...(finding.details as object),
+ link: "https://github.com/acme/api/blob/abc123/my dir/config|0.ts#L1"
+ }
},
makeFinding(1)
],
@@ -102,7 +105,7 @@ describe("getPullRequestScanCheckRunResult", () => {
expect(result.conclusion).toBe("failure");
expect(result.title).toBe("2 secret(s) found");
expect(result.summary).toContain(
- "| [0a1b2c3d](https://app.infisical.com/organizations/org/secret-scanning/findings?resourceId=r) | Unresolved | github-pat | abc123d | config\\|0.ts:1 | [View secret](https://github.com/acme/api/blob/abc123/my%20file.go#L1) |"
+ "| [0a1b2c3d](https://app.infisical.com/organizations/org/secret-scanning/findings?resourceId=r) | Unresolved | github-pat | abc123d | config\\|0.ts:1 | [View secret](https://github.com/acme/api/blob/abc123/my%20dir/config%7C0.ts#L1) |"
);
expect(result.summary).not.toContain(SECRET_VALUE);
});
diff --git a/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.ts b/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.ts
index 7efa24c6b0..67bba92a75 100644
--- a/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.ts
+++ b/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.ts
@@ -586,7 +586,9 @@ const toCheckRunAnnotations = (findings: TFindingsPayload) =>
const escapeMarkdownTableCell = (value: string) => value.replace(/\|/g, "\\|").replace(/\r?\n/g, " ");
-const toMarkdownUrl = (url: string) => url.replace(/ /g, "%20").replace(/\(/g, "%28").replace(/\)/g, "%29");
+// GitHub splits table cells on "|" even inside a link, so it is encoded along with the characters that end a link.
+const toMarkdownUrl = (url: string) =>
+ url.replace(/ /g, "%20").replace(/\(/g, "%28").replace(/\)/g, "%29").replace(/\|/g, "%7C");
const toStatusLabel = (status?: string | null) =>
(status ?? SecretScanningFindingStatus.Unresolved)