Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix(insights): draw readers who have the value only through a group

Dimitris Staratzis5185be440a47
diff --git a/backend/src/ee/routes/v1/secret-router.ts b/backend/src/ee/routes/v1/secret-router.ts
index f9b55ca868..e68b3c3f45 100644
--- a/backend/src/ee/routes/v1/secret-router.ts
+++ b/backend/src/ee/routes/v1/secret-router.ts
@@ -132,6 +132,7 @@ export const registerSecretRouter = async (server: FastifyZodProvider) => {
.enum([ActorType.USER, ActorType.IDENTITY])
.describe(RAW_SECRETS.GET_READ_ACTIVITY.actorType),
actorId: z.string().describe(RAW_SECRETS.GET_READ_ACTIVITY.actorId),
+ actorName: z.string().nullable().describe(RAW_SECRETS.GET_READ_ACTIVITY.readerName),
unread: z.boolean().describe(RAW_SECRETS.GET_READ_ACTIVITY.unread),
isAdmin: z.boolean().describe(RAW_SECRETS.GET_READ_ACTIVITY.isAdmin),
accessChangedAt: z.date().nullable().describe(RAW_SECRETS.GET_READ_ACTIVITY.accessChangedAt)
diff --git a/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts b/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts
index 11ab6c165f..9e8a94b82f 100644
--- a/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts
+++ b/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts
@@ -414,11 +414,16 @@ export const secretReadActivityServiceFactory = ({
const { entitled, exposedTo, unread, ghostReaders, exposure } = summarize(activity);
const unreadKeys = new Set(unread.map((reader) => `${reader.actorType}:${reader.id}`));
- // A ghost reader may have left the project or been deleted since, so names the project's members do not
- // give are looked up directly; a reader deleted outright has none.
- const unnamed = ghostReaders.filter((read) => !actorNames.has(`${read.actorType}:${read.actorId}`));
- const idsOf = (actorType: TSecretReaderType) =>
- unnamed.filter((read) => read.actorType === actorType).map((read) => read.actorId);
+ // A ghost reader may have left the project or been deleted since, and a reader who has the value through a
+ // group is not among the direct members, so names the members do not give are looked up directly; a reader
+ // deleted outright has none.
+ const unnamed = [
+ ...ghostReaders,
+ ...entitled.map((reader) => ({ actorType: reader.actorType, actorId: reader.id }))
+ ].filter((read) => !actorNames.has(`${read.actorType}:${read.actorId}`));
+ const idsOf = (actorType: TSecretReaderType) => [
+ ...new Set(unnamed.filter((read) => read.actorType === actorType).map((read) => read.actorId))
+ ];
const [userIds, identityIds] = [idsOf(ActorType.USER), idsOf(ActorType.IDENTITY)];
const [users, identities] = await Promise.all([
userIds.length ? userDAL.find({ $in: { id: userIds } }) : [],
@@ -435,6 +440,7 @@ export const secretReadActivityServiceFactory = ({
(reader): TEntitledReader => ({
actorType: reader.actorType,
actorId: reader.id,
+ actorName: actorNames.get(`${reader.actorType}:${reader.id}`) ?? null,
unread: unreadKeys.has(`${reader.actorType}:${reader.id}`),
isAdmin: adminActorIds.has(reader.id),
accessChangedAt: accessChangedAtByActorId.get(reader.id) ?? null
diff --git a/backend/src/ee/services/secret-read-activity/secret-read-activity-types.ts b/backend/src/ee/services/secret-read-activity/secret-read-activity-types.ts
index 322326b630..df2ec3065f 100644
--- a/backend/src/ee/services/secret-read-activity/secret-read-activity-types.ts
+++ b/backend/src/ee/services/secret-read-activity/secret-read-activity-types.ts
@@ -139,6 +139,7 @@ export type TExposedSecret = TSecretExposureCounts & {
export type TEntitledReader = {
actorType: TSecretReaderType;
actorId: string;
+ actorName: string | null;
unread: boolean;
isAdmin: boolean;
accessChangedAt: Date | null;
diff --git a/backend/src/lib/api-docs/constants.ts b/backend/src/lib/api-docs/constants.ts
index 021440bef4..78593e351d 100644
--- a/backend/src/lib/api-docs/constants.ts
+++ b/backend/src/lib/api-docs/constants.ts
@@ -1504,6 +1504,7 @@ export const RAW_SECRETS = {
"The start of the period unused access is judged on: the later of 30 days ago and when read tracking began for the project. A reader only counts as unused access once the secret and their access both predate it.",
entitled:
"One entry for each user or machine identity that can read the secret's value today, project admins included so their reads can be shown, saying whether they count as unused access and, if not, why.",
+ readerName: "The username of the user, or the name of the machine identity. Null when it could not be resolved.",
unread:
"Whether the reader counts as unused access: no read since trackedSince, with the secret and their access both older than judgedFrom.",
isAdmin:
diff --git a/frontend/src/hooks/api/secrets/types.ts b/frontend/src/hooks/api/secrets/types.ts
index d3b02f8000..64b386e40a 100644
--- a/frontend/src/hooks/api/secrets/types.ts
+++ b/frontend/src/hooks/api/secrets/types.ts
@@ -176,6 +176,7 @@ export type TSecretReadActivity = TSecretExposureCounts & {
entitled: {
actorType: "user" | "identity";
actorId: string;
+ actorName: string | null;
unread: boolean;
isAdmin: boolean;
accessChangedAt: string | null;
diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretAccessInsights.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretAccessInsights.tsx
index 5660f9203d..f67f8e8347 100644
--- a/frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretAccessInsights.tsx
+++ b/frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretAccessInsights.tsx
@@ -588,12 +588,38 @@ export function SecretAccessInsights({
}
];
};
- const readers = [
+ const directReaders = [
...secretAccessList.users.flatMap((user) => toReader(user, "user", "userIds")),
...secretAccessList.identities.flatMap((identity) =>
toReader(identity, "identity", "identityIds")
)
];
+ // Members who have the value only through a group are not in the access list's users or identities, but
+ // the read activity names everyone who can read the value, so they are drawn from it.
+ const listed = new Set([
+ ...secretAccessList.users.map((user) => `user:${user.id}`),
+ ...secretAccessList.identities.map((identity) => `identity:${identity.id}`)
+ ]);
+ const groupOnlyReaders = (readActivity?.entitled ?? []).flatMap((reader) => {
+ if (reader.isAdmin || listed.has(`${reader.actorType}:${reader.actorId}`)) return [];
+ const memberField = reader.actorType === "user" ? "userIds" : "identityIds";
+ const groupIds = groups
+ .filter((group) => group[memberField].includes(reader.actorId))
+ .map((group) => group.id);
+ const status = readStatusOf(reader.actorType, reader.actorId);
+ return [
+ {
+ id: reader.actorId,
+ name: reader.actorName ?? reader.actorId,
+ type: reader.actorType,
+ isDirect: false,
+ groupIds,
+ lastReadAt: status?.kind === "read" ? status.lastReadAt : undefined,
+ unreadSince: status?.kind === "unread" ? status.since : undefined
+ }
+ ];
+ });
+ const readers = [...directReaders, ...groupOnlyReaders];
const groupIdsInUse = new Set(
readers.flatMap((reader) => (reader.isDirect ? [] : reader.groupIds))
);