Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix lint

Matheus Nogueira569bbe487963
diff --git a/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.test.ts b/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.test.ts
index f9c5d918e0..1fdba9b389 100644
--- a/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.test.ts
+++ b/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-fns.test.ts
@@ -14,9 +14,17 @@ import {
scanGitHubCommitsAndGetFindings
} from "./github-secret-scanning-fns";
-const checksUpdate = vi.fn();
-const checksCreate = vi.fn();
-const checksListForRef = vi.fn();
+type TCheckRunParams = {
+ name?: string;
+ conclusion?: string;
+ output: { annotations: { message: string }[] };
+ actions?: { identifier: string }[];
+};
+
+const checksUpdate = vi.fn<(params: TCheckRunParams) => Promise<void>>();
+const checksCreate = vi.fn<(params: TCheckRunParams) => Promise<void>>();
+const checksListForRef =
+ vi.fn<(params: Record<string, unknown>) => Promise<{ data: { total_count: number; check_runs: unknown[] } }>>();
vi.mock("probot", () => ({
ProbotOctokit: vi.fn(() => ({ checks: { update: checksUpdate, create: checksCreate, listForRef: checksListForRef } }))
@@ -30,10 +38,10 @@ vi.mock("@app/lib/config/env", async (importOriginal) => ({
})
}));
-const scanContentAndGetFindings = vi.fn();
+const scanContentAndGetFindings = vi.fn<(content: string, configPath?: string) => Promise<unknown[]>>();
vi.mock("@app/ee/services/secret-scanning/secret-scanning-queue/secret-scanning-fns", () => ({
- scanContentAndGetFindings: (...args: unknown[]) => scanContentAndGetFindings(...args)
+ scanContentAndGetFindings: (content: string, configPath?: string) => scanContentAndGetFindings(content, configPath)
}));
vi.mock("@app/lib/logger", () => ({
@@ -187,7 +195,7 @@ describe("completePullRequestCheckRun", () => {
expect(second.output.annotations).toHaveLength(50);
expect(second.conclusion).toBeUndefined();
expect(third.output.annotations).toHaveLength(20);
- expect(first.actions.map((action: { identifier: string }) => action.identifier)).toEqual([
+ expect(first.actions?.map((action) => action.identifier)).toEqual([
SecretScanningFindingStatus.FalsePositive,
SecretScanningFindingStatus.Ignore
]);
@@ -234,7 +242,7 @@ describe("scanGitHubCommitsAndGetFindings", () => {
commits: [{ sha: "a".repeat(40), authorName: "a", authorEmail: "[email protected]", date: "", message: "m" }]
});
- const scanned = scanContentAndGetFindings.mock.calls.map(([content]) => (content as string).trim());
+ const scanned = scanContentAndGetFindings.mock.calls.map(([content]) => content.trim());
expect(scanned).toEqual(["added", "modified", "renamed", "copied", "changed"]);
});
});
diff --git a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-schemas.ts b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-schemas.ts
index 13ec7ef586..431eb65d6a 100644
--- a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-schemas.ts
+++ b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-schemas.ts
@@ -6,10 +6,7 @@ import {
SecretScanningResourcesSchema,
SecretScanningScansSchema
} from "@app/db/schemas";
-import {
- SecretScanningDataSource,
- SecretScanningScanTrigger
-} from "@app/ee/services/secret-scanning-v2/secret-scanning-v2-enums";
+import { SecretScanningDataSource } from "@app/ee/services/secret-scanning-v2/secret-scanning-v2-enums";
import { SECRET_SCANNING_DATA_SOURCE_CONNECTION_MAP } from "@app/ee/services/secret-scanning-v2/secret-scanning-v2-maps";
import { SecretScanningDataSources } from "@app/lib/api-docs";
import { slugSchema } from "@app/server/lib/schemas";
@@ -132,7 +129,4 @@ export const SecretScanningScanSchema = SecretScanningScansSchema.omit({
lastScannedCommitDigest: true,
progressUpdatedAt: true,
metadata: true
-}).extend({
- // Null for scans created before the trigger was recorded.
- trigger: z.nativeEnum(SecretScanningScanTrigger).nullable().optional()
});