Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix(agent-vault): refuse a group whose organization membership is deactivated

Scott Wilson5ff075d830ad
diff --git a/backend/src/ee/services/agent-vault-member/agent-vault-membership-service.test.ts b/backend/src/ee/services/agent-vault-member/agent-vault-membership-service.test.ts
index 92abd44259..335230e289 100644
--- a/backend/src/ee/services/agent-vault-member/agent-vault-membership-service.test.ts
+++ b/backend/src/ee/services/agent-vault-member/agent-vault-membership-service.test.ts
@@ -251,6 +251,26 @@ describe("agentVaultMembership guards", () => {
expect(deps.membershipDAL.insertMany).not.toHaveBeenCalled();
});
+ // A group whose organization membership was deactivated must not be restorable by adding it again.
+ test("refuses a group whose organization membership is deactivated", async () => {
+ const { service, deps } = buildService();
+ deps.membershipDAL.find.mockResolvedValue([{ id: "org-mem", actorGroupId: GROUP_ID, isActive: false }]);
+
+ await expect(
+ service.addProductMembers({
+ projectId: PROJECT_ID,
+ userIds: [],
+ machineIdentityIds: [],
+ groupIds: [GROUP_ID],
+ emails: [],
+ role: ProjectMembershipRole.Member,
+ ctx
+ })
+ ).rejects.toThrow("not found");
+
+ expect(deps.membershipDAL.insertMany).not.toHaveBeenCalled();
+ });
+
test("refuses to change your own role", async () => {
const { service, deps } = buildService();
diff --git a/backend/src/ee/services/agent-vault-member/agent-vault-membership-service.ts b/backend/src/ee/services/agent-vault-member/agent-vault-membership-service.ts
index 0a3f3df991..7023952a27 100644
--- a/backend/src/ee/services/agent-vault-member/agent-vault-membership-service.ts
+++ b/backend/src/ee/services/agent-vault-member/agent-vault-membership-service.ts
@@ -365,7 +365,8 @@ export const agentVaultMembershipServiceFactory = ({
const userMemberIds = activeIds(userMemberships, "actorUserId");
const identityMemberIds = activeIds(identityMemberships, "actorIdentityId");
- const foundGroups = new Set(groupMemberships.map((membership) => membership.actorGroupId));
+ // Active, so a deactivated group cannot be restored to Agent Vault by adding it again.
+ const foundGroups = activeIds(groupMemberships, "actorGroupId");
const missingGroups = groupIds.filter((id) => !foundGroups.has(id));
if (missingGroups.length) {
throw new NotFoundError({ message: `Group(s) ${missingGroups.map((el) => `'${el}'`).join(", ")} not found` });