Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

Fix

Carlos Monastyrski6229e77f82ed
diff --git a/backend/src/services/pki-sync/palo-alto-networks/palo-alto-networks-pki-sync-fns.ts b/backend/src/services/pki-sync/palo-alto-networks/palo-alto-networks-pki-sync-fns.ts
index 12aadcd700..e4451fa1e3 100644
--- a/backend/src/services/pki-sync/palo-alto-networks/palo-alto-networks-pki-sync-fns.ts
+++ b/backend/src/services/pki-sync/palo-alto-networks/palo-alto-networks-pki-sync-fns.ts
@@ -520,6 +520,11 @@ export const paloAltoNetworksPkiSyncFactory = ({
let hasDeviceChanges = false;
for (const upload of plannedUploads) {
+ let isWriting = false;
+ const beforeWrite = async () => {
+ isWriting = true;
+ await deployPending.mark();
+ };
try {
const fingerprint = getFingerprint(upload.cert);
if (
@@ -542,12 +547,12 @@ export const paloAltoNetworksPkiSyncFactory = ({
upload.fullCertificateChain ?? upload.certificateChain,
existingCertificates,
knownCaFingerprints,
- deployPending.mark
+ beforeWrite
);
hasDeviceChanges ||= importedCa;
if (!fingerprint || existingCertificates.get(upload.name) !== fingerprint || keylessNames.has(upload.name)) {
- await deployPending.mark();
+ await beforeWrite();
await importKeyPair(client, config, upload.name, upload.cert, upload.privateKey);
hasDeviceChanges = true;
existingCertificates.set(upload.name, fingerprint);
@@ -555,7 +560,7 @@ export const paloAltoNetworksPkiSyncFactory = ({
succeeded.push(upload);
} catch (error) {
- if (!(error instanceof PanOsApiError) && !(error instanceof PkiSyncError)) hasDeviceChanges = true;
+ if (isWriting && !(error instanceof PanOsApiError)) hasDeviceChanges = true;
failedUploads.push({ name: upload.mapKey, error: describePanOsError(error) });
logger.error(
{ error },
diff --git a/docs/documentation/platform/pki/applications/certificate-syncs/palo-alto-networks-ssl-tls-profile.mdx b/docs/documentation/platform/pki/applications/certificate-syncs/palo-alto-networks-ssl-tls-profile.mdx
index 61188e6715..cf30cbe86d 100644
--- a/docs/documentation/platform/pki/applications/certificate-syncs/palo-alto-networks-ssl-tls-profile.mdx
+++ b/docs/documentation/platform/pki/applications/certificate-syncs/palo-alto-networks-ssl-tls-profile.mdx
@@ -12,7 +12,8 @@ To deploy several certificates without changing a profile, use a [Palo Alto Netw
- An [application](/documentation/platform/pki/applications/overview) that holds the certificate to deploy
- A [Palo Alto Networks connection](/integrations/app-connections/palo-alto-networks) to the firewall or Panorama
-- On a Panorama, a template. To push to firewalls, the template must belong to at least one template stack
+- On a Panorama, a template
+- To push to firewalls, a template stack that contains the template
- An SSL/TLS service profile on the firewall or in the template, either shared or in a virtual system
## Create a sync
diff --git a/docs/documentation/platform/pki/applications/certificate-syncs/palo-alto-networks.mdx b/docs/documentation/platform/pki/applications/certificate-syncs/palo-alto-networks.mdx
index 3e0a895784..75122c7d1a 100644
--- a/docs/documentation/platform/pki/applications/certificate-syncs/palo-alto-networks.mdx
+++ b/docs/documentation/platform/pki/applications/certificate-syncs/palo-alto-networks.mdx
@@ -12,7 +12,8 @@ For a certificate that a service on the device uses, such as the management web
- An [application](/documentation/platform/pki/applications/overview) that holds the certificates to deploy
- A [Palo Alto Networks connection](/integrations/app-connections/palo-alto-networks) to the firewall or Panorama
-- On a Panorama, a template. To push to firewalls, the template must belong to at least one template stack
+- On a Panorama, a template
+- To push to firewalls, a template stack that contains the template
## Create a sync