Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

only block project deletion on imports when cross-project sharing is on

DimitrisStaratzis65e7e2813f26
diff --git a/backend/e2e-test/routes/v1/project.spec.ts b/backend/e2e-test/routes/v1/project.spec.ts
index e0fd764aaa..6081fe3045 100644
--- a/backend/e2e-test/routes/v1/project.spec.ts
+++ b/backend/e2e-test/routes/v1/project.spec.ts
@@ -219,13 +219,8 @@ describe("Project deletion (soft-delete + async cleanup)", async () => {
expect(blockedRes.statusCode).toBe(400);
expect(JSON.parse(blockedRes.payload).message).toContain(importer.name);
- const removeRes = await testServer.inject({
- method: "DELETE",
- url: `/api/v2/secret-imports/${importRes.json().secretImport.id}`,
- headers,
- body: { projectId: importer.id, environment: "dev", path: "/" }
- });
- expect(removeRes.statusCode).toBe(200);
+ // with sharing off the import is inactive (and hidden), so it no longer blocks the delete
+ await testDb(TableName.Organization).where({ id: orgId }).update({ allowCrossProjectSecretSharing: false });
expect((await deleteProject(source.id, true)).statusCode).toBe(200);
await deleteProject(importer.id, true);
diff --git a/backend/src/services/project/project-service.ts b/backend/src/services/project/project-service.ts
index b5ede62497..4f16676f53 100644
--- a/backend/src/services/project/project-service.ts
+++ b/backend/src/services/project/project-service.ts
@@ -882,7 +882,11 @@ export const projectServiceFactory = ({
// Deleting a project that others import from would silently drop those secrets from their reads and
// syncs, and the deleter may not be a member of those projects, so the imports must be removed first.
- const importingProjects = await projectDAL.findProjectsImportingFrom(project.id);
+ // With cross-project sharing off, those imports are already ignored by reads and hidden from the list.
+ const { allowCrossProjectSecretSharing } = (await orgDAL.findOne({ id: project.orgId })) ?? {};
+ const importingProjects = allowCrossProjectSecretSharing
+ ? await projectDAL.findProjectsImportingFrom(project.id)
+ : [];
if (importingProjects.length) {
throw new BadRequestError({
message: `Project '${project.name}' can't be deleted while other projects import secrets from it: ${importingProjects.map(({ name }) => `'${name}'`).join(", ")}. Remove those secret imports first, then retry.`