Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
fix(reminders): use a generic title for reminder alerts
Calvin6dabf2741481
diff --git a/backend/src/services/alert/providers/secret-reminder-alert-provider.test.ts b/backend/src/services/alert/providers/secret-reminder-alert-provider.test.tsindex 4f1de65483..7de0d424d0 100644--- a/backend/src/services/alert/providers/secret-reminder-alert-provider.test.ts+++ b/backend/src/services/alert/providers/secret-reminder-alert-provider.test.ts@@ -66,7 +66,7 @@ const buildProvider = (const alertContext: TAlertContext = {id: "alert-1",- name: "Reminder for DB_PASSWORD",+ name: "Secret reminder",orgId: "org-1",projectId: "proj-1",resourceType: SECRET_REMINDER_RESOURCE_TYPE,diff --git a/backend/src/services/alert/providers/secret-reminder-alert-provider.ts b/backend/src/services/alert/providers/secret-reminder-alert-provider.tsindex 1b85630b08..1a9aef1667 100644--- a/backend/src/services/alert/providers/secret-reminder-alert-provider.ts+++ b/backend/src/services/alert/providers/secret-reminder-alert-provider.ts@@ -170,8 +170,7 @@ export const secretReminderAlertProviderFactory = ({throw new BadRequestError({ message: "Secret reminders must be managed within a project" });}if (!input.resourceId) {- // A reminder alert's name carries its secret key, so a listing across a project would reveal keys- // the caller may not be allowed to see.+ // A project-wide listing would reveal the keys of secrets the caller may not be allowed to see.throw new BadRequestError({ message: "Secret reminders can only be managed for a single secret" });}const [secret] = await $loadSecretsWithPath([input.resourceId]);diff --git a/backend/src/services/reminder/reminder-service.test.ts b/backend/src/services/reminder/reminder-service.test.tsindex f5e85a22c9..284da17383 100644--- a/backend/src/services/reminder/reminder-service.test.ts+++ b/backend/src/services/reminder/reminder-service.test.ts@@ -300,7 +300,7 @@ describe("reminder alert sync", () => {expect(alertRequests).toEqual([expect.objectContaining({- name: "Reminder for DB_PASSWORD",+ name: "Secret reminder",resourceType: SECRET_REMINDER_RESOURCE_TYPE,resourceId: "secret-1",eventType: SECRET_REMINDER_DUE_EVENT,@@ -349,16 +349,6 @@ describe("reminder alert sync", () => {expect(writeTxs).toEqual([callerTx, callerTx]);});- test("a rename in the same request names the alert after the new key", async () => {- const { service, alertRequests } = buildWriteService();- await service.prepareReminder({- ...caller,- secretKey: "RENAMED",- reminder: { secretId: "secret-1", repeatDays: 30, recipients: ["user-1"] }- } as never);- expect(alertRequests).toEqual([expect.objectContaining({ name: "Reminder for RENAMED" })]);- });-test("no recipients means everyone in the project", async () => {const { service, alertRequests } = buildWriteService();await saveReminder(service, { recipients: [] });diff --git a/backend/src/services/reminder/reminder-service.ts b/backend/src/services/reminder/reminder-service.tsindex 857b929706..9cc26fe3d1 100644--- a/backend/src/services/reminder/reminder-service.ts+++ b/backend/src/services/reminder/reminder-service.ts@@ -24,9 +24,8 @@ import { TCreateReminderDTO, TReminderMove, TReminderServiceFactory } from "./reconst ORPHAN_REAP_BATCH_SIZE = 500;const MAX_ORPHAN_REAP_BATCHES = 20;-const MAX_ALERT_NAME_LENGTH = 255;-const reminderAlertName = (secretKey: string) => `Reminder for ${secretKey}`.slice(0, MAX_ALERT_NAME_LENGTH);+const REMINDER_ALERT_NAME = "Secret reminder";type TReminderServiceFactoryDep = {reminderDAL: TReminderDALFactory;@@ -168,8 +167,7 @@ export const reminderServiceFactory = ({actorId,actorOrgId,actorAuthMethod,- reminder,- secretKey+ reminder}) => {const { secret, subjectFields } = await $getSecretForPermissionCheck(reminder.secretId!);const { permission } = await permissionService.getProjectPermission({@@ -194,7 +192,7 @@ export const reminderServiceFactory = ({resourceId: secret.id,projectId: secret.projectId,eventType: SECRET_REMINDER_DUE_EVENT,- name: reminderAlertName(secretKey ?? secret.key),+ name: REMINDER_ALERT_NAME,channels: reminder.channels? { replaceAll: reminder.channels }: {diff --git a/backend/src/services/reminder/reminder-types.ts b/backend/src/services/reminder/reminder-types.tsindex 42fc057202..74ff9ce01e 100644--- a/backend/src/services/reminder/reminder-types.ts+++ b/backend/src/services/reminder/reminder-types.ts@@ -31,11 +31,7 @@ export type TCreateReminderDTO = {};};-export type TPrepareReminderDTO = TCreateReminderDTO & {- // The key the secret will have once the caller's own write lands (eg a rename in the same update), so- // the alert is named after it rather than the key being replaced.- secretKey?: string;-};+export type TPrepareReminderDTO = TCreateReminderDTO;// A reminder that has passed every check, ready to be written with applyReminder in the caller's// transaction.diff --git a/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts b/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.tsindex 267067e398..516ae1a13a 100644--- a/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts+++ b/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts@@ -798,7 +798,6 @@ export const secretV2BridgeServiceFactory = ({actorId,actorOrgId,actorAuthMethod,- secretKey: inputSecret.newSecretName || inputSecret.secretName,reminder: {secretId,message: inputSecret.secretReminderNote,