Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
fix(ui): anchor expanded secret trigger to viewport
andrewhuhh6e08160bbba0
diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsxindex d04d4a51ed..e3bc4598f4 100644--- a/frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx+++ b/frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx@@ -303,72 +303,61 @@ export const SecretTableRow = ({pendingActionRowClass(singleEnvPendingAction))}>- <TableCell- className={twMerge(- "w-10 max-w-10 min-w-10 p-0",- !isSingleEnvView && "sticky left-0 z-10",- !singleEnvPendingAction &&- "bg-container transition-colors duration-75 group-hover:bg-container-hover",- !isSingleEnvView && isFormExpanded && "z-20 border-b-0 bg-container-hover",- isSingleEnvView && singleEnvShowOverride && "border-b-border/50",- isSingleEnvView && "relative",- pendingActionBorderClass(singleEnvPendingAction)- )}- >- <div className="flex h-full items-center justify-center [&>svg]:size-4">- <Checkbox- variant="project"- id={`checkbox-${secretKey}`}- isChecked={isSelected}- onClick={(e) => {- e.stopPropagation();- onToggleSecretSelect(secretKey, e.shiftKey);- }}- className={twMerge(- "hidden",- !isSelectionDisabled && "group-hover:flex",- isSelected && "flex"- )}- />- {!isSingleEnvView && isFormExpanded ? (- <ChevronDownIcon+ {(isSingleEnvView || !isFormExpanded) && (+ <TableCell+ className={twMerge(+ "w-10 max-w-10 min-w-10 p-0",+ !isSingleEnvView && "sticky left-0 z-10",+ !singleEnvPendingAction &&+ "bg-container transition-colors duration-75 group-hover:bg-container-hover",+ isSingleEnvView && singleEnvShowOverride && "border-b-border/50",+ isSingleEnvView && "relative",+ pendingActionBorderClass(singleEnvPendingAction)+ )}+ >+ <div className="flex h-full items-center justify-center [&>svg]:size-4">+ <Checkbox+ variant="project"+ id={`checkbox-${secretKey}`}+ isChecked={isSelected}+ onClick={(e) => {+ e.stopPropagation();+ onToggleSecretSelect(secretKey, e.shiftKey);+ }}className={twMerge(- "block",+ "hidden",+ !isSelectionDisabled && "group-hover:flex",+ isSelected && "flex"+ )}+ />+ <KeyIcon+ className={twMerge(+ "block text-secret",!isSelectionDisabled && "group-hover:!hidden",isSelected && "!hidden")}/>- ) : (- <>- <KeyIcon+ {singleEnvSecret?.isRotatedSecret && isSingleEnvView && (+ <RefreshCwIconclassName={twMerge(- "block text-secret",+ "absolute right-2 bottom-2 !size-2.5 text-secret-rotation",!isSelectionDisabled && "group-hover:!hidden",isSelected && "!hidden")}/>- {singleEnvSecret?.isRotatedSecret && isSingleEnvView && (- <RefreshCwIcon- className={twMerge(- "absolute right-2 bottom-2 !size-2.5 text-secret-rotation",- !isSelectionDisabled && "group-hover:!hidden",- isSelected && "!hidden"- )}- />- )}- {singleEnvSecret?.isHoneyTokenSecret && isSingleEnvView && (- <HexagonIcon- className={twMerge(- "absolute right-2 bottom-2 !size-2.5 text-warning",- !isSelectionDisabled && "group-hover:!hidden",- isSelected && "!hidden"- )}- />- )}- </>- )}- </div>- </TableCell>+ )}+ {singleEnvSecret?.isHoneyTokenSecret && isSingleEnvView && (+ <HexagonIcon+ className={twMerge(+ "absolute right-2 bottom-2 !size-2.5 text-warning",+ !isSelectionDisabled && "group-hover:!hidden",+ isSelected && "!hidden"+ )}+ />+ )}+ </div>+ </TableCell>+ )}{isSingleEnvView ? (<SecretEditTableRowisSingleEnvView@@ -434,82 +423,113 @@ export const SecretTableRow = ({) : (<TableCellisTruncatable={!isFormExpanded}- colSpan={isFormExpanded ? environments.length + 1 : undefined}+ colSpan={isFormExpanded ? totalCols : undefined}className={twMerge("sticky left-10 z-10 border-r bg-container transition-all duration-75 group-hover:bg-container-hover",- isFormExpanded &&- "relative left-auto border-r-0 border-b-0 bg-container-hover p-0 !pl-0"+ isFormExpanded && "relative left-auto border-r-0 border-b-0 bg-container-hover !p-0")}><div- style={isFormExpanded ? { width: Math.max(0, tableWidth - 40) } : undefined}+ style={isFormExpanded ? { minWidth: tableWidth, maxWidth: tableWidth } : undefined}className={twMerge(- isFormExpanded && "sticky left-10 min-h-10 bg-container-hover px-1 py-1.5"+ isFormExpanded && "sticky left-0 flex min-h-10 items-center bg-container-hover")}>- <div className="flex min-w-0 items-center gap-2">- <span- title={secretKey}- className={twMerge(- isFormExpanded ? "break-all whitespace-normal" : "min-w-0 truncate",- singleEnvPendingAction === PendingAction.Delete && "text-danger/75 line-through"- )}- >- {secretKey}- </span>- {!isFormExpanded &&- environments.some(- ({ slug }) => getSecretByKey(slug, secretKey)?.revokedProjectFolderGrant- ) && (- <Badge variant="danger">- <BanIcon className="size-3.5" />- Secret share revoked- </Badge>- )}- </div>+ {isFormExpanded && (+ <div className="flex w-10 shrink-0 items-center justify-center [&>svg]:size-4">+ <Checkbox+ variant="project"+ id={`checkbox-${secretKey}`}+ isChecked={isSelected}+ onClick={(e) => {+ e.stopPropagation();+ onToggleSecretSelect(secretKey, e.shiftKey);+ }}+ className={twMerge(+ "hidden",+ !isSelectionDisabled && "group-hover:flex",+ isSelected && "flex"+ )}+ />+ <ChevronDownIcon+ className={twMerge(+ "block",+ !isSelectionDisabled && "group-hover:!hidden",+ isSelected && "!hidden"+ )}+ />+ </div>+ )}<divclassName={twMerge(- "absolute z-20",- "flex items-center rounded-md border border-border bg-container-hover px-0.5 py-0.5 shadow-md",- TABLE_ROW_ACTION_BAR_CLASS_NAME,- "top-1/2 right-[3px] -translate-y-1/2"+ isFormExpanded && "relative flex min-h-10 min-w-0 flex-1 items-center px-1 py-1.5")}>- <Tooltip disableHoverableContent>- <TooltipTrigger>- <IconButton- aria-label="Copy secret name"- variant="ghost"- size="xs"- onClick={(e) => {- e.preventDefault();- e.stopPropagation();- copyTokenToClipboard();- }}- className={TABLE_ROW_ACTION_BUTTON_CLASS_NAME}- >- {isSecNameCopied ? <ClipboardCheckIcon /> : <CopyIcon />}- </IconButton>- </TooltipTrigger>- <TooltipContent>Copy Secret Name</TooltipContent>- </Tooltip>- <Tooltip disableHoverableContent>- <TooltipTrigger>- <IconButton- aria-label="Edit secret name"- variant="ghost"- size="xs"- onClick={(e) => {- setIsEditSecretNameOpen(true);- e.stopPropagation();- }}- className={TABLE_ROW_ACTION_BUTTON_CLASS_NAME}- >- <EditIcon />- </IconButton>- </TooltipTrigger>- <TooltipContent>Edit Secret Name</TooltipContent>- </Tooltip>+ <div className="flex min-w-0 items-center gap-2">+ <span+ title={secretKey}+ className={twMerge(+ isFormExpanded ? "break-all whitespace-normal" : "min-w-0 truncate",+ singleEnvPendingAction === PendingAction.Delete &&+ "text-danger/75 line-through"+ )}+ >+ {secretKey}+ </span>+ {!isFormExpanded &&+ environments.some(+ ({ slug }) => getSecretByKey(slug, secretKey)?.revokedProjectFolderGrant+ ) && (+ <Badge variant="danger">+ <BanIcon className="size-3.5" />+ Secret share revoked+ </Badge>+ )}+ </div>+ <div+ className={twMerge(+ "absolute z-20",+ "flex items-center rounded-md border border-border bg-container-hover px-0.5 py-0.5 shadow-md",+ TABLE_ROW_ACTION_BAR_CLASS_NAME,+ "top-1/2 right-[3px] -translate-y-1/2"+ )}+ >+ <Tooltip disableHoverableContent>+ <TooltipTrigger>+ <IconButton+ aria-label="Copy secret name"+ variant="ghost"+ size="xs"+ onClick={(e) => {+ e.preventDefault();+ e.stopPropagation();+ copyTokenToClipboard();+ }}+ className={TABLE_ROW_ACTION_BUTTON_CLASS_NAME}+ >+ {isSecNameCopied ? <ClipboardCheckIcon /> : <CopyIcon />}+ </IconButton>+ </TooltipTrigger>+ <TooltipContent>Copy Secret Name</TooltipContent>+ </Tooltip>+ <Tooltip disableHoverableContent>+ <TooltipTrigger>+ <IconButton+ aria-label="Edit secret name"+ variant="ghost"+ size="xs"+ onClick={(e) => {+ setIsEditSecretNameOpen(true);+ e.stopPropagation();+ }}+ className={TABLE_ROW_ACTION_BUTTON_CLASS_NAME}+ >+ <EditIcon />+ </IconButton>+ </TooltipTrigger>+ <TooltipContent>Edit Secret Name</TooltipContent>+ </Tooltip>+ </div></div></div></TableCell>