Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
Update secret-read-activity-service.ts
varonix6fb7e620d65f
diff --git a/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts b/backend/src/ee/services/secret-read-activity/secret-read-activity-service.tsindex a76182f7ad..e2a7dde32d 100644--- a/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts+++ b/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts@@ -170,25 +170,29 @@ export const secretReadActivityServiceFactory = ({// Every loaded secret is decrypted once to find the keys it references in its own folder. The edges are indexed// by "<referenced folder>:<referenced key>", since scanning a folder for every secret in it would be quadratic.+ // Decrypting is synchronous work, so the loop yields to the event loop between batches, like the reach loop below.const { decryptor } = await kmsService.createCipherPairWithDataKey({ type: KmsDataKey.SecretManager, projectId });const loadedSecrets = [...secretsByFolder.values()].flat();const secretById = new Map(loadedSecrets.map((secret) => [secret.id, secret]));- const referenceEdges: { target: string; referencer: TReachSecret }[] = [- ...loadedSecrets.flatMap((secret) => {- if (!secret.encryptedValue) return [];+ const referenceEdges: { target: string; referencer: TReachSecret }[] = references.map((reference) => ({+ target: `${reference.targetFolderId}:${reference.secretKey}`,+ referencer: secretById.get(reference.secretId) ?? { id: reference.secretId, folderId: reference.folderId }+ }));+ for (let index = 0; index < loadedSecrets.length; index += 1) {+ if (index > 0 && index % REACH_YIELD_INTERVAL === 0) {+ // eslint-disable-next-line no-await-in-loop+ await setImmediate();+ }+ const secret = loadedSecrets[index];+ if (secret.encryptedValue) {const { localReferences } = getAllSecretReferences(decryptor({ cipherTextBlob: secret.encryptedValue }).toString());- return [...new Set(localReferences)].map((key) => ({- target: `${secret.folderId}:${key}`,- referencer: secret- }));- }),- ...references.map((reference) => ({- target: `${reference.targetFolderId}:${reference.secretKey}`,- referencer: secretById.get(reference.secretId) ?? { id: reference.secretId, folderId: reference.folderId }- }))- ];+ new Set(localReferences).forEach((key) => {+ referenceEdges.push({ target: `${secret.folderId}:${key}`, referencer: secret });+ });+ }+ }const referenceEdgesByTarget = groupBy(referenceEdges, (edge) => edge.target);// Replication imports are included: a replicated copy is checked against the reader's access to its source.