Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

improvement(secrets): surface secret imports in Add New dropdown (#8769)

Andrew Huang71c393c19112
diff --git a/docs/documentation/platform/folder.mdx b/docs/documentation/platform/folder.mdx
index 152f9132a0..2cd82b6707 100644
--- a/docs/documentation/platform/folder.mdx
+++ b/docs/documentation/platform/folder.mdx
@@ -28,7 +28,7 @@ By extending this example, you can see how path-based secret storage provides a
## Managing folders
-To add a folder, select the chevron next to **Add Secret**, then select **Add Folder**.
+To add a folder, select **Add New**, then select **New Folder**.
<Info>
Folder names can only contain alphabets, numbers, and dashes
diff --git a/docs/documentation/platform/secret-reference.mdx b/docs/documentation/platform/secret-reference.mdx
index 2f6a850a8d..19053108cc 100644
--- a/docs/documentation/platform/secret-reference.mdx
+++ b/docs/documentation/platform/secret-reference.mdx
@@ -60,7 +60,7 @@ Here are a few more helpful examples for how to reference secrets in different c
Infisical's Secret Imports functionality makes it possible to import the secrets from another environment or folder into the current folder context.
This can be useful if you have common secrets that need to be available across multiple environments/folders.
-To add a secret import, select the chevron next to **Add Secret**, then select **Add Secret Import**.
+To add a secret import, select **Add New**, then select **Import Secrets**.
![Add Secret Import dialog](../../images/platform/secret-references-imports/secret-import-add.png)
@@ -182,8 +182,8 @@ You can also import secrets from a different project entirely. Cross-project imp
To create a cross-project import:
-1. Select the chevron next to **Add Secret**, then select **Add Secret Import**.
-![The Add Secret menu, showing Add Secret Import](../../images/platform/secret-references-imports/08-add-secret-import.png)
+1. Select **Add New**, then select **Import Secrets**.
+![The Add New menu, showing Import Secrets](../../images/platform/secret-references-imports/08-add-secret-import.png)
2. Select **Another Project**.
![The Add Secret Import dialog with Another Project selected](../../images/platform/secret-references-imports/09-other-project.png)
3. Choose the source **Project**, **Environment**, and **Folder path**, then select **Create Import**.
diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/AddResourceButtons/AddResourceButtons.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/AddResourceButtons/AddResourceButtons.tsx
index c6bd231628..188daca30f 100644
--- a/frontend/src/pages/secret-manager/OverviewPage/components/AddResourceButtons/AddResourceButtons.tsx
+++ b/frontend/src/pages/secret-manager/OverviewPage/components/AddResourceButtons/AddResourceButtons.tsx
@@ -163,10 +163,19 @@ export function AddResourceButtons({
isDisabled={!canCreateSecrets}
>
<KeyIcon className="text-secret" />
- Add Secret
+ New Secret
</DropdownMenuItem>
</MenuItemTooltip>
)}
+ <MenuItemTooltip isDisabled={!canCreateFolders} content="Access Restricted">
+ <DropdownMenuItem
+ onClick={selectAction("folder", onAddFolder)}
+ isDisabled={!canCreateFolders}
+ >
+ <FolderIcon className="text-folder" />
+ New Folder
+ </DropdownMenuItem>
+ </MenuItemTooltip>
<MenuItemTooltip isDisabled={!canCreateSecrets} content="Access Restricted">
<DropdownMenuItem
onClick={selectAction("upload-secrets", onImportSecrets)}
@@ -176,17 +185,24 @@ export function AddResourceButtons({
Upload Secrets
</DropdownMenuItem>
</MenuItemTooltip>
- <MenuItemTooltip isDisabled={!canCreateFolders} content="Access Restricted">
+ <DropdownMenuSeparator />
+ <DropdownMenuLabel>Advanced</DropdownMenuLabel>
+ <MenuItemTooltip
+ isDisabled={!isSecretImportAvailable || !isSingleEnvSelected}
+ content={
+ !isSecretImportAvailable
+ ? "Access Restricted"
+ : "Select a single environment to import secrets"
+ }
+ >
<DropdownMenuItem
- onClick={selectAction("folder", onAddFolder)}
- isDisabled={!canCreateFolders}
+ onClick={selectAction("secret-import", onAddSecretImport)}
+ isDisabled={!isSecretImportAvailable || !isSingleEnvSelected}
>
- <FolderIcon className="text-folder" />
- Add Folder
+ <ImportIcon className="text-import" />
+ Import Secrets
</DropdownMenuItem>
</MenuItemTooltip>
- <DropdownMenuSeparator />
- <DropdownMenuLabel>Advanced</DropdownMenuLabel>
<MenuItemTooltip isDisabled={!isDyanmicSecretAvailable} content="Access Restricted">
<DropdownMenuItem
onClick={selectAction("dynamic-secret", onAddDyanamicSecret)}
@@ -205,18 +221,6 @@ export function AddResourceButtons({
Add Secret Rotation
</DropdownMenuItem>
</MenuItemTooltip>
- <MenuItemTooltip
- isDisabled={!isHoneyTokenAvailable || !canCreateHoneyTokens}
- content="Access Restricted"
- >
- <DropdownMenuItem
- onClick={selectAction("honey-token", onAddHoneyToken)}
- isDisabled={!isHoneyTokenAvailable || !canCreateHoneyTokens}
- >
- <HexagonIcon className="text-warning" />
- Add Honey Token
- </DropdownMenuItem>
- </MenuItemTooltip>
<ProjectPermissionCan
I={ProjectPermissionProxiedServiceActions.Create}
a={ProjectPermissionSub.ProxiedServices}
@@ -240,28 +244,24 @@ export function AddResourceButtons({
</MenuItemTooltip>
)}
</ProjectPermissionCan>
+ <MenuItemTooltip
+ isDisabled={!isHoneyTokenAvailable || !canCreateHoneyTokens}
+ content="Access Restricted"
+ >
+ <DropdownMenuItem
+ onClick={selectAction("honey-token", onAddHoneyToken)}
+ isDisabled={!isHoneyTokenAvailable || !canCreateHoneyTokens}
+ >
+ <HexagonIcon className="text-warning" />
+ Add Honey Token
+ </DropdownMenuItem>
+ </MenuItemTooltip>
<DropdownMenuSub onOpenChange={(isOpen) => isOpen && onMenuOpen(variant, "more")}>
<DropdownMenuSubTrigger>
<ListPlusIcon />
- Add More
+ More
</DropdownMenuSubTrigger>
<DropdownMenuSubContent>
- <MenuItemTooltip
- isDisabled={!isSecretImportAvailable || !isSingleEnvSelected}
- content={
- !isSecretImportAvailable
- ? "Access Restricted"
- : "Select a single environment to add a secret import"
- }
- >
- <DropdownMenuItem
- onSelect={selectAction("secret-import", onAddSecretImport)}
- isDisabled={!isSecretImportAvailable || !isSingleEnvSelected}
- >
- <ImportIcon className="text-import" />
- Add Secret Import
- </DropdownMenuItem>
- </MenuItemTooltip>
<MenuItemTooltip
isDisabled={isCopySecretsDisabled || !canCopySecrets}
content={
@@ -291,7 +291,7 @@ export function AddResourceButtons({
isDisabled={!canCreateSecretSyncs || !isSingleEnvSelected}
>
<RefreshCwIcon className="text-accent" />
- Add Secret Sync
+ New Secret Sync
</DropdownMenuItem>
</MenuItemTooltip>
{(hasVaultConnection || hasDopplerConnection) && <DropdownMenuSeparator />}